From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Tom Rini <trini@konsulko.com>
Cc: Quentin Schulz <quentin.schulz@cherry.de>,
FUKAUMI Naoki <naoki@radxa.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v4 01/10] rockchip: binman: Correct the OS prop for U-Boot
Date: Sun, 6 Apr 2025 23:17:39 +0800 [thread overview]
Message-ID: <34bddc8c-24fa-452e-be04-9074ba2d0506@rock-chips.com> (raw)
In-Reply-To: <20250329150626.2879942-2-jonas@kwiboo.se>
On 2025/3/29 23:06, Jonas Karlman wrote:
> From: Simon Glass <sjg@chromium.org>
>
> The U-Boot image is currently being identified as an invalid OS in
> spl_fit_image_get_os() due to case sensitive compare.
>
> Use the correct lower-case value to fix this.
>
> Fixes: e0c0efff2a02 ("rockchip: Support building the all output files in binman")
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> Changes in v4:
> - Update commit message
> - Split from "VBE serial part H: Implement VBE on Rockchip RK3399"
> ---
> arch/arm/dts/rockchip-u-boot.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi
> index c8c928c7e508..e9ed1d4b5738 100644
> --- a/arch/arm/dts/rockchip-u-boot.dtsi
> +++ b/arch/arm/dts/rockchip-u-boot.dtsi
> @@ -50,7 +50,7 @@
> u-boot {
> description = "U-Boot";
> type = "standalone";
> - os = "U-Boot";
> + os = "u-boot";
> #ifdef CONFIG_ARM64
> arch = "arm64";
> #else
next prev parent reply other threads:[~2025-04-06 15:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 15:06 [PATCH v4 00/10] rockchip: binman: Use a template for FIT and other improvements Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 01/10] rockchip: binman: Correct the OS prop for U-Boot Jonas Karlman
2025-04-06 15:17 ` Kever Yang [this message]
2025-04-09 9:15 ` Quentin Schulz
2025-04-09 11:35 ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 02/10] rockchip: binman: Factor out arch and compression Jonas Karlman
2025-04-06 15:18 ` Kever Yang
2025-04-09 9:28 ` Quentin Schulz
2025-04-09 11:56 ` Jonas Karlman
2025-04-09 12:27 ` Quentin Schulz
2025-04-09 15:52 ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 03/10] rockchip: binman: Add an fdtmap Jonas Karlman
2025-04-06 15:18 ` Kever Yang
2025-04-09 9:32 ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 04/10] rockchip: binman: Create a template for the FIT Jonas Karlman
2025-04-06 15:32 ` Kever Yang
2025-04-09 9:39 ` Quentin Schulz
2025-04-09 11:58 ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 05/10] rockchip: binman: Un-indent the FIT template Jonas Karlman
2025-04-06 15:33 ` Kever Yang
2025-04-09 9:41 ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 06/10] rockchip: binman: Use the FIT template in the SPI image Jonas Karlman
2025-04-06 15:33 ` Kever Yang
2025-04-09 9:42 ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 07/10] rockchip: binman: Include a compatible string in each configuration Jonas Karlman
2025-04-06 15:33 ` Kever Yang
2025-04-09 10:02 ` Quentin Schulz
2025-04-09 13:23 ` Simon Glass
2025-04-09 15:05 ` Jonas Karlman
2025-04-09 15:26 ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 08/10] rockchip: binman: Use the skip-at-start prop in simple-bin image Jonas Karlman
2025-04-06 15:33 ` Kever Yang
2025-04-09 10:57 ` Quentin Schulz
2025-04-09 13:22 ` Simon Glass
2025-04-09 13:32 ` Quentin Schulz
2025-04-09 13:33 ` Simon Glass
2025-04-09 13:35 ` Quentin Schulz
2025-04-09 14:30 ` Simon Glass
2025-04-14 15:09 ` Quentin Schulz
2025-04-17 21:35 ` Simon Glass
2025-04-09 15:17 ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 09/10] rockchip: binman: Support use of crc32 for SPL_FIT_SIGNATURE Jonas Karlman
2025-04-06 15:34 ` Kever Yang
2025-04-09 11:06 ` Quentin Schulz
2025-04-09 15:38 ` Jonas Karlman
2025-04-09 16:11 ` Quentin Schulz
2025-04-09 16:35 ` Simon Glass
2025-04-09 17:02 ` Quentin Schulz
2025-04-09 17:26 ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 10/10] rockchip: Add SPL_PAD_TO Kconfig default value Jonas Karlman
2025-04-06 15:34 ` Kever Yang
2025-04-09 11:14 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34bddc8c-24fa-452e-be04-9074ba2d0506@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=naoki@radxa.com \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox