U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Jonas Karlman <jonas@kwiboo.se>,
	Kever Yang <kever.yang@rock-chips.com>,
	Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Tom Rini <trini@konsulko.com>
Cc: FUKAUMI Naoki <naoki@radxa.com>, u-boot@lists.denx.de
Subject: Re: [PATCH v4 04/10] rockchip: binman: Create a template for the FIT
Date: Wed, 9 Apr 2025 11:39:34 +0200	[thread overview]
Message-ID: <d7bd61f0-40a5-4fde-9e47-529cbac28a94@cherry.de> (raw)
In-Reply-To: <20250329150626.2879942-5-jonas@kwiboo.se>

Hi Jonas, Simon,

On 3/29/25 4:06 PM, Jonas Karlman wrote:
[...]
> -#if defined(CONFIG_ARM64) || defined(CONFIG_SPL_OPTEE_IMAGE)
> +#ifdef HAS_FIT
>   		fit {
>   			type = "blob";
>   			filename = "u-boot.itb";

Use the template for the SPI here already instead of splitting it in a 
separate commit?

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin


  parent reply	other threads:[~2025-04-09  9:39 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-29 15:06 [PATCH v4 00/10] rockchip: binman: Use a template for FIT and other improvements Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 01/10] rockchip: binman: Correct the OS prop for U-Boot Jonas Karlman
2025-04-06 15:17   ` Kever Yang
2025-04-09  9:15   ` Quentin Schulz
2025-04-09 11:35     ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 02/10] rockchip: binman: Factor out arch and compression Jonas Karlman
2025-04-06 15:18   ` Kever Yang
2025-04-09  9:28   ` Quentin Schulz
2025-04-09 11:56     ` Jonas Karlman
2025-04-09 12:27       ` Quentin Schulz
2025-04-09 15:52         ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 03/10] rockchip: binman: Add an fdtmap Jonas Karlman
2025-04-06 15:18   ` Kever Yang
2025-04-09  9:32   ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 04/10] rockchip: binman: Create a template for the FIT Jonas Karlman
2025-04-06 15:32   ` Kever Yang
2025-04-09  9:39   ` Quentin Schulz [this message]
2025-04-09 11:58     ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 05/10] rockchip: binman: Un-indent the FIT template Jonas Karlman
2025-04-06 15:33   ` Kever Yang
2025-04-09  9:41   ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 06/10] rockchip: binman: Use the FIT template in the SPI image Jonas Karlman
2025-04-06 15:33   ` Kever Yang
2025-04-09  9:42   ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 07/10] rockchip: binman: Include a compatible string in each configuration Jonas Karlman
2025-04-06 15:33   ` Kever Yang
2025-04-09 10:02   ` Quentin Schulz
2025-04-09 13:23     ` Simon Glass
2025-04-09 15:05     ` Jonas Karlman
2025-04-09 15:26       ` Quentin Schulz
2025-03-29 15:06 ` [PATCH v4 08/10] rockchip: binman: Use the skip-at-start prop in simple-bin image Jonas Karlman
2025-04-06 15:33   ` Kever Yang
2025-04-09 10:57   ` Quentin Schulz
2025-04-09 13:22     ` Simon Glass
2025-04-09 13:32       ` Quentin Schulz
2025-04-09 13:33         ` Simon Glass
2025-04-09 13:35           ` Quentin Schulz
2025-04-09 14:30             ` Simon Glass
2025-04-14 15:09               ` Quentin Schulz
2025-04-17 21:35                 ` Simon Glass
2025-04-09 15:17     ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 09/10] rockchip: binman: Support use of crc32 for SPL_FIT_SIGNATURE Jonas Karlman
2025-04-06 15:34   ` Kever Yang
2025-04-09 11:06   ` Quentin Schulz
2025-04-09 15:38     ` Jonas Karlman
2025-04-09 16:11       ` Quentin Schulz
2025-04-09 16:35         ` Simon Glass
2025-04-09 17:02           ` Quentin Schulz
2025-04-09 17:26         ` Jonas Karlman
2025-03-29 15:06 ` [PATCH v4 10/10] rockchip: Add SPL_PAD_TO Kconfig default value Jonas Karlman
2025-04-06 15:34   ` Kever Yang
2025-04-09 11:14   ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7bd61f0-40a5-4fde-9e47-529cbac28a94@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=naoki@radxa.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox