From: "Alex G." <mr.nuke.me@gmail.com>
To: Patrick DELAUNAY <patrick.delaunay@foss.st.com>,
u-boot@lists.denx.de, trini@konsulko.com
Cc: sjg@chromium.org, etienne.carriere@linaro.org
Subject: Re: [PATCH v3 3/5] arm: stm32mp: Implement support for TZC 400 controller
Date: Mon, 31 May 2021 12:16:26 -0500 [thread overview]
Message-ID: <35f580dc-11a4-4f84-ee54-4a7e2ee5b9ae@gmail.com> (raw)
In-Reply-To: <cc9ece5c-5ea8-6604-ece4-a140d835f447@foss.st.com>
Hi Patrick,
On 5/28/21 4:59 AM, Patrick DELAUNAY wrote:
> Hi,
>
> Any reason to prefer uint16_t and uint32_t ?
I use standard C types. u32, _u32, and __u32 are non-standard, and they
have different meanings depending on how they're used. I avoid them for
this reason.
Alex
> See checkpatch warning
>
> arch/arm/mach-stm32mp/include/mach/tzc.h:24: check: Prefer kernel type
> 'u16' over 'uint16_t'
> arch/arm/mach-stm32mp/include/mach/tzc.h:25: check: Prefer kernel type
> 'u16' over 'uint16_t'
> arch/arm/mach-stm32mp/tzc400.c:41: check: Prefer kernel type 'u16' over
> 'uint16_t'
> arch/arm/mach-stm32mp/tzc400.c:52: check: Prefer kernel type 'u32' over
> 'uint32_t'
> arch/arm/mach-stm32mp/tzc400.c:81: check: Prefer kernel type 'u32' over
> 'uint32_t'
> arch/arm/mach-stm32mp/tzc400.c:82: check: Prefer kernel type 'u32' over
> 'uint32_t'
> arch/arm/mach-stm32mp/tzc400.c:93: check: Prefer kernel type 'u32' over
> 'uint32_t'
> arch/arm/mach-stm32mp/tzc400.c:94: check: Prefer kernel type 'u32' over
> 'uint32_t'
> arch/arm/mach-stm32mp/tzc400.c:113: check: Prefer kernel type 'u32' over
> 'uint32_t'
>
> But except these remarks:
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>
> Thanks
> Patrick
>
next prev parent reply other threads:[~2021-05-31 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 16:48 [PATCH v3 0/5] stm32mp: Enable OP-TEE and TZC support in SPL Alexandru Gagniuc
2021-04-15 16:48 ` [PATCH v3 1/5] spl: mmc: Support OP-TEE payloads in Falcon mode Alexandru Gagniuc
2021-04-15 16:48 ` [PATCH v3 2/5] spl: Introduce spl_board_prepare_for_optee() hook Alexandru Gagniuc
2021-04-15 16:48 ` [PATCH v3 3/5] arm: stm32mp: Implement support for TZC 400 controller Alexandru Gagniuc
2021-05-28 9:59 ` Patrick DELAUNAY
2021-05-31 17:16 ` Alex G. [this message]
2021-04-15 16:48 ` [PATCH v3 4/5] stm32mp1: spl: Configure TrustZone controller for OP-TEE Alexandru Gagniuc
2021-05-28 10:22 ` Patrick DELAUNAY
2021-05-31 17:37 ` Alex G.
2021-04-15 16:48 ` [PATCH v3 5/5] ARM: dts: stm32mp: Add OP-TEE reserved memory to SPL dtb Alexandru Gagniuc
2021-05-28 10:26 ` Patrick DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f580dc-11a4-4f84-ee54-4a7e2ee5b9ae@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=etienne.carriere@linaro.org \
--cc=patrick.delaunay@foss.st.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox