Re: [PATCH v3] board: rockchip: add Radxa ROCK 3 Model C

["Maxim M. Moskalets" <maximmosk4@gmail.com>]

On 22.07.2024 13:28, Jonas Karlman wrote:
> Hi Maxim,
>
> On 2024-07-22 09:49, Maxim Moskalets wrote:
>> Based on rock-3a-rk3568_defconfig.
>> Tesetd on v1.31 revision.
> nit: small typo s/Tesetd/Tested/
>
>> Board Specifications:
>> - Rockchip RK3566
>> - 1/2/4GB LPDDR4 2112MT/s
>> - eMMC socket
>> - uSD card slot
>> - M.2 2230 Connector
>> - GbE LAN with POE
>> - 3.5mm jack with mic
>> - HDMI 2.0, MIPI DSI/CSI
>> - USB 3.0 Host/OTG, USB 2.0 Host
>> - 40-pin GPIO expansion ports
>>
>> Signed-off-by: Maxim Moskalets <maximmosk4@gmail.com>
>> Suggested-by: Jonas Karlman <jonas@kwiboo.se>
>> ---
>> v3:
>> 	add suggested by Jonas Karlman <jonas@kwiboo.se> in
>> 	https://lore.kernel.org/all/bbb81dd1-e318-423d-8258-db7556ce6850@kwiboo.se/
>> v2:
>> 	rebase to updated upstream dts
>> ---
>>  MAINTAINERS                             |  7 ++
>>  arch/arm/dts/rk3566-rock-3c-u-boot.dtsi | 10 +++
>>  configs/rock-3c-rk3566_defconfig        | 97 +++++++++++++++++++++++++
>>  doc/board/rockchip/rockchip.rst         |  1 +
>>  4 files changed, 115 insertions(+)
>>  create mode 100644 arch/arm/dts/rk3566-rock-3c-u-boot.dtsi
>>  create mode 100644 configs/rock-3c-rk3566_defconfig
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a6e47e8a217..b87077d3adb 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -492,6 +492,13 @@ F:	include/configs/owl-common.h
>>  F:	configs/bubblegum_96_defconfig
>>  F:	configs/cubieboard7_defconfig
>>  
>> +ARM RADXA ROCK 3 MODEL C
>> +M:	Jonas Karlman <jonas@kwiboo.se>
>> +M:	Maxim Moskalets <maximmosk4@gmail.com>
>> +S:	Maintained
>> +F:	arch/arm/dts/rk3566-rock-3c-u-boot.dtsi
>> +F:	configs/rock-3c-rk3566_defconfig
> This should possible move to board/rockchip/evb_rk3568/MAINTAINERS same
> as other boards using the evb_rk3568 target.
>
>> +
>>  ARM RENESAS RMOBILE/R-CAR
>>  M:	Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>>  M:	Marek Vasut <marek.vasut+renesas@mailbox.org>
>> diff --git a/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi b/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi
>> new file mode 100644
>> index 00000000000..fd7f5367b75
>> --- /dev/null
>> +++ b/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi
>> @@ -0,0 +1,10 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +#include "rk356x-u-boot.dtsi"
>> +
>> +&sfc {
>> +	flash@0 {
>> +		bootph-pre-ram;
>> +		bootph-some-ram;
>> +	};
>> +};
>> diff --git a/configs/rock-3c-rk3566_defconfig b/configs/rock-3c-rk3566_defconfig
>> new file mode 100644
>> index 00000000000..f44b202c8c3
>> --- /dev/null
>> +++ b/configs/rock-3c-rk3566_defconfig
>> @@ -0,0 +1,97 @@
>> +CONFIG_ARM=y
>> +CONFIG_SKIP_LOWLEVEL_INIT=y
>> +CONFIG_COUNTER_FREQUENCY=24000000
>> +CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_SF_DEFAULT_SPEED=24000000
>> +CONFIG_SF_DEFAULT_MODE=0x2000
>> +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3566-rock-3c"
>> +CONFIG_ROCKCHIP_RK3568=y
>> +CONFIG_ROCKCHIP_SPI_IMAGE=y
>> +CONFIG_SPL_SERIAL=y
>> +CONFIG_DEBUG_UART_BASE=0xFE660000
>> +CONFIG_DEBUG_UART_CLOCK=24000000
>> +CONFIG_SPL_SPI_FLASH_SUPPORT=y
>> +CONFIG_SPL_SPI=y
>> +CONFIG_SYS_LOAD_ADDR=0xc00800
>> +CONFIG_PCI=y
>> +CONFIG_DEBUG_UART=y
>> +CONFIG_AHCI=y
>> +CONFIG_FIT=y
>> +CONFIG_FIT_VERBOSE=y
>> +CONFIG_SPL_FIT_SIGNATURE=y
>> +CONFIG_SPL_LOAD_FIT=y
>> +CONFIG_LEGACY_IMAGE_FORMAT=y
>> +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3566-rock-3c.dtb"
>> +# CONFIG_DISPLAY_CPUINFO is not set
>> +CONFIG_DISPLAY_BOARDINFO_LATE=y
>> +CONFIG_SPL_MAX_SIZE=0x40000
>> +CONFIG_SPL_PAD_TO=0x7f8000
>> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
>> +CONFIG_SPL_SPI_LOAD=y
>> +CONFIG_SYS_SPI_U_BOOT_OFFS=0x60000
>> +CONFIG_SPL_ATF=y
>> +CONFIG_CMD_GPIO=y
>> +CONFIG_CMD_GPT=y
>> +CONFIG_CMD_I2C=y
>> +CONFIG_CMD_MMC=y
>> +CONFIG_CMD_PCI=y
>> +CONFIG_CMD_POWEROFF=y
>> +CONFIG_CMD_USB=y
>> +# CONFIG_CMD_SETEXPR is not set
>> +CONFIG_CMD_PMIC=y
>> +CONFIG_CMD_REGULATOR=y
>> +# CONFIG_SPL_DOS_PARTITION is not set
>> +CONFIG_SPL_OF_CONTROL=y
>> +CONFIG_OF_LIVE=y
>> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
>> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>> +CONFIG_SPL_DM_SEQ_ALIAS=y
>> +CONFIG_SPL_REGMAP=y
>> +CONFIG_SPL_SYSCON=y
>> +CONFIG_SCSI_AHCI=y
>> +CONFIG_AHCI_PCI=y
>> +CONFIG_SPL_CLK=y
>> +CONFIG_ROCKCHIP_GPIO=y
>> +CONFIG_SYS_I2C_ROCKCHIP=y
>> +CONFIG_LED=y
>> +CONFIG_LED_GPIO=y
>> +CONFIG_MISC=y
>> +CONFIG_SUPPORT_EMMC_RPMB=y
>> +CONFIG_MMC_DW=y
>> +CONFIG_MMC_DW_ROCKCHIP=y
>> +CONFIG_MMC_SDHCI=y
>> +CONFIG_MMC_SDHCI_SDMA=y
>> +CONFIG_MMC_SDHCI_ROCKCHIP=y
>> +CONFIG_SF_DEFAULT_BUS=4
>> +CONFIG_SPI_FLASH_SFDP_SUPPORT=y
>> +CONFIG_SPI_FLASH_GIGADEVICE=y
>> +CONFIG_SPI_FLASH_MACRONIX=y
>> +CONFIG_SPI_FLASH_WINBOND=y
>> +CONFIG_SPI_FLASH_XTX=y
>> +CONFIG_PHY_REALTEK=y
>> +CONFIG_DWC_ETH_QOS=y
>> +CONFIG_DWC_ETH_QOS_ROCKCHIP=y
>> +CONFIG_NVME_PCI=y
>> +CONFIG_PCIE_DW_ROCKCHIP=y
>> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
>> +CONFIG_SPL_PINCTRL=y
>> +CONFIG_DM_PMIC=y
>> +CONFIG_PMIC_RK8XX=y
>> +CONFIG_REGULATOR_RK8XX=y
>> +CONFIG_SPL_RAM=y
>> +CONFIG_SCSI=y
>> +CONFIG_BAUDRATE=1500000
>> +CONFIG_DEBUG_UART_SHIFT=2
>> +CONFIG_SYS_NS16550_MEM32=y
>> +CONFIG_ROCKCHIP_SFC=y
>> +CONFIG_SYSRESET=y
>> +CONFIG_USB=y
>> +CONFIG_USB_XHCI_HCD=y
>> +CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_EHCI_GENERIC=y
>> +CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_OHCI_GENERIC=y
>> +CONFIG_USB_DWC3=y
>> +CONFIG_USB_DWC3_GENERIC=y
>> +CONFIG_ERRNO_STR=y
>> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
>> index bedc52e03e2..69976ab2463 100644
>> --- a/doc/board/rockchip/rockchip.rst
>> +++ b/doc/board/rockchip/rockchip.rst
>> @@ -105,6 +105,7 @@ List of mainline supported Rockchip boards:
>>       - Pine64 SOQuartz on Model A (soquartz-model-a-rk3566)
>>       - Powkiddy X55 (powkiddy-x55-rk3566)
>>       - Radxa CM3 IO Board (radxa-cm3-io-rk3566)
>> +     - Radxa ROCK 3 Model C (rock-3c-rk3566)
> Please use the marketing name, same as in the device tree:

This was the name used for Model A.
I believe it is correct to name in the same way.

>   Radxa ROCK 3C
>
> With those fixed:
>
> Reviewed-by: Jonas Karlman <jonas@kwiboo.se>
>
> Regards,
> Jonas
>
>>  
>>  * rk3568
>>       - Rockchip Evb-RK3568 (evb-rk3568)