U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: Stefan Agner <stefan@agner.ch>, u-boot@lists.denx.de
Subject: Re: [PATCH v3 0/3] board: rockchip: Add Hardkernel ODROID-M1
Date: Wed, 26 Jul 2023 09:47:12 +0800	[thread overview]
Message-ID: <3b6efea7-e288-a3af-5bd6-18d01caa4823@rock-chips.com> (raw)
In-Reply-To: <20230722140209.1897117-1-jonas@kwiboo.se>

Hi Jonas,

     Could you split this patchset into two patch set?

     I can take the patch 3, but the patch 1~2 is suppose to go to other 
maintainer's tree, unless those patches got ACK from maintainer.


Thanks,

  - Kever

On 2023/7/22 22:02, Jonas Karlman wrote:
> This series add support for Hardkernel ODROID-M1, a single board
> computer with a RK3568B2 SoC.
>
> First patch fixes a build issue in the dwc_ahci driver.
>
> Second patch fixes a build warning in the ini command.
>
> Third patch import the device tree from linux v6.4 and add a defconfig
> for Hardkernel ODROID-M1.
>
> Following was tested on a ODROID-M1 8GB v1.0 2022-06-13:
> - SD-card boot
> - eMMC boot
> - SPI Flash boot
> - PCIe/NVMe/AHCI
> - SATA port
> - USB host
>
> Changes in v3:
> - Remove vcc5v0_usb_host regulator-always-on workaround
> - Remove CONFIG_ETH_DESIGNWARE=y and CONFIG_GMAC_ROCKCHIP=y
>
> Changes in v2:
> - Add new patch to fix build warning in the ini command
> - Enable CMD_MTD, CMD_INI and CMD_CRAMFS to closer
>    match downstream legacy U-Boot
> - Do not override spi0 alias, use SF_DEFAULT_BUS=4
> - Collect r-b and t-b tags
>
> With the new options added in v2 it is possible to load downstream
> petitboot from SD-card using following commands:
>
>    load mmc 1:1 $fdt_addr_r rk3568-odroid-m1.dtb
>    load mmc 1:1 $cramfsaddr ODROIDBIOS.BIN
>    cramfsload $scriptaddr boot.scr
>    source $scriptaddr
>
> This series have loose dependencies on the following series:
> - rockchip: Fix PCIe and NVMe support on RK3568 [1]
> - rockchip: rk3568: Use dwc3-generic driver [2]
> - rockchip: rk3568: Fix alloc space exhausted in SPL [3]
> - rockchip: rk3568: Device Tree updates [4]
> - rockchip: rk35xx: Fix SPI Flash alias [5]
>
> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=365195
> [2] https://patchwork.ozlabs.org/project/uboot/list/?series=364127
> [3] https://patchwork.ozlabs.org/project/uboot/list/?series=361999
> [4] https://patchwork.ozlabs.org/project/uboot/list/?series=362030
> [5] https://patchwork.ozlabs.org/project/uboot/list/?series=363527
>
> Jonas Karlman (3):
>    ata: dwc_ahci: Fix support for other platforms
>    cmd: ini: Fix build warning
>    board: rockchip: Add Hardkernel ODROID-M1
>
>   arch/arm/dts/Makefile                     |   1 +
>   arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi |  37 ++
>   arch/arm/dts/rk3568-odroid-m1.dts         | 744 ++++++++++++++++++++++
>   arch/arm/mach-rockchip/rk3568/Kconfig     |   6 +
>   board/hardkernel/odroid_m1/Kconfig        |  15 +
>   board/hardkernel/odroid_m1/MAINTAINERS    |   8 +
>   board/hardkernel/odroid_m1/Makefile       |   3 +
>   board/hardkernel/odroid_m1/odroid_m1.c    |   1 +
>   cmd/ini.c                                 |   2 +-
>   configs/odroid-m1-rk3568_defconfig        | 111 ++++
>   doc/board/rockchip/rockchip.rst           |   1 +
>   drivers/ata/dwc_ahci.c                    |   4 +
>   include/configs/odroid_m1.h               |  11 +
>   13 files changed, 943 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi
>   create mode 100644 arch/arm/dts/rk3568-odroid-m1.dts
>   create mode 100644 board/hardkernel/odroid_m1/Kconfig
>   create mode 100644 board/hardkernel/odroid_m1/MAINTAINERS
>   create mode 100644 board/hardkernel/odroid_m1/Makefile
>   create mode 100644 board/hardkernel/odroid_m1/odroid_m1.c
>   create mode 100644 configs/odroid-m1-rk3568_defconfig
>   create mode 100644 include/configs/odroid_m1.h
>

  parent reply	other threads:[~2023-07-26  1:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22 14:02 [PATCH v3 0/3] board: rockchip: Add Hardkernel ODROID-M1 Jonas Karlman
2023-07-22 14:02 ` [PATCH v3 1/3] ata: dwc_ahci: Fix support for other platforms Jonas Karlman
2023-07-22 14:02 ` [PATCH v3 2/3] cmd: ini: Fix build warning Jonas Karlman
2023-07-28  9:47   ` Kever Yang
2023-07-22 14:02 ` [PATCH v3 3/3] board: rockchip: Add Hardkernel ODROID-M1 Jonas Karlman
2023-07-26  1:44   ` Kever Yang
2023-07-26  1:47 ` Kever Yang [this message]
2023-07-26  6:34   ` [PATCH v3 0/3] " Jonas Karlman
2023-07-26 13:37     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b6efea7-e288-a3af-5bd6-18d01caa4823@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=jonas@kwiboo.se \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=stefan@agner.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox