U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: dts: k3-am65-iot2050: Fix boot
@ 2023-10-05  4:37 Jan Kiszka
  2023-10-05  7:52 ` Roger Quadros
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jan Kiszka @ 2023-10-05  4:37 UTC (permalink / raw)
  To: Tom Rini, u-boot
  Cc: vigneshr, m-chawdhry, sjg, jonas, afd, bb, praneeth,
	Roger Quadros, Robert Nelson, Nishanth Menon,
	Su, Bao Cheng (RC-CN DF FA R&D)

From: Jan Kiszka <jan.kiszka@siemens.com>

Since commit [1] A53 u-boot proper is broken. This is because nodes
marked as 'bootph-pre-ram' are not available at u-boot proper before
relocation.

To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.

[1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 .../dts/k3-am65-iot2050-common-u-boot.dtsi    | 44 +++++++++----------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi b/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
index 9fd64809a63..30fc7a78d89 100644
--- a/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
+++ b/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
@@ -37,18 +37,18 @@
 	};
 
 	leds {
-		bootph-pre-ram;
+		bootph-all;
 		status-led-red {
-			bootph-pre-ram;
+			bootph-all;
 		};
 		status-led-green {
-			bootph-pre-ram;
+			bootph-all;
 		};
 	};
 };
 
 &cbass_mcu {
-	bootph-pre-ram;
+	bootph-all;
 
 	mcu_navss: bus@28380000 {
 		ringacc@2b800000 {
@@ -75,70 +75,70 @@
 };
 
 &cbass_wakeup {
-	bootph-pre-ram;
+	bootph-all;
 };
 
 &cbass_main {
-	bootph-pre-ram;
+	bootph-all;
 	main_navss: bus@30800000 {
-		bootph-pre-ram;
+		bootph-all;
 	};
 };
 
 &wkup_pmx0 {
-	bootph-pre-ram;
+	bootph-all;
 	mcu-fss0-ospi0-pins-default {
-		bootph-pre-ram;
+		bootph-all;
 	};
 };
 
 &main_pmx0 {
-	bootph-pre-ram;
+	bootph-all;
 	main-uart1-pins-default {
-		bootph-pre-ram;
+		bootph-all;
 	};
 };
 
 &main_uart1 {
-	bootph-pre-ram;
+	bootph-all;
 	current-speed = <115200>;
 };
 
 &wkup_gpio0 {
-	bootph-pre-ram;
+	bootph-all;
 };
 
 &ospi0 {
-	bootph-pre-ram;
+	bootph-all;
 	flash@0 {
-		bootph-pre-ram;
+		bootph-all;
 	};
 };
 
 &secure_proxy_main {
-	bootph-pre-ram;
+	bootph-all;
 };
 
 &dmsc {
-	bootph-pre-ram;
+	bootph-all;
 	k3_sysreset: sysreset-controller {
 		compatible = "ti,sci-sysreset";
-		bootph-pre-ram;
+		bootph-all;
 	};
 };
 
 &k3_pds {
-	bootph-pre-ram;
+	bootph-all;
 };
 
 &k3_clks {
-	bootph-pre-ram;
+	bootph-all;
 };
 
 &k3_reset {
-	bootph-pre-ram;
+	bootph-all;
 };
 
 &fss {
-	bootph-pre-ram;
+	bootph-all;
 };
-- 
2.35.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: dts: k3-am65-iot2050: Fix boot
  2023-10-05  4:37 [PATCH] arm: dts: k3-am65-iot2050: Fix boot Jan Kiszka
@ 2023-10-05  7:52 ` Roger Quadros
  2023-10-05 11:20 ` Nishanth Menon
  2023-10-11 18:36 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2023-10-05  7:52 UTC (permalink / raw)
  To: Jan Kiszka, Tom Rini, u-boot
  Cc: vigneshr, m-chawdhry, sjg, jonas, afd, bb, praneeth,
	Robert Nelson, Nishanth Menon,
	Su, Bao Cheng (RC-CN DF FA R&D)



On 05/10/2023 07:37, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
> 
> To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.
> 
> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: dts: k3-am65-iot2050: Fix boot
  2023-10-05  4:37 [PATCH] arm: dts: k3-am65-iot2050: Fix boot Jan Kiszka
  2023-10-05  7:52 ` Roger Quadros
@ 2023-10-05 11:20 ` Nishanth Menon
  2023-10-11 18:36 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Nishanth Menon @ 2023-10-05 11:20 UTC (permalink / raw)
  To: Jan Kiszka
  Cc: Tom Rini, u-boot, vigneshr, m-chawdhry, sjg, jonas, afd, bb,
	praneeth, Roger Quadros, Robert Nelson,
	Su, Bao Cheng (RC-CN DF FA R&D)

On 06:37-20231005, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
> 
> To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.
> 
> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Reviewed-by: Nishanth Menon <nm@ti.com>

> ---
>  .../dts/k3-am65-iot2050-common-u-boot.dtsi    | 44 +++++++++----------
>  1 file changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi b/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
> index 9fd64809a63..30fc7a78d89 100644
> --- a/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am65-iot2050-common-u-boot.dtsi
> @@ -37,18 +37,18 @@
>  	};
>  
>  	leds {
> -		bootph-pre-ram;
> +		bootph-all;
>  		status-led-red {
> -			bootph-pre-ram;
> +			bootph-all;
>  		};
>  		status-led-green {
> -			bootph-pre-ram;
> +			bootph-all;
>  		};
>  	};
>  };
>  
>  &cbass_mcu {
> -	bootph-pre-ram;
> +	bootph-all;
>  
>  	mcu_navss: bus@28380000 {
>  		ringacc@2b800000 {
> @@ -75,70 +75,70 @@
>  };
>  
>  &cbass_wakeup {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &cbass_main {
> -	bootph-pre-ram;
> +	bootph-all;
>  	main_navss: bus@30800000 {
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &wkup_pmx0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  	mcu-fss0-ospi0-pins-default {
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &main_pmx0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  	main-uart1-pins-default {
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &main_uart1 {
> -	bootph-pre-ram;
> +	bootph-all;
>  	current-speed = <115200>;
>  };
>  
>  &wkup_gpio0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &ospi0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  	flash@0 {
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &secure_proxy_main {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &dmsc {
> -	bootph-pre-ram;
> +	bootph-all;
>  	k3_sysreset: sysreset-controller {
>  		compatible = "ti,sci-sysreset";
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &k3_pds {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &k3_clks {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &k3_reset {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &fss {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
> -- 
> 2.35.3

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: dts: k3-am65-iot2050: Fix boot
  2023-10-05  4:37 [PATCH] arm: dts: k3-am65-iot2050: Fix boot Jan Kiszka
  2023-10-05  7:52 ` Roger Quadros
  2023-10-05 11:20 ` Nishanth Menon
@ 2023-10-11 18:36 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-10-11 18:36 UTC (permalink / raw)
  To: Jan Kiszka
  Cc: u-boot, vigneshr, m-chawdhry, sjg, jonas, afd, bb, praneeth,
	Roger Quadros, Robert Nelson, Nishanth Menon,
	Su, Bao Cheng (RC-CN DF FA R&D)

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

On Thu, Oct 05, 2023 at 06:37:17AM +0200, Jan Kiszka wrote:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
> 
> To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.
> 
> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: Nishanth Menon <nm@ti.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-11 18:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-05  4:37 [PATCH] arm: dts: k3-am65-iot2050: Fix boot Jan Kiszka
2023-10-05  7:52 ` Roger Quadros
2023-10-05 11:20 ` Nishanth Menon
2023-10-11 18:36 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox