From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [PATCH 7/8] board: sl28: add ATF support (bl31)
Date: Wed, 18 Nov 2020 15:15:21 +0100 [thread overview]
Message-ID: <4113f298-378f-ee37-cd9c-ada9711635d8@xilinx.com> (raw)
In-Reply-To: <f41f66e7c937514527bf3c291238e817@walle.cc>
On 18. 11. 20 15:10, Michael Walle wrote:
> Am 2020-11-18 15:06, schrieb Michal Simek:
>> On 16. 11. 20 22:47, Michael Walle wrote:
>>> Add support to load the bl31 part of the ARM Trusted Firmware by the
>>> SPL.
>>>
>>> Signed-off-by: Michael Walle <michael@walle.cc>
>>> ---
>>> ?.../dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi? | 41 +++++++++++++-
>>> ?board/kontron/sl28/Kconfig??????????????????? | 10 ++++
>>> ?board/kontron/sl28/Makefile?????????????????? |? 6 ++-
>>> ?board/kontron/sl28/spl_atf.c????????????????? | 54 +++++++++++++++++++
>>> ?4 files changed, 109 insertions(+), 2 deletions(-)
>>> ?create mode 100644 board/kontron/sl28/spl_atf.c
>>>
>>> diff --git a/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
>>> b/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
>>> index 2375549c6e..4b97e9d388 100644
>>> --- a/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
>>> +++ b/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi
>>> @@ -16,7 +16,7 @@
>>> ???????? ethernet3 = &enetc6;
>>> ???? };
>>>
>>> -??? binman {
>>> +??? binman: binman {
>>> ???????? filename = "u-boot.rom";
>>> ???????? pad-byte = <0xff>;
>>>
>>> @@ -102,6 +102,45 @@
>>> ???? };
>>> ?};
>>>
>>> +#ifdef CONFIG_SL28_SPL_LOADS_ATF_BL31
>>> +&binman {
>>> +??? fit {
>>> +??????? images {
>>> +??????????? bl31 {
>>> +??????????????? description = "ARM Trusted Firmware (bl31)";
>>> +??????????????? type = "firmware";
>>> +??????????????? arch = "arm";
>>> +??????????????? os = "arm-trusted-firmware";
>>> +??????????????? compression = "none";
>>> +??????????????? load = <CONFIG_SL28_BL31_ENTRY_ADDR>;
>>> +??????????????? entry = <CONFIG_SL28_BL31_ENTRY_ADDR>;
>>> +
>>> +??????????????? blob-ext {
>>> +??????????????????? filename = "bl31.bin";
>>> +??????????????? };
>>> +??????????? };
>>> +??????? };
>>> +
>>> +??????? configurations {
>>> +??????????? conf-1 {
>>> +??????????????? firmware = "bl31";
>>> +??????????????? loadables = "uboot", "bl31";
>>> +??????????? };
>>> +
>>> +??????????? conf-2 {
>>> +??????????????? firmware = "bl31";
>>> +??????????????? loadables = "uboot", "bl31";
>>> +??????????? };
>>> +
>>> +??????????? conf-3 {
>>> +??????????????? firmware = "bl31";
>>> +??????????????? loadables = "uboot", "bl31";
>>> +??????????? };
>>
>> Why do you need 3 the same configurations here?
>
> Because they differ in the fdt, but I still need to change the loadable
> property if BL31/BL32 is enabled. See:
>
> https://elixir.bootlin.com/u-boot/v2021.01-rc2/source/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi#L77
ah. ok. It is another overlay. But still you have firmware bl31 and
loadables bl31 too. It means you are loading bl31 twice.
This should just work.
firmware = "bl31";
loadables = "uboot";
At least I use this on zynqmp.
M
next prev parent reply other threads:[~2020-11-18 14:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 21:47 [PATCH 0/8] spl: atf: add support for LOAD_IMAGE_V2 Michael Walle
2020-11-16 21:47 ` [PATCH 1/8] treewide: use CONFIG_IS_ENABLED() for ARMV8_SEC_FIRMWARE_SUPPORT Michael Walle
2020-11-18 14:21 ` Michal Simek
2020-11-16 21:47 ` [PATCH 2/8] spl: atf: move storage for bl31_params into function Michael Walle
2020-11-18 14:07 ` Michal Simek
2020-11-16 21:47 ` [PATCH 3/8] spl: atf: provide a bl2_plat_get_bl31_params_default() Michael Walle
2020-11-18 14:23 ` Michal Simek
2020-11-18 14:24 ` Michal Simek
2020-11-16 21:47 ` [PATCH 4/8] spl: atf: remove helper structure from common header Michael Walle
2020-11-18 14:25 ` Michal Simek
2020-11-16 21:47 ` [PATCH 5/8] spl: atf: add support for LOAD_IMAGE_V2 Michael Walle
2020-11-18 14:26 ` Michal Simek
2020-11-16 21:47 ` [PATCH 6/8] armv8: layerscape: don't initialize GIC in SPL Michael Walle
2020-11-16 21:47 ` [PATCH 7/8] board: sl28: add ATF support (bl31) Michael Walle
2020-11-18 14:06 ` Michal Simek
2020-11-18 14:10 ` Michael Walle
2020-11-18 14:15 ` Michal Simek [this message]
2020-11-18 14:20 ` Michael Walle
2020-11-18 16:11 ` Michael Walle
2020-11-16 21:47 ` [PATCH 8/8] board: sl28: add OP-TEE Trusted OS support (bl32) Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4113f298-378f-ee37-cd9c-ada9711635d8@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox