From: Kever Yang <kever.yang@rock-chips.com>
To: Quentin Schulz <foss+uboot@0leil.net>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Tom Rini <trini@konsulko.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jonas Karlman <jonas@kwiboo.se>, Jagan Teki <jagan@edgeble.ai>,
u-boot@lists.denx.de, Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH 05/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3066
Date: Tue, 8 Apr 2025 10:27:15 +0800 [thread overview]
Message-ID: <441c1271-6c3f-4ece-82f5-d3ea0ebdf108@rock-chips.com> (raw)
In-Reply-To: <20250129-rockchip-pinctrl-const-v1-5-450ccdadfa7e@cherry.de>
On 2025/1/29 20:42, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> There's no need to modify private data from the controller, so let's
> make that struct const.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> drivers/pinctrl/rockchip/pinctrl-rk3066.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3066.c b/drivers/pinctrl/rockchip/pinctrl-rk3066.c
> index 60e088a9a6f0d9133cd0822a9f4816cea18a524d..f773f2a3dab86dc866965cdcfd9b56da9e777acc 100644
> --- a/drivers/pinctrl/rockchip/pinctrl-rk3066.c
> +++ b/drivers/pinctrl/rockchip/pinctrl-rk3066.c
> @@ -82,7 +82,7 @@ static struct rockchip_pin_bank rk3066_pin_banks[] = {
> PIN_BANK(6, 16, "gpio6"),
> };
>
> -static struct rockchip_pin_ctrl rk3066_pin_ctrl = {
> +static const struct rockchip_pin_ctrl rk3066_pin_ctrl = {
> .pin_banks = rk3066_pin_banks,
> .nr_banks = ARRAY_SIZE(rk3066_pin_banks),
> .grf_mux_offset = 0xa8,
>
next prev parent reply other threads:[~2025-04-08 2:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 12:42 [PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl Quentin Schulz
2025-01-29 12:42 ` [PATCH 01/14] pinctrl: rockchip: remove unused base_pin bank member Quentin Schulz
2025-04-08 2:26 ` Kever Yang
2025-01-29 12:42 ` [PATCH 02/14] pinctrl: rockchip: remove unused nr_pins controller member Quentin Schulz
2025-04-08 2:26 ` Kever Yang
2025-01-29 12:42 ` [PATCH 03/14] pinctrl: rockchip: constify rockchip_pin_ctrl for PX30 Quentin Schulz
2025-04-08 2:27 ` Kever Yang
2025-01-29 12:42 ` [PATCH 04/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3036 Quentin Schulz
2025-04-08 2:27 ` Kever Yang
2025-01-29 12:42 ` [PATCH 05/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3066 Quentin Schulz
2025-04-08 2:27 ` Kever Yang [this message]
2025-01-29 12:42 ` [PATCH 06/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3128 Quentin Schulz
2025-04-08 2:27 ` Kever Yang
2025-01-29 12:42 ` [PATCH 07/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3188 Quentin Schulz
2025-04-08 2:27 ` Kever Yang
2025-01-29 12:42 ` [PATCH 08/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3228 Quentin Schulz
2025-04-08 2:27 ` Kever Yang
2025-01-29 12:42 ` [PATCH 09/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3288 Quentin Schulz
2025-04-08 2:27 ` Kever Yang
2025-01-29 12:42 ` [PATCH 10/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3308 Quentin Schulz
2025-04-08 3:16 ` Kever Yang
2025-01-29 12:42 ` [PATCH 11/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3328 Quentin Schulz
2025-04-08 3:17 ` Kever Yang
2025-01-29 12:42 ` [PATCH 12/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3368 Quentin Schulz
2025-04-08 3:17 ` Kever Yang
2025-01-29 12:42 ` [PATCH 13/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RK3399 Quentin Schulz
2025-04-08 3:17 ` Kever Yang
2025-01-29 12:42 ` [PATCH 14/14] pinctrl: rockchip: constify rockchip_pin_ctrl for RV1108 Quentin Schulz
2025-04-08 3:17 ` Kever Yang
2025-01-29 14:20 ` [PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl Jonas Karlman
2025-01-30 14:16 ` Quentin Schulz
2025-01-30 21:20 ` Jonas Karlman
2025-01-31 13:54 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441c1271-6c3f-4ece-82f5-d3ea0ebdf108@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=foss+uboot@0leil.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=philipp.tomsich@vrull.eu \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox