public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH 3/3] dts: sunxi: add PWM node for sun50i
Date: Tue, 19 Sep 2017 10:05:31 +0100	[thread overview]
Message-ID: <464f41c6-99ca-afb4-22e6-1fdca29d6493@arm.com> (raw)
In-Reply-To: <20170919050641.23305-3-anarsoul@gmail.com>

Hi,

On 19/09/17 06:06, Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm/dts/sun50i-a64.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/dts/sun50i-a64.dtsi b/arch/arm/dts/sun50i-a64.dtsi
> index 65a344d9ce..14e94bf00e 100644
> --- a/arch/arm/dts/sun50i-a64.dtsi
> +++ b/arch/arm/dts/sun50i-a64.dtsi
> @@ -319,6 +319,14 @@
>  			};
>  		};
>  
> +		pwm: pwm at 01c21400 {
> +			compatible = "allwinner,sun50i-a64-pwm";

So the A64 PWM seems to be fully compatible with the H3 one, which has a
documented binding (also used in the Linux driver).
So can you please make this:
		compatible = "allwinner,sun50i-a64-pwm",
			     "allwinner,sun8i-h3-pwm";

and then drop the sun50i-a64-pwm string in the driver?

And I wonder if we should have the pinctrl already in here, since there
is only one choice for PWM0? At least that would document the clash.

> +			reg = <0x01c21400 0x8>;
> +			clocks = <&osc24M>;
> +			#pwm-cells = <3>;
> +			status = "disabled";
> +		};
> +
>  		uart0: serial at 1c28000 {
>  			compatible = "snps,dw-apb-uart";
>  			reg = <0x01c28000 0x400>;
> 

  parent reply	other threads:[~2017-09-19  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19  5:06 [U-Boot] [RESEND PATCH 1/3] pwm: sunxi: add support for PWM found on Allwinner A64 and H3 Vasily Khoruzhick
2017-09-19  5:06 ` [U-Boot] [RESEND PATCH 2/3] video: pwm_backlight: make regulator optional Vasily Khoruzhick
2017-09-19  5:06 ` [U-Boot] [RESEND PATCH 3/3] dts: sunxi: add PWM node for sun50i Vasily Khoruzhick
2017-09-19  8:42   ` Maxime Ripard
2017-09-19  9:05   ` Andre Przywara [this message]
2017-09-19  8:51 ` [U-Boot] [RESEND PATCH 1/3] pwm: sunxi: add support for PWM found on Allwinner A64 and H3 Andre Przywara
2017-09-19  8:53   ` Icenowy Zheng
2017-09-19  9:31     ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464f41c6-99ca-afb4-22e6-1fdca29d6493@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox