From: Sean Anderson <seanga2@gmail.com>
To: Adam Ford <aford173@gmail.com>, u-boot@lists.denx.de
Cc: lukma@denx.de, sean.anderson@seco.com, luca@lucaceresoli.net,
charles.stevens@logicpd.com, aford@beaconembedded.com
Subject: Re: [PATCH V4] clk: clk_versaclock: Add support for versaclock driver
Date: Wed, 1 Dec 2021 14:11:15 -0500 [thread overview]
Message-ID: <4760ab9d-d963-19e5-8472-1bd977d011cd@gmail.com> (raw)
In-Reply-To: <20210604172606.52453-1-aford173@gmail.com>
Hi Adam,
On 6/4/21 1:26 PM, Adam Ford wrote:
> +/*
> + * The device references to the Versaclock point to the head, so xlate needs to
> + * redirect it to clk_out[idx]
> + */
> +static int vc5_clk_out_xlate(struct clk *hw, struct ofnode_phandle_args *args)
> +{
> + unsigned int idx = args->args[0];
> +
> + if (args->args_count != 1) {
> + debug("Invaild args_count: %d\n", args->args_count);
> + return -EINVAL;
> + }
> +
> + hw->id = idx;
> +
> + return 0;
> +}
Can you explain a bit more why this is needed? I looked it over a few
times, and I'm not sure what it does differently from
clk_of_xlate_default.
--Sean
next prev parent reply other threads:[~2021-12-01 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 17:26 [PATCH V4] clk: clk_versaclock: Add support for versaclock driver Adam Ford
2021-06-04 17:27 ` Sean Anderson
2021-06-30 12:32 ` Adam Ford
2021-08-20 18:27 ` Adam Ford
2021-08-20 18:48 ` Sean Anderson
2021-08-22 20:54 ` Tom Rini
2021-12-01 19:11 ` Sean Anderson [this message]
2021-12-01 19:25 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4760ab9d-d963-19e5-8472-1bd977d011cd@gmail.com \
--to=seanga2@gmail.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=charles.stevens@logicpd.com \
--cc=luca@lucaceresoli.net \
--cc=lukma@denx.de \
--cc=sean.anderson@seco.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox