* [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite()
@ 2025-09-06 23:00 Marek Vasut
2025-09-08 7:02 ` Patrice CHOTARD
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2025-09-06 23:00 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Gabriel Fernandez, Patrice Chotard, Patrick Delaunay,
Sean Anderson, Tom Rini, uboot-stm32
The clk_register_composite() does clk_resolve_parent_clk() look up,
which requires valid udevice pointer. Do not pass NULL, pass a valid
device pointer to prevent hang on registering ck_usbo_48m clock on
STM32MP13xx.
Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
---
Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Cc: uboot-stm32@st-md-mailman.stormreply.com
---
drivers/clk/stm32/clk-stm32-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm32-core.c
index a0ae89d0912..858f122db1a 100644
--- a/drivers/clk/stm32/clk-stm32-core.c
+++ b/drivers/clk/stm32/clk-stm32-core.c
@@ -309,7 +309,7 @@ clk_stm32_register_composite(struct udevice *dev,
gate_ops = &clk_stm32_gate_ops;
}
- clk = clk_register_composite(NULL, cfg->name,
+ clk = clk_register_composite(dev, cfg->name,
parent_names, num_parents,
mux_clk, mux_ops,
div_clk, div_ops,
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite()
2025-09-06 23:00 [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite() Marek Vasut
@ 2025-09-08 7:02 ` Patrice CHOTARD
2025-09-17 7:26 ` Patrice CHOTARD
0 siblings, 1 reply; 3+ messages in thread
From: Patrice CHOTARD @ 2025-09-08 7:02 UTC (permalink / raw)
To: Marek Vasut, u-boot
Cc: Gabriel Fernandez, Patrick Delaunay, Sean Anderson, Tom Rini,
uboot-stm32
On 9/7/25 01:00, Marek Vasut wrote:
> The clk_register_composite() does clk_resolve_parent_clk() look up,
> which requires valid udevice pointer. Do not pass NULL, pass a valid
> device pointer to prevent hang on registering ck_usbo_48m clock on
> STM32MP13xx.
>
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Sean Anderson <seanga2@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@lists.denx.de
> Cc: uboot-stm32@st-md-mailman.stormreply.com
> ---
> drivers/clk/stm32/clk-stm32-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm32-core.c
> index a0ae89d0912..858f122db1a 100644
> --- a/drivers/clk/stm32/clk-stm32-core.c
> +++ b/drivers/clk/stm32/clk-stm32-core.c
> @@ -309,7 +309,7 @@ clk_stm32_register_composite(struct udevice *dev,
> gate_ops = &clk_stm32_gate_ops;
> }
>
> - clk = clk_register_composite(NULL, cfg->name,
> + clk = clk_register_composite(dev, cfg->name,
> parent_names, num_parents,
> mux_clk, mux_ops,
> div_clk, div_ops,
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite()
2025-09-08 7:02 ` Patrice CHOTARD
@ 2025-09-17 7:26 ` Patrice CHOTARD
0 siblings, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2025-09-17 7:26 UTC (permalink / raw)
To: Marek Vasut, u-boot
Cc: Gabriel Fernandez, Patrick Delaunay, Sean Anderson, Tom Rini,
uboot-stm32
On 9/8/25 09:02, Patrice CHOTARD wrote:
>
>
> On 9/7/25 01:00, Marek Vasut wrote:
>> The clk_register_composite() does clk_resolve_parent_clk() look up,
>> which requires valid udevice pointer. Do not pass NULL, pass a valid
>> device pointer to prevent hang on registering ck_usbo_48m clock on
>> STM32MP13xx.
>>
>> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
>> ---
>> Cc: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Cc: Sean Anderson <seanga2@gmail.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: u-boot@lists.denx.de
>> Cc: uboot-stm32@st-md-mailman.stormreply.com
>> ---
>> drivers/clk/stm32/clk-stm32-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm32-core.c
>> index a0ae89d0912..858f122db1a 100644
>> --- a/drivers/clk/stm32/clk-stm32-core.c
>> +++ b/drivers/clk/stm32/clk-stm32-core.c
>> @@ -309,7 +309,7 @@ clk_stm32_register_composite(struct udevice *dev,
>> gate_ops = &clk_stm32_gate_ops;
>> }
>>
>> - clk = clk_register_composite(NULL, cfg->name,
>> + clk = clk_register_composite(dev, cfg->name,
>> parent_names, num_parents,
>> mux_clk, mux_ops,
>> div_clk, div_ops,
>
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Thanks
> Patrice
Applied to u-boot-stm32/master
Thanks
Patrice
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-17 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-06 23:00 [PATCH] clk: stm32: Pass udevice pointer to clk_register_composite() Marek Vasut
2025-09-08 7:02 ` Patrice CHOTARD
2025-09-17 7:26 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox