From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case
Date: Sat, 06 Feb 2010 10:35:09 -0600 [thread overview]
Message-ID: <4B6D9A3D.5090509@windriver.com> (raw)
In-Reply-To: <4B6D9234.9060602@fearnside-systems.co.uk>
kevin.morfitt at fearnside-systems.co.uk wrote:
>
>
> On 06/02/2010 15:14, Tom wrote:
>> kevin.morfitt at fearnside-systems.co.uk wrote:
>>> Hi Wolfgang
>>>
>>> On 06/02/2010 14:26, Wolfgang Denk wrote:
>>>> Dear "kevin.morfitt at fearnside-systems.co.uk",
>>>>
>>>> In message<4B6D687F.2060606@fearnside-systems.co.uk> you wrote:
>>>>> The patches are split so that each patch makes only one type of
>>>>> change,
>>>>> so there's only one thing that needs to be checked in each patch.
>>>>>
>>>>> - patches 1 and 2 only make white-space changes (the change was too
>>>>> big
>>>>> so I had to split it into 2 patches)
>>>> I think this should be merged into a single patch.
>>>
>>> OK. It'll be about 140K though so I'llput it on a web site.
>>>
>> IMO So it could be posted to the mailing list, it would be better to
>> split.
>>
>> Was the whitespace changes done by hand or automatically with something
>> like indent as mentioned http://www.denx.de/wiki/U-Boot/CodingStyle?
>
> It was done automatically using Lindent but I had to do some manual
> tidying up because Lindent doesn't always get things right.
Maybe a good way to spit the patch is
1. Lindent
2. Manual
So reviewer could spend more attention on the much smaller #2.
Would this be easy to do?
Tom
>
> Kevin
>
>>
>> Tom
>>
next prev parent reply other threads:[~2010-02-06 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 22:53 [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case kevin.morfitt at fearnside-systems.co.uk
2010-02-06 12:18 ` Minkyu Kang
2010-02-06 13:02 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 14:26 ` Wolfgang Denk
2010-02-06 14:48 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 15:14 ` Tom
2010-02-06 16:00 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 16:35 ` Tom [this message]
2010-02-06 16:54 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 18:17 ` Tom
2010-02-06 18:33 ` Wolfgang Denk
2010-02-06 18:28 ` Wolfgang Denk
2010-02-06 14:24 ` Wolfgang Denk
2010-02-07 13:38 ` Minkyu Kang
2010-02-07 14:10 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-07 16:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6D9A3D.5090509@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox