From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case
Date: Sat, 06 Feb 2010 15:26:26 +0100 [thread overview]
Message-ID: <20100206142626.310A724F09@gemini.denx.de> (raw)
In-Reply-To: <4B6D687F.2060606@fearnside-systems.co.uk>
Dear "kevin.morfitt at fearnside-systems.co.uk",
In message <4B6D687F.2060606@fearnside-systems.co.uk> you wrote:
>
> The patches are split so that each patch makes only one type of change,
> so there's only one thing that needs to be checked in each patch.
>
> - patches 1 and 2 only make white-space changes (the change was too big
> so I had to split it into 2 patches)
I think this should be merged into a single patch.
> - patch 3 only makes code style changes such as moving external
> function prototypes to header files, removing unused code, making line
> lengths less than 81 characters, brackets around if/then/else/when/do
> blocks, generally anything that checkpatch.pl warns about
> - patch 4 changes the s3c24x0 register struct members to lower case
> (which is the main aim of the patches)
>
> I can modify the patches to do all changes at the same time but when
> I've done this before I've always been told that each patch should have
> only one type of change in it, and I'm not sure if it would get NACK'ed
> by someone else.
Correct. Please keep the split as is.
> What do you think - do you still want me to change the patch series?
No, please leave as is.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We have the right to survive!"
"Not be killing others."
-- Deela and Kirk, "Wink of An Eye", stardate 5710.5
next prev parent reply other threads:[~2010-02-06 14:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 22:53 [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case kevin.morfitt at fearnside-systems.co.uk
2010-02-06 12:18 ` Minkyu Kang
2010-02-06 13:02 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 14:26 ` Wolfgang Denk [this message]
2010-02-06 14:48 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 15:14 ` Tom
2010-02-06 16:00 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 16:35 ` Tom
2010-02-06 16:54 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-06 18:17 ` Tom
2010-02-06 18:33 ` Wolfgang Denk
2010-02-06 18:28 ` Wolfgang Denk
2010-02-06 14:24 ` Wolfgang Denk
2010-02-07 13:38 ` Minkyu Kang
2010-02-07 14:10 ` kevin.morfitt at fearnside-systems.co.uk
2010-02-07 16:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100206142626.310A724F09@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox