From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling
Date: Mon, 27 Dec 2010 14:41:47 +0300 [thread overview]
Message-ID: <4D187B7B.70806@mvista.com> (raw)
In-Reply-To: <1293425300-27644-16-git-send-email-vapier@gentoo.org>
Hello.
On 27-12-2010 7:48, Mike Frysinger wrote:
> The recent global data changes (making the size autogenerated) broke the
> board info handling on Blackfin ports as we were lying and lumping the
> bd_t size in with the gd_t size. So use the new dedicated bd_t size to
> setup its own address in memory.
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
[...]
> diff --git a/arch/blackfin/lib/board.c b/arch/blackfin/lib/board.c
> index 2b1f78c..47d487f 100644
> --- a/arch/blackfin/lib/board.c
> +++ b/arch/blackfin/lib/board.c
[...]
> @@ -244,14 +243,9 @@ void board_init_f(ulong bootflag)
> gd = (gd_t *) (CONFIG_SYS_GBL_DATA_ADDR);
> memset((void *)gd, 0, GENERATED_GBL_DATA_SIZE);
>
> - /* Board data initialization */
> - addr = (CONFIG_SYS_GBL_DATA_ADDR + sizeof(gd_t));
> -
> - /* Align to 4 byte boundary */
> - addr&= ~(4 - 1);
> - bd = (bd_t *) addr;
> + bd = (bd_t *) (CONFIG_SYS_BD_INFO_ADDR);
Parens not needed around CONFIG_SYS_BD_INFO_ADDR.
WBR, Sergei
next prev parent reply other threads:[~2010-12-27 11:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 4:47 [U-Boot] [PATCH 00/28] Blackfin updates for v2011.03 Mike Frysinger
2010-12-27 4:47 ` [U-Boot] [PATCH 01/28] MAINTAINERS: sort Blackfin entries Mike Frysinger
2011-01-10 22:21 ` Wolfgang Denk
2010-12-27 4:47 ` [U-Boot] [PATCH 02/28] Blackfin: bf518f-ezbrd: don't require SPI logic all the time Mike Frysinger
2010-12-27 4:47 ` [U-Boot] [PATCH 03/28] Blackfin: skip RAM display for 0 mem systems Mike Frysinger
2010-12-27 4:47 ` [U-Boot] [PATCH 04/28] Blackfin: drop CONFIG_SYS_TEXT_BASE from boards Mike Frysinger
2010-12-27 4:47 ` [U-Boot] [PATCH 05/28] Blackfin: unify bootmode based LDR_FLAGS setup Mike Frysinger
2010-12-27 4:47 ` [U-Boot] [PATCH 06/28] Blackfin: move CONFIG_BFIN_CPU back to board config.h Mike Frysinger
2010-12-27 4:47 ` [U-Boot] [PATCH 07/28] Blackfin: bf527-sdp: update custom CFLAGS paths Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 08/28] Blackfin: bf537-pnav/blackstamp/blackvme: drop empty config.mk files Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 09/28] Blackfin: dnp5370: new board port Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 10/28] Blackfin: bf525-ucr2: " Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 11/28] Blackfin: serial: clean up muxing a bit Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 12/28] Blackfin: bf537-minotaur/bf537-srv1: undefine nfs when net is disabled Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 13/28] Blackfin: bf537: fix L1 data defines Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 14/28] Blackfin: bf561-ezkit/ibf-dsp561: invert env offset/addr logic Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling Mike Frysinger
2010-12-27 11:41 ` Sergei Shtylyov [this message]
2010-12-27 16:42 ` Mike Frysinger
2011-01-10 22:28 ` Wolfgang Denk
2011-01-11 0:31 ` Mike Frysinger
2011-01-12 13:10 ` Sergei Shtylyov
2010-12-27 4:48 ` [U-Boot] [PATCH 17/28] Blackfin: drop duplicate system mmr and L1 scratch defines Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 20/28] Blackfin: only check for os log when we have external memory Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 21/28] Blackfin: turn off caches when self initializing Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 22/28] Blackfin: default to L1 bank A when L1 bank B does not exist Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 23/28] Blackfin: bf506f-ezkit: new board port Mike Frysinger
2011-01-10 22:33 ` Wolfgang Denk
2011-01-11 0:25 ` Mike Frysinger
2011-01-12 23:14 ` [U-Boot] [PATCH 23/28 v2] " Mike Frysinger
2011-01-12 23:10 ` Wolfgang Denk
2011-01-12 23:16 ` Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 24/28] Blackfin: adi boards: drop old ELF define Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 25/28] Blackfin: bootrom.h: sync with toolchain Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 26/28] Blackfin: bootldr: use common defines Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 27/28] Blackfin: ldrinfo: new command Mike Frysinger
2011-01-10 22:39 ` Wolfgang Denk
2011-01-11 0:40 ` [U-Boot] [PATCH 27/28 v2] " Mike Frysinger
2010-12-27 4:48 ` [U-Boot] [PATCH 28/28] Blackfin: adi boards: enable ldrinfo Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D187B7B.70806@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox