* [U-Boot] [patch] u-boot powerpc build error
@ 2011-01-12 4:47 gmane
2011-01-12 7:33 ` Wolfgang Denk
2011-01-13 0:20 ` Scott Wood
0 siblings, 2 replies; 6+ messages in thread
From: gmane @ 2011-01-12 4:47 UTC (permalink / raw)
To: u-boot
Hello,
I met this error (use GNU make 3.80).
$ make MPC885ADS_config
$ make
/home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text after
`else' directive
/home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else'
per conditional. Stop.
Regards,
namsh
diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk
index 2912604..5eeba9a 100644
--- a/arch/powerpc/config.mk
+++ b/arch/powerpc/config.mk
@@ -32,13 +32,15 @@ PLATFORM_LDFLAGS += -n --gc-sections
ifdef CONFIG_SYS_LDSCRIPT
# need to strip off double quotes
LDSCRIPT := $(subst ",,$(CONFIG_SYS_LDSCRIPT))
-else ifdef CONFIG_NAND_SPL
+else
+ifdef CONFIG_NAND_SPL
LDSCRIPT := $(SRCTREE)/$(CONFIG_BOARDDIR)/u-boot-nand.lds
else
ifneq ($(wildcard $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds),)
LDSCRIPT := $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds
endif
endif
+endif
#
# When cross-compiling on NetBSD, we have to define __PPC__ or else we
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [patch] u-boot powerpc build error
2011-01-12 4:47 [U-Boot] [patch] u-boot powerpc build error gmane
@ 2011-01-12 7:33 ` Wolfgang Denk
2011-01-13 0:16 ` SungHyun Nam
2011-01-13 0:20 ` Scott Wood
1 sibling, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2011-01-12 7:33 UTC (permalink / raw)
To: u-boot
Dear gmane,
In message <4D2D324C.3010607@gmail.com> you wrote:
> Hello,
>
> I met this error (use GNU make 3.80).
>
> $ make MPC885ADS_config
> $ make
> /home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text after
> `else' directive
> /home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else'
> per conditional. Stop.
Can you please submit this as a proper patch, i. e. with a proper
commit message and your Signed-off-by: line? Please see
http://www.denx.de/wiki/U-Boot/Patches for details.
And can you please extend the patch to fix _all_ places where such a
construct is being used, i. e. at least these:
arch/powerpc/config.mk:else ifdef CONFIG_NAND_SPL
board/amcc/bamboo/config.mk:else ifdef CONFIG_NAND_U_BOOT
board/amcc/sequoia/config.mk:else ifdef CONFIG_NAND_U_BOOT
board/amcc/acadia/config.mk:else ifdef CONFIG_NAND_U_BOOT
board/amcc/canyonlands/config.mk:else ifdef CONFIG_NAND_U_BOOT
board/amcc/kilauea/config.mk:else ifdef CONFIG_NAND_U_BOOT
And please make sure to run a "MAKEALL ppc" to verify you have found
all occurrences.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If a packet hits a pocket on a socket on a port,
And the bus is interrupted as a very last resort,
And the address of the memory makes your floppy disk abort,
Then the socket packet pocket has an error to report! - Ken Burchill?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [patch] u-boot powerpc build error
2011-01-12 7:33 ` Wolfgang Denk
@ 2011-01-13 0:16 ` SungHyun Nam
0 siblings, 0 replies; 6+ messages in thread
From: SungHyun Nam @ 2011-01-13 0:16 UTC (permalink / raw)
To: u-boot
Wolfgang Denk wrote:
>
> In message<4D2D324C.3010607@gmail.com> you wrote:
>> Hello,
>>
>> I met this error (use GNU make 3.80).
>>
>> $ make MPC885ADS_config
>> $ make
>> /home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text after
>> `else' directive
>> /home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else'
>> per conditional. Stop.
>
> Can you please submit this as a proper patch, i. e. with a proper
> commit message and your Signed-off-by: line? Please see
> http://www.denx.de/wiki/U-Boot/Patches for details.
After sending a patch, I noticed I need GNU make 3.81 and now I
use it to build U-Boot. 3.81 was released at 2006. So that,
I think modifying all the makefiles to support 3.80 or older is not
good.
Hmm, you may want to add a section like 'SOFTWARE REQUIREMENTS'.
regards,
namsh
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [patch] u-boot powerpc build error
2011-01-12 4:47 [U-Boot] [patch] u-boot powerpc build error gmane
2011-01-12 7:33 ` Wolfgang Denk
@ 2011-01-13 0:20 ` Scott Wood
2011-01-13 7:19 ` Aggrwal Poonam-B10812
1 sibling, 1 reply; 6+ messages in thread
From: Scott Wood @ 2011-01-13 0:20 UTC (permalink / raw)
To: u-boot
On Wed, 12 Jan 2011 13:47:08 +0900
gmane <goweol@gmail.com> wrote:
> Hello,
>
> I met this error (use GNU make 3.80).
"else ifdef" appears to be new in make 3.81.
> $ make MPC885ADS_config
> $ make
> /home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text after
> `else' directive
> /home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else'
> per conditional. Stop.
>
> Regards,
> namsh
>
> diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk
> index 2912604..5eeba9a 100644
> --- a/arch/powerpc/config.mk
> +++ b/arch/powerpc/config.mk
> @@ -32,13 +32,15 @@ PLATFORM_LDFLAGS += -n --gc-sections
> ifdef CONFIG_SYS_LDSCRIPT
> # need to strip off double quotes
> LDSCRIPT := $(subst ",,$(CONFIG_SYS_LDSCRIPT))
> -else ifdef CONFIG_NAND_SPL
> +else
> +ifdef CONFIG_NAND_SPL
> LDSCRIPT := $(SRCTREE)/$(CONFIG_BOARDDIR)/u-boot-nand.lds
> else
> ifneq ($(wildcard $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds),)
> LDSCRIPT := $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds
> endif
> endif
> +endif
Shouldn't CONFIG_SYS_LDSCRIPT override only the main U-boot's linker
script, not the NAND SPL? It's unlikely that the same linker
script would be used for both.
If the NAND SPL linker script needs to be overridden (probably
unlikely), it would need CONFIG_SYS_LDSCRIPT_SPL, similar to
CONFIG_SYS_TEXT_BASE_SPL.
I know this isn't your change, but this is where I noticed it. :-)
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [patch] u-boot powerpc build error
2011-01-13 0:20 ` Scott Wood
@ 2011-01-13 7:19 ` Aggrwal Poonam-B10812
2011-01-13 7:59 ` [U-Boot] U-Boot 12.2010 on Tx25 Doninelli Davide
0 siblings, 1 reply; 6+ messages in thread
From: Aggrwal Poonam-B10812 @ 2011-01-13 7:19 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of Wood Scott-B07421
> Sent: Thursday, January 13, 2011 5:51 AM
> To: gmane
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [patch] u-boot powerpc build error
>
> On Wed, 12 Jan 2011 13:47:08 +0900
> gmane <goweol@gmail.com> wrote:
>
> > Hello,
> >
> > I met this error (use GNU make 3.80).
>
> "else ifdef" appears to be new in make 3.81.
Yes I also faced this error with make 3.80
So I made temporary change in config.mk to get build successful.
>
> > $ make MPC885ADS_config
> > $ make
> > /home/namsh/work/u-boot/arch/powerpc/config.mk:35: Extraneous text
> > after `else' directive
> > /home/namsh/work/u-boot/arch/powerpc/config.mk:37: *** only one `else'
> > per conditional. Stop.
> >
> > Regards,
> > namsh
> >
> > diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk index
> > 2912604..5eeba9a 100644
> > --- a/arch/powerpc/config.mk
> > +++ b/arch/powerpc/config.mk
> > @@ -32,13 +32,15 @@ PLATFORM_LDFLAGS += -n --gc-sections
> > ifdef CONFIG_SYS_LDSCRIPT
> > # need to strip off double quotes
> > LDSCRIPT := $(subst ",,$(CONFIG_SYS_LDSCRIPT)) -else ifdef
> > CONFIG_NAND_SPL
> > +else
> > +ifdef CONFIG_NAND_SPL
> > LDSCRIPT := $(SRCTREE)/$(CONFIG_BOARDDIR)/u-boot-nand.lds
> > else
> > ifneq ($(wildcard $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds),)
> > LDSCRIPT := $(SRCTREE)/arch/powerpc/cpu/$(CPU)/u-boot.lds
> > endif
> > endif
> > +endif
>
> Shouldn't CONFIG_SYS_LDSCRIPT override only the main U-boot's linker
> script, not the NAND SPL? It's unlikely that the same linker script
> would be used for both.
>
> If the NAND SPL linker script needs to be overridden (probably unlikely),
> it would need CONFIG_SYS_LDSCRIPT_SPL, similar to
> CONFIG_SYS_TEXT_BASE_SPL.
>
> I know this isn't your change, but this is where I noticed it. :-)
>
> -Scott
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-13 7:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-12 4:47 [U-Boot] [patch] u-boot powerpc build error gmane
2011-01-12 7:33 ` Wolfgang Denk
2011-01-13 0:16 ` SungHyun Nam
2011-01-13 0:20 ` Scott Wood
2011-01-13 7:19 ` Aggrwal Poonam-B10812
2011-01-13 7:59 ` [U-Boot] U-Boot 12.2010 on Tx25 Doninelli Davide
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox