* [U-Boot] [PATCH 1/1] DaVinci: Fix DM365 & DM644X build error
@ 2011-01-20 11:27 Mohammed Afzal
2011-01-20 22:02 ` Albert ARIBAUD
0 siblings, 1 reply; 3+ messages in thread
From: Mohammed Afzal @ 2011-01-20 11:27 UTC (permalink / raw)
To: u-boot
DM365 & DM644X builds 'davinci_emac_mii_mode_sel()',
which uses 'davinci_syscfg_regs' macro, and the
macro is valid iff CONFIG_SOC_DA8XX is defined.
Fix: Before compiling 'davinci_emac_mii_mode_sel()', make sure that
CONFIG_SOC_DA8XX is defined.
Signed-off-by: Mohammed Afzal <afzal@ti.com>
---
board/davinci/common/misc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/davinci/common/misc.c b/board/davinci/common/misc.c
index 08c898f..c0a6c41 100644
--- a/board/davinci/common/misc.c
+++ b/board/davinci/common/misc.c
@@ -80,7 +80,7 @@ err:
/*
* Set the mii mode as MII or RMII
*/
-#if defined(CONFIG_DRIVER_TI_EMAC)
+#if defined(CONFIG_DRIVER_TI_EMAC) && defined(CONFIG_SOC_DA8XX)
void davinci_emac_mii_mode_sel(int mode_sel)
{
int val;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] DaVinci: Fix DM365 & DM644X build error
2011-01-20 11:27 [U-Boot] [PATCH 1/1] DaVinci: Fix DM365 & DM644X build error Mohammed Afzal
@ 2011-01-20 22:02 ` Albert ARIBAUD
2011-01-20 23:57 ` Paulraj, Sandeep
0 siblings, 1 reply; 3+ messages in thread
From: Albert ARIBAUD @ 2011-01-20 22:02 UTC (permalink / raw)
To: u-boot
Le 20/01/2011 12:27, Mohammed Afzal a ?crit :
> DM365& DM644X builds 'davinci_emac_mii_mode_sel()',
> which uses 'davinci_syscfg_regs' macro, and the
> macro is valid iff CONFIG_SOC_DA8XX is defined.
>
> Fix: Before compiling 'davinci_emac_mii_mode_sel()', make sure that
> CONFIG_SOC_DA8XX is defined.
>
> Signed-off-by: Mohammed Afzal<afzal@ti.com>
> ---
> board/davinci/common/misc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/davinci/common/misc.c b/board/davinci/common/misc.c
> index 08c898f..c0a6c41 100644
> --- a/board/davinci/common/misc.c
> +++ b/board/davinci/common/misc.c
> @@ -80,7 +80,7 @@ err:
> /*
> * Set the mii mode as MII or RMII
> */
> -#if defined(CONFIG_DRIVER_TI_EMAC)
> +#if defined(CONFIG_DRIVER_TI_EMAC)&& defined(CONFIG_SOC_DA8XX)
> void davinci_emac_mii_mode_sel(int mode_sel)
> {
> int val;
Seems this is already fixed by commit
51861a953aa10fde5c861ca022f0833f326e3041 which is in u-boot-ti/master,
right?
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] DaVinci: Fix DM365 & DM644X build error
2011-01-20 22:02 ` Albert ARIBAUD
@ 2011-01-20 23:57 ` Paulraj, Sandeep
0 siblings, 0 replies; 3+ messages in thread
From: Paulraj, Sandeep @ 2011-01-20 23:57 UTC (permalink / raw)
To: u-boot
>
> Seems this is already fixed by commit
> 51861a953aa10fde5c861ca022f0833f326e3041 which is in u-boot-ti/master,
> right?
>
Yes that is correct I believe. Before my vacation I was getting the entire Davinci series of SOCs compiling as they were broken for various reasons and this is one of the fixes I had made IIRC.
This commit should be in u-boot-arm/master as well
--Sandeep
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-20 23:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-20 11:27 [U-Boot] [PATCH 1/1] DaVinci: Fix DM365 & DM644X build error Mohammed Afzal
2011-01-20 22:02 ` Albert ARIBAUD
2011-01-20 23:57 ` Paulraj, Sandeep
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox