U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
To: Patrice CHOTARD <patrice.chotard@foss.st.com>,
	Tom Rini <trini@konsulko.com>,
	Kamil Lulko <kamil.lulko@gmail.com>,
	Dillon Min <dillon.minfei@gmail.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Anatolij Gustschin <ag.dev.uboot@gmail.com>,
	Simon Glass <sjg@chromium.org>,
	Sumit Garg <sumit.garg@kernel.org>,
	Philippe Cornu <philippe.cornu@foss.st.com>,
	Yannick Fertre <yannick.fertre@foss.st.com>
Cc: <u-boot@lists.denx.de>, <uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v3 4/7] video: stm32: ltdc: support new hardware version for STM32MP25 SoC
Date: Mon, 15 Sep 2025 15:05:58 +0200	[thread overview]
Message-ID: <4cd5e70d-875c-42da-859c-524ba439a171@foss.st.com> (raw)
In-Reply-To: <3b8a1653-9cf9-4107-b2a8-2c2f639a5ddb@foss.st.com>



On 9/12/25 18:41, Patrice CHOTARD wrote:
>
> On 9/4/25 14:53, Raphael Gallais-Pou wrote:
>> ...

>>  static const struct udevice_id stm32_ltdc_ids[] = {
>>  	{ .compatible = "st,stm32-ltdc" },
>> +	{ .compatible = "st,stm32mp251-ltdc" },
>> +	{ .compatible = "st,stm32mp255-ltdc" },
> in V1, only "st,stm32mp251-ltdc" compatible was introduced.
> Why are you adding "st,stm32mp255-ltdc" compatible ? 
>
> For me only "st,stm32-ltdc" is needed, currently, nothing in drivers/video/stm32/stm32_ltdc.c
> is justifying to add "st,stm32mp251-ltdc" or "st,stm32mp251-ltdc" new compatible.
>
> Patrice

Hi Patrice,

It has been poorly explained in the cover letter. Between the v3 and v4 versions
of the Linux series:
https://lore.kernel.org/all/20250822-drm-misc-next-v5-0-9c825e28f733@foss.st.com/

Since U-Boot is based on the Linux device-tree, I figured it might follow the
added compatible.
Now the reason why the "st,stm32mp255-ltdc" has been added is because on the
STM32MP255 (and bigger) the LTDC needs 4 clocks, whether on the STM32MP251 and
smaller SoCs it only needs two. Thus the two new compatibles. Furthermore there
is features depending on the SoC version which will be added in the near future.
Best regards, Raphaël
>
>>  	{ }
>>  };
>>  
>>


  reply	other threads:[~2025-09-15 13:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 12:53 [PATCH v3 0/7] Add display support for STM32MP25 Raphael Gallais-Pou
2025-09-04 12:53 ` [PATCH v3 1/7] ofnode: support panel-timings in ofnode_decode_display_timing Raphael Gallais-Pou
2025-10-30  7:35   ` Yannick FERTRE
2025-11-01  9:03   ` Simon Glass
2025-11-02  1:09     ` [Uboot-stm32] " Raphaël Gallais-Pou
2025-11-02 19:53       ` Simon Glass
2025-11-03 14:17         ` Tom Rini
2025-11-04 14:01           ` Raphael Gallais-Pou
2025-11-04 16:21             ` Tom Rini
2025-11-14 16:48               ` Patrice CHOTARD
2025-11-04 16:31           ` Simon Glass
2025-11-04 16:55             ` Tom Rini
2025-11-07 12:23               ` Simon Glass
2025-09-04 12:53 ` [PATCH v3 2/7] video: simple_panel: add support for "panel-lvds" display Raphael Gallais-Pou
2025-10-30  7:41   ` Yannick FERTRE
2025-11-14 16:48   ` Patrice CHOTARD
2025-09-04 12:53 ` [PATCH v3 3/7] video: stm32: STM32 driver support for LVDS Raphael Gallais-Pou
2025-10-30  7:42   ` Yannick FERTRE
2025-11-14 16:48     ` Patrice CHOTARD
2025-09-04 12:53 ` [PATCH v3 4/7] video: stm32: ltdc: support new hardware version for STM32MP25 SoC Raphael Gallais-Pou
2025-09-12 16:41   ` Patrice CHOTARD
2025-09-15 13:05     ` Raphael Gallais-Pou [this message]
2025-09-17 15:10       ` Patrice CHOTARD
2025-10-30  7:43   ` Yannick FERTRE
2025-11-14 16:49     ` Patrice CHOTARD
2025-09-04 12:53 ` [PATCH v3 5/7] video: stm32: ltdc: properly search the first available panel Raphael Gallais-Pou
2025-09-12 16:45   ` Patrice CHOTARD
2025-10-30  7:43   ` Yannick FERTRE
2025-11-14 16:49     ` Patrice CHOTARD
2025-09-04 12:53 ` [PATCH v3 6/7] ARM: dts: stm32: use LTDC and LVDS nodes before relocation in stm32mp25-u-boot Raphael Gallais-Pou
2025-09-12 16:45   ` Patrice CHOTARD
2025-10-30  7:43   ` Yannick FERTRE
2025-11-14 16:49     ` Patrice CHOTARD
2025-11-14 16:54       ` Patrice CHOTARD
2025-11-14 17:30         ` [Uboot-stm32] " Patrice CHOTARD
2025-09-04 12:53 ` [PATCH v3 7/7] configs: stm32mp25: enable LVDS display support Raphael Gallais-Pou
2025-09-12 16:46   ` Patrice CHOTARD
2025-10-30  7:44   ` Yannick FERTRE
2025-11-14 16:48   ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cd5e70d-875c-42da-859c-524ba439a171@foss.st.com \
    --to=raphael.gallais-pou@foss.st.com \
    --cc=ag.dev.uboot@gmail.com \
    --cc=dillon.minfei@gmail.com \
    --cc=kamil.lulko@gmail.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=philippe.cornu@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=sumit.garg@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    --cc=yannick.fertre@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox