From: Stefan Roese <sr@denx.de>
To: Tony Dinh <mibodhi@gmail.com>,
U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Chris Packham <judge.packham@gmail.com>
Subject: Re: [PATCH 4/4] NSA310S : Add DM SATA configs
Date: Thu, 1 Jul 2021 10:20:44 +0200 [thread overview]
Message-ID: <4e398778-71b2-e48f-c6c2-56aabadbf7b2@denx.de> (raw)
In-Reply-To: <20210701042625.18815-5-mibodhi@gmail.com>
On 01.07.21 06:26, Tony Dinh wrote:
> Enable DM SATA, removed IDE driver, and add SATA MV driver.
>
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> ---
>
> include/configs/nsa310s.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/configs/nsa310s.h b/include/configs/nsa310s.h
> index e38c65a485..94f293de90 100644
> --- a/include/configs/nsa310s.h
> +++ b/include/configs/nsa310s.h
> @@ -1,5 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0+ */
> /*
> + * Copyright (C) 2021 Tony Dinh <mibodhi@gmail.com>
> * Copyright (C) 2015
> * Gerald Kerma <dreagle@doukki.net>
> * Tony Dinh <mibodhi@gmail.com>
Please change this copyright line instead of adding yourself a 2nd
time.
Other than this:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> @@ -46,10 +47,10 @@
> #endif /* CONFIG_CMD_NET */
>
> /* SATA driver configuration */
> -#ifdef CONFIG_IDE
> -#define __io
> -#define CONFIG_SYS_ATA_IDE0_OFFSET MV_SATA_PORT0_OFFSET
> -#endif /* CONFIG_IDE */
> +#ifdef CONFIG_SATA
> +#define CONFIG_SYS_SATA_MAX_DEVICE 1
> +#define CONFIG_LBA48
> +#endif /* CONFIG_SATA */
>
> /* RTC driver configuration */
> #ifdef CONFIG_CMD_DATE
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2021-07-01 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 4:26 [PATCH 0/4] Zyxel NSA310S NAS : convert to Driver Model Tony Dinh
2021-07-01 4:26 ` [PATCH 1/4] NSA310S : Add device tree DTS for Zyxel NSA310S board Tony Dinh
2021-07-01 8:14 ` Stefan Roese
2021-07-01 4:26 ` [PATCH 2/4] NSA310S : Add DM USB, DM Ethernet, and DM SATA configs Tony Dinh
2021-07-01 8:14 ` Stefan Roese
2021-07-01 4:26 ` [PATCH 3/4] NSA310S : Use Ethernet PHY name from device tree Tony Dinh
2021-07-01 8:19 ` Stefan Roese
2021-07-01 8:22 ` Stefan Roese
2021-07-01 10:56 ` Tony (bodhi)
2021-07-01 4:26 ` [PATCH 4/4] NSA310S : Add DM SATA configs Tony Dinh
2021-07-01 8:20 ` Stefan Roese [this message]
2021-07-19 12:32 ` [PATCH 0/4] Zyxel NSA310S NAS : convert to Driver Model Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e398778-71b2-e48f-c6c2-56aabadbf7b2@denx.de \
--to=sr@denx.de \
--cc=judge.packham@gmail.com \
--cc=mibodhi@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox