U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: Tony Dinh <mibodhi@gmail.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Chris Packham <judge.packham@gmail.com>
Subject: Re: [PATCH 2/4] NSA310S : Add DM USB, DM Ethernet, and DM SATA configs
Date: Thu, 1 Jul 2021 10:14:34 +0200	[thread overview]
Message-ID: <8145ffc2-805b-c8e8-7898-1d7cb6a02484@denx.de> (raw)
In-Reply-To: <20210701042625.18815-3-mibodhi@gmail.com>

On 01.07.21 06:26, Tony Dinh wrote:
> Convert to Driver Model.
> 
> - Add DM USB, DM Ethernet, and DM SATA configs to nsa310s_defconfig
> - Add CONFIG_DEFAULT_DEVICE_TREE to nsa310s_defconfig
> - Move CONFIG_ENV_SECT_SIZE from board file to nsa310s_defconfig
> - Add CONFIG_IDENT_STRING, and CONFIG_NET_RANDOM_ETHADDR
> to nsa310s_defconfig
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> 
>   configs/nsa310s_defconfig | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig
> index e4cf1c470e..fac0322e2b 100644
> --- a/configs/nsa310s_defconfig
> +++ b/configs/nsa310s_defconfig
> @@ -7,14 +7,16 @@ CONFIG_NR_DRAM_BANKS=2
>   CONFIG_TARGET_NSA310S=y
>   CONFIG_ENV_SIZE=0x20000
>   CONFIG_ENV_OFFSET=0xE0000
> +CONFIG_ENV_SECT_SIZE=0x20000
> +CONFIG_DEFAULT_DEVICE_TREE="kirkwood-nsa310s"
>   CONFIG_BOOTDELAY=3
>   CONFIG_USE_PREBOOT=y
>   # CONFIG_DISPLAY_BOARDINFO is not set
>   CONFIG_HUSH_PARSER=y
>   CONFIG_SYS_PROMPT="nsa310s => "
> +CONFIG_IDENT_STRING="\nZyXEL NSA310S/320S 1/2-Bay Power Media Server"
>   CONFIG_CMD_BOOTZ=y
>   # CONFIG_CMD_FLASH is not set
> -CONFIG_CMD_IDE=y
>   CONFIG_CMD_NAND=y
>   CONFIG_CMD_USB=y
>   # CONFIG_CMD_SETEXPR is not set
> @@ -44,3 +46,11 @@ CONFIG_USB_STORAGE=y
>   CONFIG_LZMA=y
>   CONFIG_BZIP2=y
>   CONFIG_OF_LIBFDT=y
> +CONFIG_DM=y
> +CONFIG_BLK=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_DM_USB=y
> +CONFIG_DM_ETH=y
> +CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_CMD_SATA=y
> +CONFIG_SATA_MV=y
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

  reply	other threads:[~2021-07-01  8:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  4:26 [PATCH 0/4] Zyxel NSA310S NAS : convert to Driver Model Tony Dinh
2021-07-01  4:26 ` [PATCH 1/4] NSA310S : Add device tree DTS for Zyxel NSA310S board Tony Dinh
2021-07-01  8:14   ` Stefan Roese
2021-07-01  4:26 ` [PATCH 2/4] NSA310S : Add DM USB, DM Ethernet, and DM SATA configs Tony Dinh
2021-07-01  8:14   ` Stefan Roese [this message]
2021-07-01  4:26 ` [PATCH 3/4] NSA310S : Use Ethernet PHY name from device tree Tony Dinh
2021-07-01  8:19   ` Stefan Roese
2021-07-01  8:22     ` Stefan Roese
2021-07-01 10:56       ` Tony (bodhi)
2021-07-01  4:26 ` [PATCH 4/4] NSA310S : Add DM SATA configs Tony Dinh
2021-07-01  8:20   ` Stefan Roese
2021-07-19 12:32 ` [PATCH 0/4] Zyxel NSA310S NAS : convert to Driver Model Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8145ffc2-805b-c8e8-7898-1d7cb6a02484@denx.de \
    --to=sr@denx.de \
    --cc=judge.packham@gmail.com \
    --cc=mibodhi@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox