[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Soeren Moch]

This is not required for sysboot (we defined fdtfile), let's save a few
bytes in the binary image without these variables.

Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: u-boot at lists.denx.de
---
 configs/tbs2910_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
index 34d240565e..070aea59b5 100644
--- a/configs/tbs2910_defconfig
+++ b/configs/tbs2910_defconfig
@@ -11,7 +11,6 @@ CONFIG_PRE_CON_BUF_ADDR=0x7c000000
 CONFIG_CMD_HDMIDETECT=y
 CONFIG_DEFAULT_DEVICE_TREE="imx6q-tbs2910"
 CONFIG_AHCI=y
-CONFIG_ENV_VARS_UBOOT_CONFIG=y
 CONFIG_BOOTDELAY=3
 CONFIG_USE_BOOTCOMMAND=y
 CONFIG_BOOTCOMMAND="mmc rescan; if run bootcmd_up1; then run bootcmd_up2; else run bootcmd_mmc || run distro_bootcmd; fi"
--
2.17.1

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Fabio Estevam]

On Thu, Aug 27, 2020 at 4:53 PM Soeren Moch <smoch@web.de> wrote:
>
> This is not required for sysboot (we defined fdtfile), let's save a few
> bytes in the binary image without these variables.
>
> Signed-off-by: Soeren Moch <smoch@web.de>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[sbabic at denx.de]

> This is not required for sysboot (we defined fdtfile), let's save a few
> bytes in the binary image without these variables.
> Signed-off-by: Soeren Moch <smoch@web.de>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Soeren Moch]

On 18.09.20 17:21, sbabic at denx.de wrote:
>> This is not required for sysboot (we defined fdtfile), let's save a few
>> bytes in the binary image without these variables.
>> Signed-off-by: Soeren Moch <smoch@web.de>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Applied to u-boot-imx, master, thanks !
>

Thanks, Stefano.

What happened to the first patch of this series?? Patchwork status is
"Changes Requested", but his patch only received 2 reviewed-by, no other
requests.

Thanks,
Soeren

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Stefano Babic]

On 18.09.20 17:48, Soeren Moch wrote:
> On 18.09.20 17:21, sbabic at denx.de wrote:
>>> This is not required for sysboot (we defined fdtfile), let's save a few
>>> bytes in the binary image without these variables.
>>> Signed-off-by: Soeren Moch <smoch@web.de>
>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>> Applied to u-boot-imx, master, thanks !
>>
> 
> Thanks, Stefano.
> 
> What happened to the first patch of this series?? Patchwork status is
> "Changes Requested", but his patch only received 2 reviewed-by, no other
> requests.

Mmmhhh...when patch is in "Changes requested", it disappears from
Patchwork's TODO list and I do not see it anymore. Thanks for reporting
this, I search for it and I'll pick it up.

Stefano

> 
> Thanks,
> Soeren
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Soeren Moch]

On 18.09.20 17:51, Stefano Babic wrote:
> On 18.09.20 17:48, Soeren Moch wrote:
>> On 18.09.20 17:21, sbabic at denx.de wrote:
>>>> This is not required for sysboot (we defined fdtfile), let's save a few
>>>> bytes in the binary image without these variables.
>>>> Signed-off-by: Soeren Moch <smoch@web.de>
>>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>> Applied to u-boot-imx, master, thanks !
>>>
>> Thanks, Stefano.
>>
>> What happened to the first patch of this series?? Patchwork status is
>> "Changes Requested", but his patch only received 2 reviewed-by, no other
>> requests.
> Mmmhhh...when patch is in "Changes requested", it disappears from
> Patchwork's TODO list and I do not see it anymore. Thanks for reporting
> this, I search for it and I'll pick it up.
>
OK, thanks. No problem to apply patch 1/2 after 2/2.

Thanks again,
Soeren

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Tom Rini]

On Fri, Sep 18, 2020 at 05:56:03PM +0200, Soeren Moch wrote:
> 
> 
> On 18.09.20 17:51, Stefano Babic wrote:
> > On 18.09.20 17:48, Soeren Moch wrote:
> >> On 18.09.20 17:21, sbabic at denx.de wrote:
> >>>> This is not required for sysboot (we defined fdtfile), let's save a few
> >>>> bytes in the binary image without these variables.
> >>>> Signed-off-by: Soeren Moch <smoch@web.de>
> >>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> >>> Applied to u-boot-imx, master, thanks !
> >>>
> >> Thanks, Stefano.
> >>
> >> What happened to the first patch of this series?? Patchwork status is
> >> "Changes Requested", but his patch only received 2 reviewed-by, no other
> >> requests.
> > Mmmhhh...when patch is in "Changes requested", it disappears from
> > Patchwork's TODO list and I do not see it anymore. Thanks for reporting
> > this, I search for it and I'll pick it up.
> >
> OK, thanks. No problem to apply patch 1/2 after 2/2.

Sorry, I think I see what happened.  I had intended to, I suspect, mark
https://patchwork.ozlabs.org/project/uboot/patch/20191010230048.10935-1-smoch at web.de/
as "Changes Requested" (in part because it was suggested to also change
the level of the message, and in part because I think it's been
superseded by a change to do the same thing basically by now) and my
mouse slipped.

I'll re-confirm that the MAC warning thing has been taken care of today,
as well.  Again, sorry about that!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200918/a17da9bd/attachment.sig>

[PATCH 2/2] board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

[Soeren Moch]

On 18.09.20 18:21, Tom Rini wrote:
> On Fri, Sep 18, 2020 at 05:56:03PM +0200, Soeren Moch wrote:
>>
>> On 18.09.20 17:51, Stefano Babic wrote:
>>> On 18.09.20 17:48, Soeren Moch wrote:
>>>> On 18.09.20 17:21, sbabic at denx.de wrote:
>>>>>> This is not required for sysboot (we defined fdtfile), let's save a few
>>>>>> bytes in the binary image without these variables.
>>>>>> Signed-off-by: Soeren Moch <smoch@web.de>
>>>>>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>>>>> Applied to u-boot-imx, master, thanks !
>>>>>
>>>> Thanks, Stefano.
>>>>
>>>> What happened to the first patch of this series?? Patchwork status is
>>>> "Changes Requested", but his patch only received 2 reviewed-by, no other
>>>> requests.
>>> Mmmhhh...when patch is in "Changes requested", it disappears from
>>> Patchwork's TODO list and I do not see it anymore. Thanks for reporting
>>> this, I search for it and I'll pick it up.
>>>
>> OK, thanks. No problem to apply patch 1/2 after 2/2.
> Sorry, I think I see what happened.  I had intended to, I suspect, mark
> https://patchwork.ozlabs.org/project/uboot/patch/20191010230048.10935-1-smoch at web.de/
> as "Changes Requested" (in part because it was suggested to also change
> the level of the message, and in part because I think it's been
> superseded by a change to do the same thing basically by now) and my
> mouse slipped.
>
> I'll re-confirm that the MAC warning thing has been taken care of today,
> as well.  Again, sorry about that!
>
The MAC warning on tbs2910 was gone some time ago. So the linked patch
must indeed be superseded by something that is already applied.

Soeren