* [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration @ 2022-02-23 14:56 Michal Simek 2022-02-23 17:31 ` Marek Vasut 2022-03-03 8:40 ` Bin Meng 0 siblings, 2 replies; 11+ messages in thread From: Michal Simek @ 2022-02-23 14:56 UTC (permalink / raw) To: u-boot, git; +Cc: Angus Ainslie, Kunihiko Hayashi, Marek Vasut, Simon Glass When usb3-phy label is found, PHY driver is called and serdes line is initialized. This is preparation for serdes/psgtr driver to configure GT lines based on description in DT. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 01bd0ca190e3..b1e019b5b91a 100644 --- a/drivers/usb/dwc3/dwc3-generic.c +++ b/drivers/usb/dwc3/dwc3-generic.c @@ -409,6 +409,17 @@ static int dwc3_glue_probe(struct udevice *dev) struct udevice *child = NULL; int index = 0; int ret; + struct phy phy; + + ret = generic_phy_get_by_name(dev, "usb3-phy", &phy); + if (!ret) { + ret = generic_phy_init(&phy); + if (ret) + return ret; + } else if (ret != -ENOENT) { + debug("could not get phy (err %d)\n", ret); + return ret; + } glue->regs = dev_read_addr(dev); @@ -420,6 +431,12 @@ static int dwc3_glue_probe(struct udevice *dev) if (ret) return ret; + if (phy.dev) { + ret = generic_phy_power_on(&phy); + if (ret) + return ret; + } + ret = device_find_first_child(dev, &child); if (ret) return ret; -- 2.35.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-02-23 14:56 [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration Michal Simek @ 2022-02-23 17:31 ` Marek Vasut 2022-03-03 8:40 ` Bin Meng 1 sibling, 0 replies; 11+ messages in thread From: Marek Vasut @ 2022-02-23 17:31 UTC (permalink / raw) To: Michal Simek, u-boot, git Cc: Angus Ainslie, Kunihiko Hayashi, Simon Glass, Bin Meng On 2/23/22 15:56, Michal Simek wrote: > When usb3-phy label is found, PHY driver is called and serdes line is > initialized. This is preparation for serdes/psgtr driver to configure GT > lines based on description in DT. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c > index 01bd0ca190e3..b1e019b5b91a 100644 > --- a/drivers/usb/dwc3/dwc3-generic.c > +++ b/drivers/usb/dwc3/dwc3-generic.c > @@ -409,6 +409,17 @@ static int dwc3_glue_probe(struct udevice *dev) > struct udevice *child = NULL; > int index = 0; > int ret; > + struct phy phy; > + > + ret = generic_phy_get_by_name(dev, "usb3-phy", &phy); > + if (!ret) { > + ret = generic_phy_init(&phy); > + if (ret) > + return ret; > + } else if (ret != -ENOENT) { > + debug("could not get phy (err %d)\n", ret); > + return ret; > + } > > glue->regs = dev_read_addr(dev); > > @@ -420,6 +431,12 @@ static int dwc3_glue_probe(struct udevice *dev) > if (ret) > return ret; > > + if (phy.dev) { > + ret = generic_phy_power_on(&phy); > + if (ret) > + return ret; > + } > + > ret = device_find_first_child(dev, &child); > if (ret) > return ret; CC Bin please. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-02-23 14:56 [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration Michal Simek 2022-02-23 17:31 ` Marek Vasut @ 2022-03-03 8:40 ` Bin Meng 2022-03-04 4:42 ` Marek Vasut 1 sibling, 1 reply; 11+ messages in thread From: Bin Meng @ 2022-03-03 8:40 UTC (permalink / raw) To: Michal Simek Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Marek Vasut, Simon Glass On Wed, Feb 23, 2022 at 10:56 PM Michal Simek <michal.simek@xilinx.com> wrote: > > When usb3-phy label is found, PHY driver is called and serdes line is > initialized. This is preparation for serdes/psgtr driver to configure GT > lines based on description in DT. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-03 8:40 ` Bin Meng @ 2022-03-04 4:42 ` Marek Vasut 2022-03-04 17:33 ` Marek Vasut 0 siblings, 1 reply; 11+ messages in thread From: Marek Vasut @ 2022-03-04 4:42 UTC (permalink / raw) To: Bin Meng, Michal Simek Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/3/22 09:40, Bin Meng wrote: > On Wed, Feb 23, 2022 at 10:56 PM Michal Simek <michal.simek@xilinx.com> wrote: >> >> When usb3-phy label is found, PHY driver is called and serdes line is >> initialized. This is preparation for serdes/psgtr driver to configure GT >> lines based on description in DT. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied, thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-04 4:42 ` Marek Vasut @ 2022-03-04 17:33 ` Marek Vasut 2022-03-08 13:21 ` Michal Simek 0 siblings, 1 reply; 11+ messages in thread From: Marek Vasut @ 2022-03-04 17:33 UTC (permalink / raw) To: Bin Meng, Michal Simek Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/4/22 05:42, Marek Vasut wrote: > On 3/3/22 09:40, Bin Meng wrote: >> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek >> <michal.simek@xilinx.com> wrote: >>> >>> When usb3-phy label is found, PHY driver is called and serdes line is >>> initialized. This is preparation for serdes/psgtr driver to configure GT >>> lines based on description in DT. >>> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> --- >>> >>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >> >> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > Applied, thanks. Fails to build, please fix. Patch dropped: https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-04 17:33 ` Marek Vasut @ 2022-03-08 13:21 ` Michal Simek 2022-03-08 13:39 ` Marek Vasut 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2022-03-08 13:21 UTC (permalink / raw) To: Marek Vasut, Bin Meng, Michal Simek Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/4/22 18:33, Marek Vasut wrote: > On 3/4/22 05:42, Marek Vasut wrote: >> On 3/3/22 09:40, Bin Meng wrote: >>> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek <michal.simek@xilinx.com> wrote: >>>> >>>> When usb3-phy label is found, PHY driver is called and serdes line is >>>> initialized. This is preparation for serdes/psgtr driver to configure GT >>>> lines based on description in DT. >>>> >>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>> --- >>>> >>>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>>> 1 file changed, 17 insertions(+) >>>> >>> >>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >> >> Applied, thanks. > > Fails to build, please fix. Patch dropped: > > https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 This patch is fixing the problem https://lore.kernel.org/r/eabd31079152659556432fed561cd3a98300c8f5.1646745547.git.michal.simek@xilinx.com Thanks, Michal ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-08 13:21 ` Michal Simek @ 2022-03-08 13:39 ` Marek Vasut 2022-03-08 13:46 ` Michal Simek 0 siblings, 1 reply; 11+ messages in thread From: Marek Vasut @ 2022-03-08 13:39 UTC (permalink / raw) To: Michal Simek, Bin Meng Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/8/22 14:21, Michal Simek wrote: > > > On 3/4/22 18:33, Marek Vasut wrote: >> On 3/4/22 05:42, Marek Vasut wrote: >>> On 3/3/22 09:40, Bin Meng wrote: >>>> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek >>>> <michal.simek@xilinx.com> wrote: >>>>> >>>>> When usb3-phy label is found, PHY driver is called and serdes line is >>>>> initialized. This is preparation for serdes/psgtr driver to >>>>> configure GT >>>>> lines based on description in DT. >>>>> >>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>> --- >>>>> >>>>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>>>> 1 file changed, 17 insertions(+) >>>>> >>>> >>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>> >>> Applied, thanks. >> >> Fails to build, please fix. Patch dropped: >> >> https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 > > > This patch is fixing the problem > > https://lore.kernel.org/r/eabd31079152659556432fed561cd3a98300c8f5.1646745547.git.michal.simek@xilinx.com I'm confused, is this a patch I should try to apply somehow ? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-08 13:39 ` Marek Vasut @ 2022-03-08 13:46 ` Michal Simek 2022-03-08 15:32 ` Marek Vasut 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2022-03-08 13:46 UTC (permalink / raw) To: Marek Vasut, Michal Simek, Bin Meng Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/8/22 14:39, Marek Vasut wrote: > On 3/8/22 14:21, Michal Simek wrote: >> >> >> On 3/4/22 18:33, Marek Vasut wrote: >>> On 3/4/22 05:42, Marek Vasut wrote: >>>> On 3/3/22 09:40, Bin Meng wrote: >>>>> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek <michal.simek@xilinx.com> wrote: >>>>>> >>>>>> When usb3-phy label is found, PHY driver is called and serdes line is >>>>>> initialized. This is preparation for serdes/psgtr driver to configure GT >>>>>> lines based on description in DT. >>>>>> >>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>>> --- >>>>>> >>>>>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>>>>> 1 file changed, 17 insertions(+) >>>>>> >>>>> >>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>> >>>> Applied, thanks. >>> >>> Fails to build, please fix. Patch dropped: >>> >>> https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 >> >> >> This patch is fixing the problem >> >> https://lore.kernel.org/r/eabd31079152659556432fed561cd3a98300c8f5.1646745547.git.michal.simek@xilinx.com > > > I'm confused, is this a patch I should try to apply somehow ? It should be applied before that dwc3 patch. If you don't want to apply it via your usb tree I can take it via my tree or ask Tom to take it. Thanks, Michal ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-08 13:46 ` Michal Simek @ 2022-03-08 15:32 ` Marek Vasut 2022-03-08 15:34 ` Michal Simek 0 siblings, 1 reply; 11+ messages in thread From: Marek Vasut @ 2022-03-08 15:32 UTC (permalink / raw) To: Michal Simek, Bin Meng Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/8/22 14:46, Michal Simek wrote: > > > On 3/8/22 14:39, Marek Vasut wrote: >> On 3/8/22 14:21, Michal Simek wrote: >>> >>> >>> On 3/4/22 18:33, Marek Vasut wrote: >>>> On 3/4/22 05:42, Marek Vasut wrote: >>>>> On 3/3/22 09:40, Bin Meng wrote: >>>>>> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek >>>>>> <michal.simek@xilinx.com> wrote: >>>>>>> >>>>>>> When usb3-phy label is found, PHY driver is called and serdes >>>>>>> line is >>>>>>> initialized. This is preparation for serdes/psgtr driver to >>>>>>> configure GT >>>>>>> lines based on description in DT. >>>>>>> >>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>>>> --- >>>>>>> >>>>>>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>>>>>> 1 file changed, 17 insertions(+) >>>>>>> >>>>>> >>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>>> >>>>> Applied, thanks. >>>> >>>> Fails to build, please fix. Patch dropped: >>>> >>>> https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 >>> >>> >>> This patch is fixing the problem >>> >>> https://lore.kernel.org/r/eabd31079152659556432fed561cd3a98300c8f5.1646745547.git.michal.simek@xilinx.com >> >> >> >> I'm confused, is this a patch I should try to apply somehow ? > > It should be applied before that dwc3 patch. If you don't want to apply > it via your usb tree I can take it via my tree or ask Tom to take it. Please just collect the patches in the right order and resubmit them. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-08 15:32 ` Marek Vasut @ 2022-03-08 15:34 ` Michal Simek 2022-03-08 21:58 ` Marek Vasut 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2022-03-08 15:34 UTC (permalink / raw) To: Marek Vasut, Michal Simek, Bin Meng Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/8/22 16:32, Marek Vasut wrote: > On 3/8/22 14:46, Michal Simek wrote: >> >> >> On 3/8/22 14:39, Marek Vasut wrote: >>> On 3/8/22 14:21, Michal Simek wrote: >>>> >>>> >>>> On 3/4/22 18:33, Marek Vasut wrote: >>>>> On 3/4/22 05:42, Marek Vasut wrote: >>>>>> On 3/3/22 09:40, Bin Meng wrote: >>>>>>> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek <michal.simek@xilinx.com> >>>>>>> wrote: >>>>>>>> >>>>>>>> When usb3-phy label is found, PHY driver is called and serdes line is >>>>>>>> initialized. This is preparation for serdes/psgtr driver to configure GT >>>>>>>> lines based on description in DT. >>>>>>>> >>>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>>>>> --- >>>>>>>> >>>>>>>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>>>>>>> 1 file changed, 17 insertions(+) >>>>>>>> >>>>>>> >>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>>>> >>>>>> Applied, thanks. >>>>> >>>>> Fails to build, please fix. Patch dropped: >>>>> >>>>> https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 >>>> >>>> >>>> This patch is fixing the problem >>>> >>>> https://lore.kernel.org/r/eabd31079152659556432fed561cd3a98300c8f5.1646745547.git.michal.simek@xilinx.com >>> >>> >>> >>> >>> I'm confused, is this a patch I should try to apply somehow ? >> >> It should be applied before that dwc3 patch. If you don't want to apply it via >> your usb tree I can take it via my tree or ask Tom to take it. > > Please just collect the patches in the right order and resubmit them. They were sent in the right order. 1/2 header fix, 2/2 dwc3 fix. Both of them are in patchwork. M ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration 2022-03-08 15:34 ` Michal Simek @ 2022-03-08 21:58 ` Marek Vasut 0 siblings, 0 replies; 11+ messages in thread From: Marek Vasut @ 2022-03-08 21:58 UTC (permalink / raw) To: Michal Simek, Bin Meng Cc: U-Boot Mailing List, git, Angus Ainslie, Kunihiko Hayashi, Simon Glass On 3/8/22 16:34, Michal Simek wrote: > > > On 3/8/22 16:32, Marek Vasut wrote: >> On 3/8/22 14:46, Michal Simek wrote: >>> >>> >>> On 3/8/22 14:39, Marek Vasut wrote: >>>> On 3/8/22 14:21, Michal Simek wrote: >>>>> >>>>> >>>>> On 3/4/22 18:33, Marek Vasut wrote: >>>>>> On 3/4/22 05:42, Marek Vasut wrote: >>>>>>> On 3/3/22 09:40, Bin Meng wrote: >>>>>>>> On Wed, Feb 23, 2022 at 10:56 PM Michal Simek >>>>>>>> <michal.simek@xilinx.com> wrote: >>>>>>>>> >>>>>>>>> When usb3-phy label is found, PHY driver is called and serdes >>>>>>>>> line is >>>>>>>>> initialized. This is preparation for serdes/psgtr driver to >>>>>>>>> configure GT >>>>>>>>> lines based on description in DT. >>>>>>>>> >>>>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>>>>>> --- >>>>>>>>> >>>>>>>>> drivers/usb/dwc3/dwc3-generic.c | 17 +++++++++++++++++ >>>>>>>>> 1 file changed, 17 insertions(+) >>>>>>>>> >>>>>>>> >>>>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> >>>>>>> >>>>>>> Applied, thanks. >>>>>> >>>>>> Fails to build, please fix. Patch dropped: >>>>>> >>>>>> https://source.denx.de/u-boot/custodians/u-boot-usb/-/jobs/399461 >>>>> >>>>> >>>>> This patch is fixing the problem >>>>> >>>>> https://lore.kernel.org/r/eabd31079152659556432fed561cd3a98300c8f5.1646745547.git.michal.simek@xilinx.com >>>> >>>> >>>> >>>> >>>> >>>> I'm confused, is this a patch I should try to apply somehow ? >>> >>> It should be applied before that dwc3 patch. If you don't want to >>> apply it via your usb tree I can take it via my tree or ask Tom to >>> take it. >> >> Please just collect the patches in the right order and resubmit them. > > They were sent in the right order. 1/2 header fix, 2/2 dwc3 fix. > Both of them are in patchwork. I received random lore patch link here, another half of series in another thread and now I should look up yet more patches in patchwork. I am really confused, I do not know what you expect me to do about this, randomly try to chase down patches in multiple patch trackers, try to apply them somehow, and likely get it all wrong? Please, collect and resubmit the patches which you want applied, that way we can be certain I apply the right patches in the right order. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-03-08 21:58 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-02-23 14:56 [PATCH] usb: dwc3: Add support for usb3-phy PHY configuration Michal Simek 2022-02-23 17:31 ` Marek Vasut 2022-03-03 8:40 ` Bin Meng 2022-03-04 4:42 ` Marek Vasut 2022-03-04 17:33 ` Marek Vasut 2022-03-08 13:21 ` Michal Simek 2022-03-08 13:39 ` Marek Vasut 2022-03-08 13:46 ` Michal Simek 2022-03-08 15:32 ` Marek Vasut 2022-03-08 15:34 ` Michal Simek 2022-03-08 21:58 ` Marek Vasut
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox