* [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition
@ 2012-08-23 14:44 Matt Sealey
2012-08-23 14:49 ` Stefano Babic
2013-03-09 7:09 ` Wolfgang Denk
0 siblings, 2 replies; 6+ messages in thread
From: Matt Sealey @ 2012-08-23 14:44 UTC (permalink / raw)
To: u-boot
This gives us a string like "20120822150855" which encodes the build time.
This allows automated version checking and flashing of U-Boot to be performed,
for example, in boot.scr files (or scripting in general).
Signed-off-by: Matt Sealey <matt@genesi-usa.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Marek Vasut <marex@denx.de>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 1df4c1d..c042206 100644
--- a/Makefile
+++ b/Makefile
@@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
@mkdir -p $(dir $(TIMESTAMP_FILE))
@LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@.tmp
@LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@.tmp
+ @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> $@.tmp
@cmp -s $@ $@.tmp && rm -f $@.tmp || mv -f $@.tmp $@
easylogo env gdb:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition
2012-08-23 14:44 [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition Matt Sealey
@ 2012-08-23 14:49 ` Stefano Babic
2012-08-23 15:01 ` Matt Sealey
2013-03-09 7:09 ` Wolfgang Denk
1 sibling, 1 reply; 6+ messages in thread
From: Stefano Babic @ 2012-08-23 14:49 UTC (permalink / raw)
To: u-boot
On 23/08/2012 16:44, Matt Sealey wrote:
> This gives us a string like "20120822150855" which encodes the build time.
>
> This allows automated version checking and flashing of U-Boot to be performed,
> for example, in boot.scr files (or scripting in general).
>
> Signed-off-by: Matt Sealey <matt@genesi-usa.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> ---
Hi Matt,
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 1df4c1d..c042206 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
> @mkdir -p $(dir $(TIMESTAMP_FILE))
> @LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@.tmp
> @LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@.tmp
> + @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> $@.tmp
> @cmp -s $@ $@.tmp && rm -f $@.tmp || mv -f $@.tmp $@
>
This is not related to iMX only. I set CC to Wolfgang.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition
2012-08-23 14:49 ` Stefano Babic
@ 2012-08-23 15:01 ` Matt Sealey
0 siblings, 0 replies; 6+ messages in thread
From: Matt Sealey @ 2012-08-23 15:01 UTC (permalink / raw)
To: u-boot
On Thu, Aug 23, 2012 at 9:49 AM, Stefano Babic <sbabic@denx.de> wrote:
> On 23/08/2012 16:44, Matt Sealey wrote:
>> This gives us a string like "20120822150855" which encodes the build time.
>>
>> This allows automated version checking and flashing of U-Boot to be performed,
>> for example, in boot.scr files (or scripting in general).
>>
>> Signed-off-by: Matt Sealey <matt@genesi-usa.com>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Marek Vasut <marex@denx.de>
>> ---
>
> Hi Matt,
>
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 1df4c1d..c042206 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
>> @mkdir -p $(dir $(TIMESTAMP_FILE))
>> @LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@.tmp
>> @LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@.tmp
>> + @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> $@.tmp
>> @cmp -s $@ $@.tmp && rm -f $@.tmp || mv -f $@.tmp $@
>>
>
> This is not related to iMX only. I set CC to Wolfgang.
Noted, totally my fault.
--
Matt Sealey <matt@genesi-usa.com>
Product Development Analyst, Genesi USA, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition
2012-08-23 14:44 [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition Matt Sealey
2012-08-23 14:49 ` Stefano Babic
@ 2013-03-09 7:09 ` Wolfgang Denk
2013-04-05 16:27 ` Matt Sealey
1 sibling, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2013-03-09 7:09 UTC (permalink / raw)
To: u-boot
Dear Matt,
In message <1345733053-5023-1-git-send-email-matt@genesi-usa.com> you wrote:
> This gives us a string like "20120822150855" which encodes the build time.
>
> This allows automated version checking and flashing of U-Boot to be performed,
> for example, in boot.scr files (or scripting in general).
I just noticed that this was never applied. Sorry...
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 1df4c1d..c042206 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
> @mkdir -p $(dir $(TIMESTAMP_FILE))
> @LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@.tmp
> @LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@.tmp
> + @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> $@.tmp
> @cmp -s $@ $@.tmp && rm -f $@.tmp || mv -f $@.tmp $@
But then - you only add a new #define to the build environment,
without any users of it, i. e. dead code.
Did you intend to post any code that would use this (in this case these
patches should be merged into one, or at least into a series), or can
we simply drop this patch?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Great teachers have small audiences while they are still alive.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition
2013-03-09 7:09 ` Wolfgang Denk
@ 2013-04-05 16:27 ` Matt Sealey
2013-04-05 16:34 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Matt Sealey @ 2013-04-05 16:27 UTC (permalink / raw)
To: u-boot
Hi Wolfgang,
On Sat, Mar 9, 2013 at 1:09 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Matt,
>
> In message <1345733053-5023-1-git-send-email-matt@genesi-usa.com> you wrote:
>> This gives us a string like "20120822150855" which encodes the build time.
>>
>> This allows automated version checking and flashing of U-Boot to be performed,
>> for example, in boot.scr files (or scripting in general).
>
> I just noticed that this was never applied. Sorry...
No problem.
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 1df4c1d..c042206 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
>> @mkdir -p $(dir $(TIMESTAMP_FILE))
>> @LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@.tmp
>> @LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@.tmp
>> + @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> $@.tmp
>> @cmp -s $@ $@.tmp && rm -f $@.tmp || mv -f $@.tmp $@
>
> But then - you only add a new #define to the build environment,
> without any users of it, i. e. dead code.
>
> Did you intend to post any code that would use this (in this case these
> patches should be merged into one, or at least into a series), or can
> we simply drop this patch?
I did intend to submit a patch; what I wanted to do was gain some
comments about it before I made
our Efika MX configuration use it, and then it moved itself to development hell.
I will submit this as a series shortly (with the configuration update)
if this patch has been dropped
already, alternatively I will just submit the configuration update and
remark that it requires this patch.
Is that okay?
--
Matt Sealey <matt@genesi-usa.com>
Product Development Analyst, Genesi USA, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition
2013-04-05 16:27 ` Matt Sealey
@ 2013-04-05 16:34 ` Wolfgang Denk
0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2013-04-05 16:34 UTC (permalink / raw)
To: u-boot
Dear Matt,
In message <CAKGA1bnoNJMYnj1qZUjrMZLvyrr0RT-S1y7-iYy=u2HebBwawQ@mail.gmail.com> you wrote:
>
> I will submit this as a series shortly (with the configuration update)
> if this patch has been dropped
> already, alternatively I will just submit the configuration update and
> remark that it requires this patch.
>
> Is that okay?
Both is fine wwith me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
(1) Do it yourself.
(2) Hire someone to do it for you.
(3) Forbid your kids to do it.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-05 16:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-23 14:44 [U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition Matt Sealey
2012-08-23 14:49 ` Stefano Babic
2012-08-23 15:01 ` Matt Sealey
2013-03-09 7:09 ` Wolfgang Denk
2013-04-05 16:27 ` Matt Sealey
2013-04-05 16:34 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox