From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite
Date: Sun, 10 Mar 2013 07:23:17 -0700 [thread overview]
Message-ID: <513C9755.3040802@boundarydevices.com> (raw)
In-Reply-To: <20130310075140.55FE4200642@gemini.denx.de>
Hi Wolfgang,
On 03/10/2013 12:51 AM, Wolfgang Denk wrote:
> Dear Fabio Estevam,
>
> In message <1362873704-23598-1-git-send-email-festevam@gmail.com> you wrote:
>>
>> Add initial support for Wandboard dual lite.
> ...
>
>> Changes since v1:
>> - Use get_ram_size
>> - Remove ARP_TIMEOUT
>> - Remove unneeded "1u"
>
> Thanks. I have still a question:
>
>> +int dram_init(void)
>> +{
>> + gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
>> +
>> + return 0;
>> +}
>
> I see this new code does not reference imx_ddr_size() any more. If
> it's so easy to switch to get_ram_size(), should we not then also
> convert the existing MX53 and MX6 boards to using get_ram_size(), and
> remove the then unneeded imx_ddr_size() code?
>
> Or would there be any drawbacks?
>
In the specific case of Nitrogen6X, we're defining different
configurations for each of the memory arrangements, so we could
skip the call to imx_ddr_size().
For that matter, we could skip the call to get_ram_size() entirely
because we're configuring each of the DDR settings very explicitly.
Since there are timing difference between the x128M and x256M
DDR chips we're using, we've split them off into separate files:
1066mhz_4x128mx16.cfg
1066mhz_4x256mx16.cfg
and defined two board configurations to select between the two.
Regards,
Eric
next prev parent reply other threads:[~2013-03-10 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 0:01 [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite Fabio Estevam
2013-03-10 7:51 ` Wolfgang Denk
2013-03-10 14:23 ` Eric Nelson [this message]
2013-03-10 15:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513C9755.3040802@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox