public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite
Date: Sun, 10 Mar 2013 16:42:14 +0100	[thread overview]
Message-ID: <20130310154214.05D582010CD@gemini.denx.de> (raw)
In-Reply-To: <513C9755.3040802@boundarydevices.com>

Dear Eric Nelson,

In message <513C9755.3040802@boundarydevices.com> you wrote:
> 
> > I see this new code does not reference imx_ddr_size() any more.  If
> > it's so easy to switch to get_ram_size(), should we not then also
> > convert the existing MX53 and MX6 boards to using get_ram_size(), and
> > remove the then unneeded imx_ddr_size() code?
> >
> > Or would there be any drawbacks?
> >
> 
> In the specific case of Nitrogen6X, we're defining different
> configurations for each of the memory arrangements, so we could
> skip the call to imx_ddr_size().

Well, that was the starting point of my questions - don;t you want to
have a single image runnign on all of your systems?  That's exactly
get_ram_size() has been made for...

> For that matter, we could skip the call to get_ram_size() entirely
> because we're configuring each of the DDR settings very explicitly.

get_ram_size() is not about configuring, but about verifying /
checking the result of such a configuration.

> Since there are timing difference between the x128M and x256M
> DDR chips we're using, we've split them off into separate files:

That's OK - but this is still no reason not to support all these
configurations in a single U-Boot image.   After all, this is exactly
how U-Boot has been designed right from the beginning.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.:  A group of men who individually can do nothing but as
a group decide that nothing can be done.                 - Fred Allen

      reply	other threads:[~2013-03-10 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  0:01 [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite Fabio Estevam
2013-03-10  7:51 ` Wolfgang Denk
2013-03-10 14:23   ` Eric Nelson
2013-03-10 15:42     ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310154214.05D582010CD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox