From: Jaehoon Chung <jh80.chung@gmail.com>
To: Stefan Roese <sr@denx.de>, u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH 2/3] mmc: mv_sdhci: Remove CONFIG_MMC_SDHCI_IO_ACCESSORS support
Date: Thu, 16 Feb 2023 16:21:19 +0900 [thread overview]
Message-ID: <51baeedc-e71f-f0da-37fb-7ad6fcd1b891@gmail.com> (raw)
In-Reply-To: <20230210122352.1214847-2-sr@denx.de>
On 2/10/23 21:23, Stefan Roese wrote:
> CONFIG_MMC_SDHCI_IO_ACCESSORS is not supported and/or used by this
> driver so let's remove these unused parts completely.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/mv_sdhci.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index 50d03b703ed7..42fa735f3160 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -42,10 +42,6 @@ static void sdhci_mvebu_mbus_config(void __iomem *base)
>
> #ifndef CONFIG_DM_MMC
>
> -#ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
> -static struct sdhci_ops mv_ops;
> -#endif /* CONFIG_MMC_SDHCI_IO_ACCESSORS */
> -
> int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks)
> {
> struct sdhci_host *host = NULL;
> @@ -59,10 +55,6 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks)
> host->ioaddr = (void *)regbase;
> host->quirks = quirks;
> host->max_clk = max_clk;
> -#ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
> - memset(&mv_ops, 0, sizeof(struct sdhci_ops));
> - host->ops = &mv_ops;
> -#endif
>
> /* Configure SDHCI MBUS mbus bridge windows */
> sdhci_mvebu_mbus_config((void __iomem *)regbase);
next prev parent reply other threads:[~2023-02-16 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230310024755epcas1p1e3b655c49596f9555add5e260e10512b@epcas1p1.samsung.com>
2023-02-10 12:23 ` [PATCH 1/3] mmc: mv_sdhci: Simplify call to sdhci_mvebu_mbus_config() Stefan Roese
2023-02-10 12:23 ` [PATCH 2/3] mmc: mv_sdhci: Remove CONFIG_MMC_SDHCI_IO_ACCESSORS support Stefan Roese
2023-02-16 7:21 ` Jaehoon Chung [this message]
2023-03-10 2:48 ` Jaehoon Chung
2023-02-10 12:23 ` [PATCH 3/3] mmc: mv_sdhci: Depend on DM_MMC Stefan Roese
2023-02-10 16:05 ` Simon Glass
2023-02-16 7:21 ` Jaehoon Chung
2023-03-10 2:48 ` Jaehoon Chung
2023-02-16 7:21 ` [PATCH 1/3] mmc: mv_sdhci: Simplify call to sdhci_mvebu_mbus_config() Jaehoon Chung
2023-03-10 2:47 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51baeedc-e71f-f0da-37fb-7ad6fcd1b891@gmail.com \
--to=jh80.chung@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox