[U-Boot] [PATCH] bcm2835_sdhci: Add SDHCI_QUIRK_NO_HISPD_BIT flag

[U-Boot] [PATCH] bcm2835_sdhci: Add SDHCI_QUIRK_NO_HISPD_BIT flag

[Lubomir Rintel]

Seems like the controller doesn't support the flag. None of the hi-speed cards
I've tried could be read, while they successfully worked with the quirk enabled.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 drivers/mmc/bcm2835_sdhci.c | 2 +-
 include/configs/rpi_b.h     | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/bcm2835_sdhci.c b/drivers/mmc/bcm2835_sdhci.c
index 54cfabf..82079d6 100644
--- a/drivers/mmc/bcm2835_sdhci.c
+++ b/drivers/mmc/bcm2835_sdhci.c
@@ -179,7 +179,7 @@ int bcm2835_sdhci_init(u32 regbase, u32 emmc_freq)
 	host->name = "bcm2835_sdhci";
 	host->ioaddr = (void *)regbase;
 	host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B |
-		SDHCI_QUIRK_WAIT_SEND_CMD;
+		SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_NO_HISPD_BIT;
 	host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	host->ops = &bcm2835_ops;
 
diff --git a/include/configs/rpi_b.h b/include/configs/rpi_b.h
index ed8b4df..1bcb798 100644
--- a/include/configs/rpi_b.h
+++ b/include/configs/rpi_b.h
@@ -225,6 +225,8 @@
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG
 
+#define CONFIG_SYS_GENERIC_BOARD
+
 #include <config_distro_defaults.h>
 
 /* Some things don't make sense on this HW or yet */
-- 
1.9.3

[U-Boot] [PATCH v2] bcm2835_sdhci: Add SDHCI_QUIRK_NO_HISPD_BIT flag

[Lubomir Rintel]

Seems like the controller doesn't support the flag. None of the hi-speed cards
I've tried could be read, while they successfully worked with the quirk enabled.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
Changes to v2:
    - I've sent the first version with extra and irrelevant hunk.
      Sorry.

 drivers/mmc/bcm2835_sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/bcm2835_sdhci.c b/drivers/mmc/bcm2835_sdhci.c
index 54cfabf..82079d6 100644
--- a/drivers/mmc/bcm2835_sdhci.c
+++ b/drivers/mmc/bcm2835_sdhci.c
@@ -179,7 +179,7 @@ int bcm2835_sdhci_init(u32 regbase, u32 emmc_freq)
 	host->name = "bcm2835_sdhci";
 	host->ioaddr = (void *)regbase;
 	host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B |
-		SDHCI_QUIRK_WAIT_SEND_CMD;
+		SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_NO_HISPD_BIT;
 	host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	host->ops = &bcm2835_ops;
 
-- 
1.9.3

[U-Boot] [PATCH v2] bcm2835_sdhci: Add SDHCI_QUIRK_NO_HISPD_BIT flag

[Stephen Warren]

On 06/10/2014 12:46 PM, Lubomir Rintel wrote:
> Seems like the controller doesn't support the flag. None of the hi-speed cards
> I've tried could be read, while they successfully worked with the quirk enabled.

Tested-by: Stephen Warren <swarren@wwwdotorg.org>
(heh, I turned on my Pi for the first time in ages!)

[U-Boot] [PATCH v2] bcm2835_sdhci: Add SDHCI_QUIRK_NO_HISPD_BIT flag

[Stephen Warren]

On 06/13/2014 10:29 PM, Stephen Warren wrote:
> On 06/10/2014 12:46 PM, Lubomir Rintel wrote:
>> Seems like the controller doesn't support the flag. None of the hi-speed cards
>> I've tried could be read, while they successfully worked with the quirk enabled.
> 
> Tested-by: Stephen Warren <swarren@wwwdotorg.org>
> (heh, I turned on my Pi for the first time in ages!)

Oh BTW, is a similar change required for the mainline kernel?

[U-Boot] [PATCH v2] bcm2835_sdhci: Add SDHCI_QUIRK_NO_HISPD_BIT flag

[Lubomir Rintel]

On Fri, 2014-06-13 at 23:39 -0600, Stephen Warren wrote:
> On 06/13/2014 10:29 PM, Stephen Warren wrote:
> > On 06/10/2014 12:46 PM, Lubomir Rintel wrote:
> >> Seems like the controller doesn't support the flag. None of the hi-speed cards
> >> I've tried could be read, while they successfully worked with the quirk enabled.
> > 
> > Tested-by: Stephen Warren <swarren@wwwdotorg.org>
> > (heh, I turned on my Pi for the first time in ages!)
> 
> Oh BTW, is a similar change required for the mainline kernel?

No. For some reason, it works flawlessly for me.