* [PATCH] i2c: mvtwsi: disable i2c slave also on Armada 8k
@ 2020-10-01 11:49 Baruch Siach
2020-11-28 15:11 ` Heiko Schocher
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2020-10-01 11:49 UTC (permalink / raw)
To: u-boot
The hidden I2C slave is also present on the Armada 8k AP806. Testing
shows that this I2C slave causes the same issues as Armada 38x.
Disabling that I2C slave fixes all these issues.
I2C blocks on the Armada 8k CP110 are not affected.
Extend the I2C slave disable to Armada 8k as well.
Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/i2c/mvtwsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c
index fdb8fd42e5c0..14c594d648ba 100644
--- a/drivers/i2c/mvtwsi.c
+++ b/drivers/i2c/mvtwsi.c
@@ -823,7 +823,8 @@ static int mvtwsi_i2c_bind(struct udevice *bus)
struct mvtwsi_registers *twsi = dev_read_addr_ptr(bus);
/* Disable the hidden slave in i2c0 of these platforms */
- if ((IS_ENABLED(CONFIG_ARMADA_38X) || IS_ENABLED(CONFIG_ARCH_KIRKWOOD))
+ if ((IS_ENABLED(CONFIG_ARMADA_38X) || IS_ENABLED(CONFIG_ARCH_KIRKWOOD)
+ || IS_ENABLED(CONFIG_ARMADA_8K))
&& bus->req_seq == 0)
twsi_disable_i2c_slave(twsi);
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] i2c: mvtwsi: disable i2c slave also on Armada 8k
2020-10-01 11:49 [PATCH] i2c: mvtwsi: disable i2c slave also on Armada 8k Baruch Siach
@ 2020-11-28 15:11 ` Heiko Schocher
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Schocher @ 2020-11-28 15:11 UTC (permalink / raw)
To: u-boot
Hello Baruch,
Am 01.10.20 um 13:49 schrieb Baruch Siach:
> The hidden I2C slave is also present on the Armada 8k AP806. Testing
> shows that this I2C slave causes the same issues as Armada 38x.
> Disabling that I2C slave fixes all these issues.
>
> I2C blocks on the Armada 8k CP110 are not affected.
>
> Extend the I2C slave disable to Armada 8k as well.
>
> Cc: Stefan Roese <sr@denx.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/i2c/mvtwsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to u-boot-i2c.git
thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-28 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-01 11:49 [PATCH] i2c: mvtwsi: disable i2c slave also on Armada 8k Baruch Siach
2020-11-28 15:11 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox