[U-Boot] [PATCH] gpio: Correct handling of 'gpio status'

[U-Boot] [PATCH] gpio: Correct handling of 'gpio status'

[Simon Glass]

This is broken - we need to look at the first two characters to distinguish
'gpio status' from 'gpio set'.

Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
Reported-by: Soeren Moch <smoch@web.de>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

 cmd/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/gpio.c b/cmd/gpio.c
index 2b78b16..693998e 100644
--- a/cmd/gpio.c
+++ b/cmd/gpio.c
@@ -141,7 +141,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 #endif
 	if (argc > 0)
 		str_gpio = *argv;
-	if (!strncmp(str_cmd, "status", 1)) {
+	if (!strncmp(str_cmd, "status", 2)) {
 		/* Support deprecated gpio_status() */
 #ifdef gpio_status
 		gpio_status();
-- 
2.7.0.rc3.207.g0ac5344

[U-Boot] [PATCH] gpio: Correct handling of 'gpio status'

[Soeren Moch]

On 15.02.2016 00:28, Simon Glass wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
> 
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Tested-by: Soeren Moch <smoch@web.de>

With this patch 'gpio set' works again.

Thanks,
Soeren

> ---
> 
>  cmd/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/gpio.c b/cmd/gpio.c
> index 2b78b16..693998e 100644
> --- a/cmd/gpio.c
> +++ b/cmd/gpio.c
> @@ -141,7 +141,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  #endif
>  	if (argc > 0)
>  		str_gpio = *argv;
> -	if (!strncmp(str_cmd, "status", 1)) {
> +	if (!strncmp(str_cmd, "status", 2)) {
>  		/* Support deprecated gpio_status() */
>  #ifdef gpio_status
>  		gpio_status();
> 

[U-Boot] [PATCH] gpio: Correct handling of 'gpio status'

[Bin Meng]

On Mon, Feb 15, 2016 at 7:28 AM, Simon Glass <sjg@chromium.org> wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
>
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  cmd/gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH] gpio: Correct handling of 'gpio status'

[Hannes Schmelzer]

On 15.02.2016 00:28, Simon Glass wrote:
> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
>
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   cmd/gpio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/gpio.c b/cmd/gpio.c
> index 2b78b16..693998e 100644
> --- a/cmd/gpio.c
> +++ b/cmd/gpio.c
> @@ -141,7 +141,7 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>   #endif
>   	if (argc > 0)
>   		str_gpio = *argv;
> -	if (!strncmp(str_cmd, "status", 1)) {
> +	if (!strncmp(str_cmd, "status", 2)) {
>   		/* Support deprecated gpio_status() */
>   #ifdef gpio_status
>   		gpio_status();
Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>

[U-Boot] gpio: Correct handling of 'gpio status'

[Tom Rini]

On Sun, Feb 14, 2016 at 04:28:59PM -0700, Simon Glass wrote:

> This is broken - we need to look at the first two characters to distinguish
> 'gpio status' from 'gpio set'.
> 
> Fixes: 0ffe6ab5 (gpio: Allow 's' as an abbreviation for 'status')
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Tested-by: Soeren Moch <smoch@web.de>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160215/2f9cb69c/attachment.sig>