[U-Boot] [PATCH] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3

[U-Boot] [PATCH] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3

[Andrew Shadura]

detect_baseboard() function doesn't depend on CONFIG_VIDEO_IPUV3.
Make sure it's available when CONFIG_VIDEO_IPUV3 is off.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
---
 board/ge/bx50v3/bx50v3.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c
index ff8f4d7..e3233a2 100644
--- a/board/ge/bx50v3/bx50v3.c
+++ b/board/ge/bx50v3/bx50v3.c
@@ -345,15 +345,6 @@ int board_cfb_skip(void)
 	return 0;
 }
 
-static int detect_baseboard(struct display_info_t const *dev)
-{
-	if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) ||
-	    IS_ENABLED(CONFIG_TARGET_GE_B650V3))
-		return 1;
-
-	return 0;
-}
-
 struct display_info_t const displays[] = {{
 	.bus	= -1,
 	.addr	= -1,
@@ -517,6 +508,15 @@ static void setup_display_bx50v3(void)
 }
 #endif /* CONFIG_VIDEO_IPUV3 */
 
+static int detect_baseboard(struct display_info_t const *dev)
+{
+	if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) ||
+	    IS_ENABLED(CONFIG_TARGET_GE_B650V3))
+		return 1;
+
+	return 0;
+}
+
 /*
  * Do not overwrite the console
  * Use always serial for U-Boot console
-- 
2.7.4

[U-Boot] [PATCH v2] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3

[Andrew Shadura]

detect_baseboard() function doesn't depend on CONFIG_VIDEO_IPUV3.
Make sure it's available when CONFIG_VIDEO_IPUV3 is off.

Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
---

The first version of the patch moved the function down below
its first use, thus making the code uncompilable when CONFIG_VIDEO_IPUV3
is enabled. This revision fixes that issue.

---
 board/ge/bx50v3/bx50v3.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c
index ff8f4d7..e167cd5 100644
--- a/board/ge/bx50v3/bx50v3.c
+++ b/board/ge/bx50v3/bx50v3.c
@@ -321,6 +321,15 @@ int board_phy_config(struct phy_device *phydev)
 	return 0;
 }
 
+static int detect_baseboard(struct display_info_t const *dev)
+{
+	if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) ||
+	    IS_ENABLED(CONFIG_TARGET_GE_B650V3))
+		return 1;
+
+	return 0;
+}
+
 #if defined(CONFIG_VIDEO_IPUV3)
 static iomux_v3_cfg_t const backlight_pads[] = {
 	/* Power for LVDS Display */
@@ -345,15 +354,6 @@ int board_cfb_skip(void)
 	return 0;
 }
 
-static int detect_baseboard(struct display_info_t const *dev)
-{
-	if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) ||
-	    IS_ENABLED(CONFIG_TARGET_GE_B650V3))
-		return 1;
-
-	return 0;
-}
-
 struct display_info_t const displays[] = {{
 	.bus	= -1,
 	.addr	= -1,
-- 
2.7.4

[U-Boot] [PATCH v2] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3

[Stefano Babic]

Hi Andrew,

On 20/05/2016 14:05, Andrew Shadura wrote:
> detect_baseboard() function doesn't depend on CONFIG_VIDEO_IPUV3.
> Make sure it's available when CONFIG_VIDEO_IPUV3 is off.
> 
> Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
> ---
> 
> The first version of the patch moved the function down below
> its first use, thus making the code uncompilable when CONFIG_VIDEO_IPUV3
> is enabled. This revision fixes that issue.
> 
> ---
>  board/ge/bx50v3/bx50v3.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c
> index ff8f4d7..e167cd5 100644
> --- a/board/ge/bx50v3/bx50v3.c
> +++ b/board/ge/bx50v3/bx50v3.c
> @@ -321,6 +321,15 @@ int board_phy_config(struct phy_device *phydev)
>  	return 0;
>  }
>  
> +static int detect_baseboard(struct display_info_t const *dev)
> +{
> +	if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) ||
> +	    IS_ENABLED(CONFIG_TARGET_GE_B650V3))
> +		return 1;
> +
> +	return 0;
> +}
> +
>  #if defined(CONFIG_VIDEO_IPUV3)
>  static iomux_v3_cfg_t const backlight_pads[] = {
>  	/* Power for LVDS Display */
> @@ -345,15 +354,6 @@ int board_cfb_skip(void)
>  	return 0;
>  }
>  
> -static int detect_baseboard(struct display_info_t const *dev)
> -{
> -	if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) ||
> -	    IS_ENABLED(CONFIG_TARGET_GE_B650V3))
> -		return 1;
> -
> -	return 0;
> -}
> -
>  struct display_info_t const displays[] = {{
>  	.bus	= -1,
>  	.addr	= -1,
> 

Fine with me - but I would like to know Martin's opinion as board
maintainer (please CC future patches to the maintainer, too).

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================