[U-Boot] [PATCH] spl: Allow settings malloc_f base address

[U-Boot] [PATCH] spl: Allow settings malloc_f base address

[Marek Vasut]

Allow configuring the begining of the malloc_f area in SPL.
This patch uses the same CONFIG_MALLOC_F_ADDR established by
the sandbox.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
 common/spl/spl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 93f9bd1..56c64d1 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -160,6 +160,9 @@ int spl_init(void)
 
 	debug("spl_init()\n");
 #if defined(CONFIG_SYS_MALLOC_F_LEN)
+#ifdef CONFIG_MALLOC_F_ADDR
+	gd->malloc_base = CONFIG_MALLOC_F_ADDR;
+#endif
 	gd->malloc_limit = CONFIG_SYS_MALLOC_F_LEN;
 	gd->malloc_ptr = 0;
 #endif
-- 
2.7.0

[U-Boot] [PATCH] spl: Allow settings malloc_f base address

[Simon Glass]

Hi Marek,

On 24 May 2016 at 18:14, Marek Vasut <marex@denx.de> wrote:
> Allow configuring the begining of the malloc_f area in SPL.
> This patch uses the same CONFIG_MALLOC_F_ADDR established by
> the sandbox.

What is this used for? Is the existing scheme (using the stack space)
not suitable? I think it should move to Kconfig before being used more
widely.

>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  common/spl/spl.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 93f9bd1..56c64d1 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -160,6 +160,9 @@ int spl_init(void)
>
>         debug("spl_init()\n");
>  #if defined(CONFIG_SYS_MALLOC_F_LEN)
> +#ifdef CONFIG_MALLOC_F_ADDR
> +       gd->malloc_base = CONFIG_MALLOC_F_ADDR;
> +#endif
>         gd->malloc_limit = CONFIG_SYS_MALLOC_F_LEN;
>         gd->malloc_ptr = 0;
>  #endif
> --
> 2.7.0
>

Regards,
Simon

[U-Boot] [PATCH] spl: Allow settings malloc_f base address

[Marek Vasut]

On 05/25/2016 05:30 AM, Simon Glass wrote:
> Hi Marek,

Hi!

> On 24 May 2016 at 18:14, Marek Vasut <marex@denx.de> wrote:
>> Allow configuring the begining of the malloc_f area in SPL.
>> This patch uses the same CONFIG_MALLOC_F_ADDR established by
>> the sandbox.
> 
> What is this used for? Is the existing scheme (using the stack space)
> not suitable? I think it should move to Kconfig before being used more
> widely.

In case your stack is waaay too constrained, then this is not suitable,
yep :(

>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>>  common/spl/spl.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/common/spl/spl.c b/common/spl/spl.c
>> index 93f9bd1..56c64d1 100644
>> --- a/common/spl/spl.c
>> +++ b/common/spl/spl.c
>> @@ -160,6 +160,9 @@ int spl_init(void)
>>
>>         debug("spl_init()\n");
>>  #if defined(CONFIG_SYS_MALLOC_F_LEN)
>> +#ifdef CONFIG_MALLOC_F_ADDR
>> +       gd->malloc_base = CONFIG_MALLOC_F_ADDR;
>> +#endif
>>         gd->malloc_limit = CONFIG_SYS_MALLOC_F_LEN;
>>         gd->malloc_ptr = 0;
>>  #endif
>> --
>> 2.7.0
>>
> 
> Regards,
> Simon
> 


-- 
Best regards,
Marek Vasut

[U-Boot] spl: Allow settings malloc_f base address

[Tom Rini]

On Wed, May 25, 2016 at 02:14:56AM +0200, Marek Vasut wrote:

> Allow configuring the begining of the malloc_f area in SPL.
> This patch uses the same CONFIG_MALLOC_F_ADDR established by
> the sandbox.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160603/dd22e5c9/attachment.sig>