public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Eibach <dirk.eibach@gdsys.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code
Date: Mon, 06 May 2013 17:02:12 +0200	[thread overview]
Message-ID: <5dd7594cf67775d4f9cd61abd6c364fb@gdsys.cc> (raw)
In-Reply-To: <20130506145722.GC6931@bill-the-cat>

Hi Tom,

> On Mon, May 06, 2013 at 04:07:15PM +0200, Wolfgang Denk wrote:
>> Dear dirk.eibach at gdsys.cc,
>> 
>> In message <1367847325-21463-5-git-send-email-dirk.eibach@gdsys.cc> 
>> you wrote:
>>> 
>> ...
>>> +			fpga_set_reg(k, REG(reflection_low),
>>> +				     REFLECTION_TESTPATTERN);
>> 
>> This breaks bisecting.  You reference functions which you only add in
>> a later patch.
> 
> Note that 'git rebase -i' and the exec keyword can help you test
> bisectability.

I know 'git rebase -i', but what is the exec keyword? It seems there is 
some room for improvement on patman :)

Cheers
Dirk

  reply	other threads:[~2013-05-06 15:02 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 13:35 [U-Boot] [PATCH v2 0/10] Update gdsys ppc4xx-based boards dirk.eibach at gdsys.cc
2013-05-06 13:35 ` [U-Boot] [PATCH v2 01/10] powerpc/ppc4xx: Add generic accessor functions for gdsys FPGA dirk.eibach at gdsys.cc
2013-05-06 14:01   ` Wolfgang Denk
2013-05-06 14:02   ` Wolfgang Denk
2013-05-06 13:35 ` [U-Boot] [PATCH v2 02/10] powerpc/ppc4xx: Add gdsys mclink interface dirk.eibach at gdsys.cc
2013-05-06 13:35 ` [U-Boot] [PATCH v2 03/10] powerpc/ppc4xx: Add fpgad command for dumping gdsys fpga registers dirk.eibach at gdsys.cc
2013-05-06 13:35 ` [U-Boot] [PATCH v2 04/10] powerpc/ppc4xx: Use generic FPGA accessors in gdsys common code dirk.eibach at gdsys.cc
2013-05-06 14:07   ` Wolfgang Denk
2013-05-06 14:57     ` Tom Rini
2013-05-06 15:02       ` Dirk Eibach [this message]
2013-05-06 15:09         ` Tom Rini
2013-05-06 15:51           ` Dirk Eibach
2013-05-06 13:35 ` [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware dirk.eibach at gdsys.cc
2013-05-06 14:12   ` Wolfgang Denk
2013-05-06 14:16     ` Dirk Eibach
2013-05-06 15:18       ` Wolfgang Denk
2013-05-06 15:49         ` Dirk Eibach
2013-05-06 19:15           ` Wolfgang Denk
2013-05-06 19:31             ` Joe Hershberger
2013-05-06 13:35 ` [U-Boot] [PATCH v2 06/10] powerpc/ppc4xx: Use generic FPGA accessors on all gdsys 405ep/ex boards dirk.eibach at gdsys.cc
2013-05-06 14:10   ` Wolfgang Denk
2013-05-06 14:50     ` Dirk Eibach
2013-05-06 15:22       ` Wolfgang Denk
2013-05-06 15:55         ` Dirk Eibach
2013-05-06 19:23           ` Wolfgang Denk
2013-05-07  8:32             ` Dirk Eibach
2013-05-07 11:36               ` Wolfgang Denk
2013-05-07 12:08                 ` Dirk Eibach
2013-05-07 19:18                   ` Wolfgang Denk
2013-05-07 20:45                     ` Dirk Eibach
2013-05-08 10:13                       ` Wolfgang Denk
2013-05-08 11:17                         ` Dirk Eibach
2013-05-08 15:37                           ` Wolfgang Denk
2013-05-15  9:23                         ` Dirk Eibach
2013-05-28  7:39                           ` Dirk Eibach
2013-05-28  7:47                           ` Dirk Eibach
2013-05-28 11:47                           ` Wolfgang Denk
2013-05-06 13:35 ` [U-Boot] [PATCH v2 07/10] powerpc/ppc4xx: Fixup phy erratum on gdsys iocon hardware dirk.eibach at gdsys.cc
2013-05-06 13:35 ` [U-Boot] [PATCH v2 08/10] powerpc/ppc4xx: Increase timeout for gdsys mclink bus startup dirk.eibach at gdsys.cc
2013-05-06 13:35 ` [U-Boot] [PATCH v2 09/10] powerpc/ppc4xx: Consider gdsys FPGA OSD size dirk.eibach at gdsys.cc
2013-05-06 13:35 ` [U-Boot] [PATCH v2 10/10] powerpc/ppc4xx: Remove CONFIG_SYS_FLASH_PROTECTION from gdsys boards dirk.eibach at gdsys.cc
2013-05-06 14:03 ` [U-Boot] [PATCH v2 0/10] Update gdsys ppc4xx-based boards Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dd7594cf67775d4f9cd61abd6c364fb@gdsys.cc \
    --to=dirk.eibach@gdsys.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox