From: Sam Edwards <cfsworks@gmail.com>
To: Marek Vasut <marex@denx.de>, u-boot@lists.denx.de
Cc: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [PATCH] usb: musb-new: sunxi: remove unused define
Date: Thu, 8 Jun 2023 12:45:59 -0600 [thread overview]
Message-ID: <61d95a47-2ae8-b0dc-7ccd-928d73dc2878@gmail.com> (raw)
In-Reply-To: <568980fb-fbda-d19f-e835-68c2ea2148bd@denx.de>
Hi Marek,
> Please add missing commit message and send V2.
Ah, apologies! I had (mistakenly) believed that the summary line would
be a sufficient commit message for something so trivial.
Instead I did a little research into how this got here and wrote a quick
explanation of why it's unused. I figure that would be a bit more
helpful for someone reading the commit history than just reiterating
that "It's, y'know, unused." :)
> Otherwise
>
> Reviewed-by: Marek Vasut <marex@denx.de>
Thank you for the speedy review!
Cheers,
Sam
prev parent reply other threads:[~2023-06-08 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 23:16 [PATCH] usb: musb-new: sunxi: remove unused define Sam Edwards
2023-06-08 4:51 ` Marek Vasut
2023-06-08 18:45 ` Sam Edwards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d95a47-2ae8-b0dc-7ccd-928d73dc2878@gmail.com \
--to=cfsworks@gmail.com \
--cc=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox