From: Sinan Akman <sinan@writeme.com>
To: j.ne@posteo.net, Mario Six <mario.six@gdsys.cc>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 3/4] powerpc: mpc83xx: Use defined constant for SPCR[TBEN]
Date: Wed, 18 Dec 2024 14:25:10 -0500 [thread overview]
Message-ID: <6756ea9e-d2e7-4228-8dd2-bf855aaa131e@writeme.com> (raw)
In-Reply-To: <20241215-mpc83xx-misc-v1-3-8cd6daae4f93@posteo.net>
On 2024-12-15 10:18, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer"<j.ne@posteo.net>
>
> To increase readability, use the defined constant instead of specifying
> SPCR[TBEN] as a number.
>
> Signed-off-by: J. Neuschäfer<j.ne@posteo.net>
> ---
> arch/powerpc/cpu/mpc83xx/interrupts.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/cpu/mpc83xx/interrupts.c b/arch/powerpc/cpu/mpc83xx/interrupts.c
> index af517213f176cf59cc82b54dbe5247800a6c40e6..bb37a1332c877951e766a8891687dae3f05b6ef8 100644
> --- a/arch/powerpc/cpu/mpc83xx/interrupts.c
> +++ b/arch/powerpc/cpu/mpc83xx/interrupts.c
> @@ -12,6 +12,7 @@
> #include <asm/global_data.h>
> #include <asm/processor.h>
> #include <asm/ptrace.h>
> +#include "initreg/initreg.h"
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -29,7 +30,7 @@ void interrupt_init_cpu (unsigned *decrementer_count)
>
> /* Enable e300 time base */
>
> - immr->sysconf.spcr |= 0x00400000;
> + immr->sysconf.spcr |= SPCR_TBEN_MASK;
> }
>
> /*
>
Reviewed-by: Sinan Akman <sinan@writeme.com>
next prev parent reply other threads:[~2024-12-18 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 15:18 [PATCH 0/4] Misc. PowerPC MPC83xx fixes/cleanups J. Neuschäfer via B4 Relay
2024-12-15 15:18 ` [PATCH 1/4] powerpc: mpc83xx: Fix timer value calculation J. Neuschäfer via B4 Relay
2024-12-18 19:24 ` Sinan Akman
2024-12-15 15:18 ` [PATCH 2/4] powerpc: mpc83xx: Allow including initreg.h into multiple files J. Neuschäfer via B4 Relay
2024-12-18 19:18 ` Sinan Akman
2024-12-19 12:55 ` J. Neuschäfer
2024-12-19 16:16 ` Sinan Akman
2024-12-15 15:18 ` [PATCH 3/4] powerpc: mpc83xx: Use defined constant for SPCR[TBEN] J. Neuschäfer via B4 Relay
2024-12-18 19:25 ` Sinan Akman [this message]
2024-12-15 15:18 ` [PATCH 4/4] gpio: mpc8xxx: Preserve pre-init state of outputs J. Neuschäfer via B4 Relay
2024-12-18 19:20 ` Sinan Akman
2024-12-19 13:06 ` J. Neuschäfer
2024-12-19 16:13 ` Sinan Akman
2024-12-15 18:03 ` [PATCH 0/4] Misc. PowerPC MPC83xx fixes/cleanups Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6756ea9e-d2e7-4228-8dd2-bf855aaa131e@writeme.com \
--to=sinan@writeme.com \
--cc=j.ne@posteo.net \
--cc=mario.six@gdsys.cc \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).