From: Sinan Akman <sinan@writeme.com>
To: j.ne@posteo.net, Mario Six <mario.six@gdsys.cc>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/4] powerpc: mpc83xx: Fix timer value calculation
Date: Wed, 18 Dec 2024 14:24:09 -0500 [thread overview]
Message-ID: <9b5879fe-878f-46ff-a141-083a8fcf3147@writeme.com> (raw)
In-Reply-To: <20241215-mpc83xx-misc-v1-1-8cd6daae4f93@posteo.net>
On 2024-12-15 10:18, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer"<j.ne@posteo.net>
>
> TBU and TBL are specified as two 32-bit registers that form a 64-bit
> value, but the calculation only shifted TBU by 16 bits.
>
> Fix this by actually shifting 32 bits.
>
> Signed-off-by: J. Neuschäfer<j.ne@posteo.net>
> ---
> drivers/timer/mpc83xx_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/timer/mpc83xx_timer.c b/drivers/timer/mpc83xx_timer.c
> index 9da74479aaa678bfab861950a770b216b604c433..f92009e4ccc8256d4c5f4d11e414dfc141f5a043 100644
> --- a/drivers/timer/mpc83xx_timer.c
> +++ b/drivers/timer/mpc83xx_timer.c
> @@ -206,7 +206,7 @@ static u64 mpc83xx_timer_get_count(struct udevice *dev)
> tbl = mftb();
> } while (tbu != mftbu());
>
> - return (tbu * 0x10000ULL) + tbl;
> + return (uint64_t)tbu << 32 | tbl;
> }
>
> static int mpc83xx_timer_probe(struct udevice *dev)
>
Reviewed-by: Sinan Akman <sinan@writeme.com>
next prev parent reply other threads:[~2024-12-18 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 15:18 [PATCH 0/4] Misc. PowerPC MPC83xx fixes/cleanups J. Neuschäfer via B4 Relay
2024-12-15 15:18 ` [PATCH 1/4] powerpc: mpc83xx: Fix timer value calculation J. Neuschäfer via B4 Relay
2024-12-18 19:24 ` Sinan Akman [this message]
2024-12-15 15:18 ` [PATCH 2/4] powerpc: mpc83xx: Allow including initreg.h into multiple files J. Neuschäfer via B4 Relay
2024-12-18 19:18 ` Sinan Akman
2024-12-19 12:55 ` J. Neuschäfer
2024-12-19 16:16 ` Sinan Akman
2024-12-15 15:18 ` [PATCH 3/4] powerpc: mpc83xx: Use defined constant for SPCR[TBEN] J. Neuschäfer via B4 Relay
2024-12-18 19:25 ` Sinan Akman
2024-12-15 15:18 ` [PATCH 4/4] gpio: mpc8xxx: Preserve pre-init state of outputs J. Neuschäfer via B4 Relay
2024-12-18 19:20 ` Sinan Akman
2024-12-19 13:06 ` J. Neuschäfer
2024-12-19 16:13 ` Sinan Akman
2024-12-15 18:03 ` [PATCH 0/4] Misc. PowerPC MPC83xx fixes/cleanups Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5879fe-878f-46ff-a141-083a8fcf3147@writeme.com \
--to=sinan@writeme.com \
--cc=j.ne@posteo.net \
--cc=mario.six@gdsys.cc \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox