Re: [PATCH 02/14] net: airoha: Add Airoha Ethernet driver

[Christian Marangi <ansuelsmth@gmail.com>]

On Wed, Apr 02, 2025 at 09:19:51AM -0600, Tom Rini wrote:
> On Wed, Apr 02, 2025 at 12:51:34AM +0200, Christian Marangi wrote:
> 
> > Add airoha Ethernet driver for Airoha AN7581 SoC. This is a majorly
> > rewritten and simplified version of the Linux airoha_eth.c driver.
> > 
> > It's has been modified to support a single RX/TX ring to reflect U-Boot
> > implementation with recv and send API.
> > 
> > The struct and the define are kept as similar as possible to upstream
> > one to not diverge too much.
> > 
> > The AN7581 SoC include an Ethernet Switch based on the Mediatek MT753x
> > but doesn't require any modification aside from setting the CPU port and
> > applying the Flood configuration hence it can be handled entirely in the
> > Ethernet driver.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> >  drivers/net/Kconfig      |    8 +
> >  drivers/net/Makefile     |    1 +
> >  drivers/net/airoha_eth.c | 1448 ++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 1457 insertions(+)
> >  create mode 100644 drivers/net/airoha_eth.c
> 
> checkpatch.pl has some macro warnings and it looks like some
> inconsistent spacing around '#define FOO' vs '#define<tab>FOO' ? And are
> all of those defines needed?
> 

No they are not all needed, I defined them for consistency with the
original driver. Should I drop them?

For the checkpatch check, also comes from the original driver.

-- 
	Ansuel