From: Marek Vasut <marek.vasut@mailbox.org>
To: Adam Ford <aford173@gmail.com>
Cc: u-boot@lists.denx.de, aford@beaconembedded.com,
festevam@gmail.com, Stefano Babic <sbabic@denx.de>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Tom Rini <trini@konsulko.com>,
Enrico Leto <enrico.leto@siemens.com>,
Heiko Schocher <hs@denx.de>, Peng Fan <peng.fan@nxp.com>,
Yannic Moog <y.moog@phytec.de>,
Sumit Garg <sumit.garg@kernel.org>,
Gilles Talis <gilles.talis@gmail.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Ye Li <ye.li@nxp.com>, Wadim Egorov <w.egorov@phytec.de>,
Christoph Stoidner <c.stoidner@phytec.de>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH V3 3/6] cpu: imx8_cpu: Print Speed grade if IMX_THERMAL or IMX_TMU
Date: Sun, 23 Mar 2025 06:08:33 +0100 [thread overview]
Message-ID: <68c9c45d-fa1e-40da-a094-038efe9afd46@mailbox.org> (raw)
In-Reply-To: <CAHCN7xJHmQqX5jF+AcAitL3hKPn=C-cZ7Bt-oCb6PX+8+483Qg@mail.gmail.com>
On 3/23/25 1:03 AM, Adam Ford wrote:
> On Sat, Mar 22, 2025 at 6:31 PM Marek Vasut <marek.vasut@mailbox.org> wrote:
>>
>> On 3/22/25 7:38 PM, Adam Ford wrote:
>>> Much of the data that is display by imx8_cpu.c is also displayed from
>>> arch/arm/mach-imx/cpu.c, except the temperature grade and active
>>> temperature are only displayed when SoC is an i.MX9. Since IMX9 now
>>> implies IMX_TMU, change this to check for IMX_THERMAL or IMX_TMU
>>> in the same way it's done in mach-imx/cpu.c to enable displaying
>>> this information for any SoC with either of these configs enabled.
>>>
>>> Before:
>>> CPU: NXP i.MX8MP Rev1.1 A53 at 1200 MHz
>>> Model: Beacon EmbeddedWorks i.MX8MPlus Development kit
>>>
>>> After:
>>> CPU: NXP i.MX8MP Rev1.1 A53 at 1200 MHz
>>> CPU: Industrial temperature grade (-40C to 105C) at 28C
>> There is an extra space after 'grade' , please fix.
>
> No problem. Should that be its own patch, or can I roll the
> whitespace change with the #ifdef change? Normally, I like to keep
> them separate, but it seems silly to me to make a patch solely for a
> 1-character whitespace change.
Either way works for me, as long as it gets fixed. Thanks !
next prev parent reply other threads:[~2025-03-23 5:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 18:38 [PATCH V3 0/6] Migrate IMX8, IMX8M and IMX9 to use imx8_cpu Adam Ford
2025-03-22 18:38 ` [PATCH V3 1/6] imx: imx9: Imply IMX_TMU Adam Ford
2025-03-22 23:29 ` Marek Vasut
2025-03-22 18:38 ` [PATCH V3 2/6] imx: imx8m: " Adam Ford
2025-03-22 23:29 ` Marek Vasut
2025-03-22 18:38 ` [PATCH V3 3/6] cpu: imx8_cpu: Print Speed grade if IMX_THERMAL or IMX_TMU Adam Ford
2025-03-22 23:30 ` Marek Vasut
2025-03-23 0:03 ` Adam Ford
2025-03-23 5:08 ` Marek Vasut [this message]
2025-03-22 18:38 ` [PATCH V3 4/6] imx: imx8m: Imply CPU_IMX by default Adam Ford
2025-03-22 23:30 ` Marek Vasut
2025-03-22 18:38 ` [PATCH V3 5/6] imx: imx8: " Adam Ford
2025-03-22 23:30 ` Marek Vasut
2025-03-23 0:00 ` Adam Ford
2025-03-23 5:09 ` Marek Vasut
2025-03-22 18:38 ` [PATCH V3 6/6] imx: imx9: " Adam Ford
2025-03-22 23:30 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68c9c45d-fa1e-40da-a094-038efe9afd46@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Zhiqiang.Hou@nxp.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=c.stoidner@phytec.de \
--cc=enrico.leto@siemens.com \
--cc=festevam@gmail.com \
--cc=gilles.talis@gmail.com \
--cc=hs@denx.de \
--cc=marcel.ziswiler@toradex.com \
--cc=michael@amarulasolutions.com \
--cc=peng.fan@nxp.com \
--cc=sbabic@denx.de \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=w.egorov@phytec.de \
--cc=y.moog@phytec.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox