From: Joel Johnson <mrjoel@lixil.net>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd
Date: Mon, 23 Mar 2020 09:38:25 -0600 [thread overview]
Message-ID: <6c98454ca6761e69687e5d4664e4c574@lixil.net> (raw)
In-Reply-To: <053ebf42-a409-95f3-5bb7-39650e192556@denx.de>
On 2020-03-23 04:27, Stefan Roese wrote:
> Hi Joel,
>
> On 22.03.20 19:53, Joel Johnson wrote:
>> As with other related ClearFog patches, I haven't received any review
>> responses on this series
>> (http://patchwork.ozlabs.org/project/uboot/list/?series=155760) and
>> would like to ping out for additional review. I'd especially like
>> feedback on the approach for support of multiple SCSI devices, if
>> there a preferred or standardized mechanism I'd be happy to adjust,
>> but I couldn't find any other examples of including multiple SCSI
>> devices in distro_boot. In reviewing again myself there was an initial
>> mental mismatch between CON2/CON3 usage as connection ports and the
>> naming of SCSI_CLEARFOG2/SCSI_CLEARFOG3 as index counters, but
>> otherwise still seems good.
>>
>> If it's in an acceptable state for inclusion in the next merge window,
>> that's certainly fine too, I'm just looking for a crosscheck.
>
> Let's see, if Baruch and/or Josua have some comments here.
>
> Thanks,
> Stefan
I have an update I'll post shortly which keeps the same logic, but
renames the defined macros to be SCSI bus centric (i.e. X_BUS0, X_BUS1,
X_BUS2) instead of potential confusion with hardware labelled port
locations.
Joel
next prev parent reply other threads:[~2020-03-23 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 3:59 [PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd Joel Johnson
2020-01-29 3:59 ` [PATCH 2/2] arm: mvebu: clearfog: support multiple SATA boot Joel Johnson
2020-03-23 10:23 ` Stefan Roese
2020-03-22 18:53 ` [PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd Joel Johnson
2020-03-23 10:27 ` Stefan Roese
2020-03-23 15:38 ` Joel Johnson [this message]
2020-03-23 10:20 ` Stefan Roese
2020-04-16 4:09 ` Joel Johnson
2020-04-16 6:13 ` Stefan Roese
2020-04-17 7:08 ` Joel Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c98454ca6761e69687e5d4664e4c574@lixil.net \
--to=mrjoel@lixil.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox