[PATCH] PCI: Add power sequencing driver for PCI slots

[PATCH] PCI: Add power sequencing driver for PCI slots

[Sean Anderson]

Extend the PCI bridge driver to enable resources associated with PCI
slots like clocks, power rails, and resets. This is modeled off of the
PCI power control subsystem in Linux. The traditional compatible for PCI
slots in U-Boot is pci-bridge, but Linux uses the more-systematic
pciclass,0604 so add that as an option.

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---

 drivers/pci/Kconfig      |  8 ++++++
 drivers/pci/pci-uclass.c | 55 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index ea9868425d0..efac18b33f6 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -100,6 +100,14 @@ config PCI_ENHANCED_ALLOCATION
 	  Enable support for Enhanced Allocation which can be used by supported
 	  devices in place of traditional BARS for allocation of resources.
 
+config PCI_PWRCTRL_SLOT
+	bool "PCI slot power control"
+	help
+	  This is a generic driver that controls the power state of different
+	  PCI slots. The clocks and resets for the PCI slots are expected to be
+	  defined in the devicetree node of the PCI bridge. Say N if your PCI
+	  busses don't have software-controlled clocks or power rails.
+
 config PCI_ARID
         bool "Enable Alternate Routing-ID support for PCI"
         help
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index c370f8c6400..c5b1ddec45a 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -6,6 +6,7 @@
 
 #define LOG_CATEGORY UCLASS_PCI
 
+#include <clk.h>
 #include <dm.h>
 #include <errno.h>
 #include <init.h>
@@ -14,6 +15,7 @@
 #include <pci.h>
 #include <spl.h>
 #include <asm/global_data.h>
+#include <asm/gpio.h>
 #include <asm/io.h>
 #include <dm/device-internal.h>
 #include <dm/lists.h>
@@ -1893,13 +1895,66 @@ static const struct dm_pci_ops pci_bridge_ops = {
 
 static const struct udevice_id pci_bridge_ids[] = {
 	{ .compatible = "pci-bridge" },
+	{ .compatible = "pciclass,0604" },
 	{ }
 };
 
+static int __maybe_unused pci_bridge_probe(struct udevice *dev)
+{
+	struct clk clk;
+	struct gpio_desc perst;
+
+	if (!clk_get_by_index(dev, 0, &clk)) {
+		int ret = clk_enable(&clk);
+
+		if (ret)
+			return log_msg_ret("clk", ret);
+
+		/* Delay for T_PERST-CLK (100 us for all slot types) */
+		udelay(100);
+	}
+
+	if (!gpio_request_by_name(dev, "reset-gpios", 0, &perst, 0)) {
+		unsigned long delay = 0;
+		int ret;
+
+		/*
+		 * If PERST is inactive, the following call to dm_gpio_clrset_flags
+		 * will be the first time we assert it and we will need to
+		 * delay for T_PERST.
+		 */
+		if (dm_gpio_get_value(&perst) != 1)
+			delay = 100;
+
+		ret = dm_gpio_clrset_flags(&perst, GPIOD_MASK_DIR,
+					   GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
+		if (ret)
+			return log_msg_ret("set", ret);
+		mdelay(delay);
+
+		ret = dm_gpio_set_value(&perst, 0);
+		if (ret)
+			return log_msg_ret("clr", ret);
+
+		/*
+		 * PCIe section 6.6.1:
+		 * > ... software must wait a minimum of 100 ms before sending a
+		 * > Configuration Request to the device immediately below that
+		 * > Port.
+		 */
+		mdelay(100);
+	}
+
+	return 0;
+}
+
 U_BOOT_DRIVER(pci_bridge_drv) = {
 	.name		= "pci_bridge_drv",
 	.id		= UCLASS_PCI,
 	.of_match	= pci_bridge_ids,
+#if CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT)
+	.probe		= pci_bridge_probe,
+#endif
 	.ops		= &pci_bridge_ops,
 };
 
-- 
2.35.1.1320.gc452695387.dirty

base-commit: 38ace442b630c5ddf049af83e8db229c012ed355
branch: pci_pwrseq

Re: [PATCH] PCI: Add power sequencing driver for PCI slots

[Marek Vasut]

On 1/6/26 11:34 PM, Sean Anderson wrote:
> Extend the PCI bridge driver to enable resources associated with PCI
> slots like clocks, power rails, and resets. This is modeled off of the
> PCI power control subsystem in Linux. The traditional compatible for PCI
> slots in U-Boot is pci-bridge, but Linux uses the more-systematic
> pciclass,0604 so add that as an option.

Oh, nice :)

> +static int __maybe_unused pci_bridge_probe(struct udevice *dev)
> +{
> +	struct clk clk;
> +	struct gpio_desc perst;
> +
> +	if (!clk_get_by_index(dev, 0, &clk)) {
> +		int ret = clk_enable(&clk);
> +
> +		if (ret)
> +			return log_msg_ret("clk", ret);

Should we use dev_err() instead ?

> +		/* Delay for T_PERST-CLK (100 us for all slot types) */
> +		udelay(100);
> +	}
> +
> +	if (!gpio_request_by_name(dev, "reset-gpios", 0, &perst, 0)) {

Invert conditional, reduce indent.

> +		unsigned long delay = 0;
> +		int ret;
> +
> +		/*
> +		 * If PERST is inactive, the following call to dm_gpio_clrset_flags
> +		 * will be the first time we assert it and we will need to
> +		 * delay for T_PERST.
> +		 */
> +		if (dm_gpio_get_value(&perst) != 1)
> +			delay = 100;
> +
> +		ret = dm_gpio_clrset_flags(&perst, GPIOD_MASK_DIR,
> +					   GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
> +		if (ret)
> +			return log_msg_ret("set", ret);
> +		mdelay(delay);

Maybe set a flag and avoid calling mdelay() altogether ?

> +		ret = dm_gpio_set_value(&perst, 0);
> +		if (ret)
> +			return log_msg_ret("clr", ret);
> +
> +		/*
> +		 * PCIe section 6.6.1:
> +		 * > ... software must wait a minimum of 100 ms before sending a
> +		 * > Configuration Request to the device immediately below that
> +		 * > Port.
> +		 */
> +		mdelay(100);
> +	}
> +
> +	return 0;
> +}
> +
>   U_BOOT_DRIVER(pci_bridge_drv) = {
>   	.name		= "pci_bridge_drv",
>   	.id		= UCLASS_PCI,
>   	.of_match	= pci_bridge_ids,
> +#if CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT)
> +	.probe		= pci_bridge_probe,

.probe = CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT, pci_bridge_probe, NULL),

Thanks !

Re: [PATCH] PCI: Add power sequencing driver for PCI slots

[Sean Anderson]

On 1/6/26 18:14, Marek Vasut wrote:
> On 1/6/26 11:34 PM, Sean Anderson wrote:
>> Extend the PCI bridge driver to enable resources associated with PCI
>> slots like clocks, power rails, and resets. This is modeled off of the
>> PCI power control subsystem in Linux. The traditional compatible for PCI
>> slots in U-Boot is pci-bridge, but Linux uses the more-systematic
>> pciclass,0604 so add that as an option.
> 
> Oh, nice :)
> 
>> +static int __maybe_unused pci_bridge_probe(struct udevice *dev)
>> +{
>> +    struct clk clk;
>> +    struct gpio_desc perst;
>> +
>> +    if (!clk_get_by_index(dev, 0, &clk)) {
>> +        int ret = clk_enable(&clk);
>> +
>> +        if (ret)
>> +            return log_msg_ret("clk", ret);
> 
> Should we use dev_err() instead ?

I thought we weren't supposed to log by default in device drivers to reduce text size?

>> +        /* Delay for T_PERST-CLK (100 us for all slot types) */
>> +        udelay(100);
>> +    }
>> +
>> +    if (!gpio_request_by_name(dev, "reset-gpios", 0, &perst, 0)) {
> 
> Invert conditional, reduce indent.

OK

>> +        unsigned long delay = 0;
>> +        int ret;
>> +
>> +        /*
>> +         * If PERST is inactive, the following call to dm_gpio_clrset_flags
>> +         * will be the first time we assert it and we will need to
>> +         * delay for T_PERST.
>> +         */
>> +        if (dm_gpio_get_value(&perst) != 1)
>> +            delay = 100;
>> +
>> +        ret = dm_gpio_clrset_flags(&perst, GPIOD_MASK_DIR,
>> +                       GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
>> +        if (ret)
>> +            return log_msg_ret("set", ret);
>> +        mdelay(delay);
> 
> Maybe set a flag and avoid calling mdelay() altogether ?

OK

--Sean

>> +        ret = dm_gpio_set_value(&perst, 0);
>> +        if (ret)
>> +            return log_msg_ret("clr", ret);
>> +
>> +        /*
>> +         * PCIe section 6.6.1:
>> +         * > ... software must wait a minimum of 100 ms before sending a
>> +         * > Configuration Request to the device immediately below that
>> +         * > Port.
>> +         */
>> +        mdelay(100);
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>>   U_BOOT_DRIVER(pci_bridge_drv) = {
>>       .name        = "pci_bridge_drv",
>>       .id        = UCLASS_PCI,
>>       .of_match    = pci_bridge_ids,
>> +#if CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT)
>> +    .probe        = pci_bridge_probe,
> 
> .probe = CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT, pci_bridge_probe, NULL),
> 
> Thanks !

Re: [PATCH] PCI: Add power sequencing driver for PCI slots

[Marek Vasut]

On 1/7/26 12:32 AM, Sean Anderson wrote:
> On 1/6/26 18:14, Marek Vasut wrote:
>> On 1/6/26 11:34 PM, Sean Anderson wrote:
>>> Extend the PCI bridge driver to enable resources associated with PCI
>>> slots like clocks, power rails, and resets. This is modeled off of the
>>> PCI power control subsystem in Linux. The traditional compatible for PCI
>>> slots in U-Boot is pci-bridge, but Linux uses the more-systematic
>>> pciclass,0604 so add that as an option.
>>
>> Oh, nice :)
>>
>>> +static int __maybe_unused pci_bridge_probe(struct udevice *dev)
>>> +{
>>> +    struct clk clk;
>>> +    struct gpio_desc perst;
>>> +
>>> +    if (!clk_get_by_index(dev, 0, &clk)) {
>>> +        int ret = clk_enable(&clk);
>>> +
>>> +        if (ret)
>>> +            return log_msg_ret("clk", ret);
>>
>> Should we use dev_err() instead ?
> 
> I thought we weren't supposed to log by default in device drivers to reduce text size?
Tom had a different take on it, lets wait for him. Me personally, I like 
the dev_* functions as they are compatible with Linux ones, which is 
nice and non-confusing.

Re: [PATCH] PCI: Add power sequencing driver for PCI slots

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

On Wed, Jan 07, 2026 at 01:03:04AM +0100, Marek Vasut wrote:
> On 1/7/26 12:32 AM, Sean Anderson wrote:
> > On 1/6/26 18:14, Marek Vasut wrote:
> > > On 1/6/26 11:34 PM, Sean Anderson wrote:
> > > > Extend the PCI bridge driver to enable resources associated with PCI
> > > > slots like clocks, power rails, and resets. This is modeled off of the
> > > > PCI power control subsystem in Linux. The traditional compatible for PCI
> > > > slots in U-Boot is pci-bridge, but Linux uses the more-systematic
> > > > pciclass,0604 so add that as an option.
> > > 
> > > Oh, nice :)
> > > 
> > > > +static int __maybe_unused pci_bridge_probe(struct udevice *dev)
> > > > +{
> > > > +    struct clk clk;
> > > > +    struct gpio_desc perst;
> > > > +
> > > > +    if (!clk_get_by_index(dev, 0, &clk)) {
> > > > +        int ret = clk_enable(&clk);
> > > > +
> > > > +        if (ret)
> > > > +            return log_msg_ret("clk", ret);
> > > 
> > > Should we use dev_err() instead ?
> > 
> > I thought we weren't supposed to log by default in device drivers to reduce text size?
> Tom had a different take on it, lets wait for him. Me personally, I like the
> dev_* functions as they are compatible with Linux ones, which is nice and
> non-confusing.

I think consistency within a file is the first thing to worry about, and
so log_msg_ret(...) to match the rest of the file makes the most sense.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] PCI: Add power sequencing driver for PCI slots

[Peter Robinson]

Hi Sean,

> Extend the PCI bridge driver to enable resources associated with PCI
> slots like clocks, power rails, and resets. This is modeled off of the
> PCI power control subsystem in Linux. The traditional compatible for PCI
> slots in U-Boot is pci-bridge, but Linux uses the more-systematic
> pciclass,0604 so add that as an option.

Not sure if you're aware but upstream is doing a big rework of the
pwctrl stuff[1], I'm not sure if this would need to be adjusted to
take any of those changes into account but might be worth considering
reviewing the issues being addressed by that rework too.

Peter

[1] https://lore.kernel.org/linux-pci/20260105-pci-pwrctrl-rework-v4-0-6d41a7a49789@oss.qualcomm.com/T/#t

> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
>
>  drivers/pci/Kconfig      |  8 ++++++
>  drivers/pci/pci-uclass.c | 55 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 63 insertions(+)
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index ea9868425d0..efac18b33f6 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -100,6 +100,14 @@ config PCI_ENHANCED_ALLOCATION
>           Enable support for Enhanced Allocation which can be used by supported
>           devices in place of traditional BARS for allocation of resources.
>
> +config PCI_PWRCTRL_SLOT
> +       bool "PCI slot power control"
> +       help
> +         This is a generic driver that controls the power state of different
> +         PCI slots. The clocks and resets for the PCI slots are expected to be
> +         defined in the devicetree node of the PCI bridge. Say N if your PCI
> +         busses don't have software-controlled clocks or power rails.
> +
>  config PCI_ARID
>          bool "Enable Alternate Routing-ID support for PCI"
>          help
> diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
> index c370f8c6400..c5b1ddec45a 100644
> --- a/drivers/pci/pci-uclass.c
> +++ b/drivers/pci/pci-uclass.c
> @@ -6,6 +6,7 @@
>
>  #define LOG_CATEGORY UCLASS_PCI
>
> +#include <clk.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <init.h>
> @@ -14,6 +15,7 @@
>  #include <pci.h>
>  #include <spl.h>
>  #include <asm/global_data.h>
> +#include <asm/gpio.h>
>  #include <asm/io.h>
>  #include <dm/device-internal.h>
>  #include <dm/lists.h>
> @@ -1893,13 +1895,66 @@ static const struct dm_pci_ops pci_bridge_ops = {
>
>  static const struct udevice_id pci_bridge_ids[] = {
>         { .compatible = "pci-bridge" },
> +       { .compatible = "pciclass,0604" },
>         { }
>  };
>
> +static int __maybe_unused pci_bridge_probe(struct udevice *dev)
> +{
> +       struct clk clk;
> +       struct gpio_desc perst;
> +
> +       if (!clk_get_by_index(dev, 0, &clk)) {
> +               int ret = clk_enable(&clk);
> +
> +               if (ret)
> +                       return log_msg_ret("clk", ret);
> +
> +               /* Delay for T_PERST-CLK (100 us for all slot types) */
> +               udelay(100);
> +       }
> +
> +       if (!gpio_request_by_name(dev, "reset-gpios", 0, &perst, 0)) {
> +               unsigned long delay = 0;
> +               int ret;
> +
> +               /*
> +                * If PERST is inactive, the following call to dm_gpio_clrset_flags
> +                * will be the first time we assert it and we will need to
> +                * delay for T_PERST.
> +                */
> +               if (dm_gpio_get_value(&perst) != 1)
> +                       delay = 100;
> +
> +               ret = dm_gpio_clrset_flags(&perst, GPIOD_MASK_DIR,
> +                                          GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
> +               if (ret)
> +                       return log_msg_ret("set", ret);
> +               mdelay(delay);
> +
> +               ret = dm_gpio_set_value(&perst, 0);
> +               if (ret)
> +                       return log_msg_ret("clr", ret);
> +
> +               /*
> +                * PCIe section 6.6.1:
> +                * > ... software must wait a minimum of 100 ms before sending a
> +                * > Configuration Request to the device immediately below that
> +                * > Port.
> +                */
> +               mdelay(100);
> +       }
> +
> +       return 0;
> +}
> +
>  U_BOOT_DRIVER(pci_bridge_drv) = {
>         .name           = "pci_bridge_drv",
>         .id             = UCLASS_PCI,
>         .of_match       = pci_bridge_ids,
> +#if CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT)
> +       .probe          = pci_bridge_probe,
> +#endif
>         .ops            = &pci_bridge_ops,
>  };
>
> --
> 2.35.1.1320.gc452695387.dirty
>
> base-commit: 38ace442b630c5ddf049af83e8db229c012ed355
> branch: pci_pwrseq

Re: [PATCH] PCI: Add power sequencing driver for PCI slots

[Sean Anderson]

On 1/7/26 23:07, Peter Robinson wrote:
> Hi Sean,
> 
>> Extend the PCI bridge driver to enable resources associated with PCI
>> slots like clocks, power rails, and resets. This is modeled off of the
>> PCI power control subsystem in Linux. The traditional compatible for PCI
>> slots in U-Boot is pci-bridge, but Linux uses the more-systematic
>> pciclass,0604 so add that as an option.
> 
> Not sure if you're aware but upstream is doing a big rework of the
> pwctrl stuff[1], I'm not sure if this would need to be adjusted to
> take any of those changes into account but might be worth considering
> reviewing the issues being addressed by that rework too.

Yes, I saw that (and commented on v2 [1]). But the devicetree stuff is
the same, and we can use a much simpler model in U-Boot because device
probing is synchronous. That series is also not merged yet.

--Sean

[1] https://lore.kernel.org/linux-pci/39e025bd-50f4-407d-8fd4-e254dbed46b2@linux.dev/

> 
> [1] https://lore.kernel.org/linux-pci/20260105-pci-pwrctrl-rework-v4-0-6d41a7a49789@oss.qualcomm.com/T/#t
> 
>> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
>> ---
>>
>>  drivers/pci/Kconfig      |  8 ++++++
>>  drivers/pci/pci-uclass.c | 55 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 63 insertions(+)
>>
>> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
>> index ea9868425d0..efac18b33f6 100644
>> --- a/drivers/pci/Kconfig
>> +++ b/drivers/pci/Kconfig
>> @@ -100,6 +100,14 @@ config PCI_ENHANCED_ALLOCATION
>>           Enable support for Enhanced Allocation which can be used by supported
>>           devices in place of traditional BARS for allocation of resources.
>>
>> +config PCI_PWRCTRL_SLOT
>> +       bool "PCI slot power control"
>> +       help
>> +         This is a generic driver that controls the power state of different
>> +         PCI slots. The clocks and resets for the PCI slots are expected to be
>> +         defined in the devicetree node of the PCI bridge. Say N if your PCI
>> +         busses don't have software-controlled clocks or power rails.
>> +
>>  config PCI_ARID
>>          bool "Enable Alternate Routing-ID support for PCI"
>>          help
>> diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
>> index c370f8c6400..c5b1ddec45a 100644
>> --- a/drivers/pci/pci-uclass.c
>> +++ b/drivers/pci/pci-uclass.c
>> @@ -6,6 +6,7 @@
>>
>>  #define LOG_CATEGORY UCLASS_PCI
>>
>> +#include <clk.h>
>>  #include <dm.h>
>>  #include <errno.h>
>>  #include <init.h>
>> @@ -14,6 +15,7 @@
>>  #include <pci.h>
>>  #include <spl.h>
>>  #include <asm/global_data.h>
>> +#include <asm/gpio.h>
>>  #include <asm/io.h>
>>  #include <dm/device-internal.h>
>>  #include <dm/lists.h>
>> @@ -1893,13 +1895,66 @@ static const struct dm_pci_ops pci_bridge_ops = {
>>
>>  static const struct udevice_id pci_bridge_ids[] = {
>>         { .compatible = "pci-bridge" },
>> +       { .compatible = "pciclass,0604" },
>>         { }
>>  };
>>
>> +static int __maybe_unused pci_bridge_probe(struct udevice *dev)
>> +{
>> +       struct clk clk;
>> +       struct gpio_desc perst;
>> +
>> +       if (!clk_get_by_index(dev, 0, &clk)) {
>> +               int ret = clk_enable(&clk);
>> +
>> +               if (ret)
>> +                       return log_msg_ret("clk", ret);
>> +
>> +               /* Delay for T_PERST-CLK (100 us for all slot types) */
>> +               udelay(100);
>> +       }
>> +
>> +       if (!gpio_request_by_name(dev, "reset-gpios", 0, &perst, 0)) {
>> +               unsigned long delay = 0;
>> +               int ret;
>> +
>> +               /*
>> +                * If PERST is inactive, the following call to dm_gpio_clrset_flags
>> +                * will be the first time we assert it and we will need to
>> +                * delay for T_PERST.
>> +                */
>> +               if (dm_gpio_get_value(&perst) != 1)
>> +                       delay = 100;
>> +
>> +               ret = dm_gpio_clrset_flags(&perst, GPIOD_MASK_DIR,
>> +                                          GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
>> +               if (ret)
>> +                       return log_msg_ret("set", ret);
>> +               mdelay(delay);
>> +
>> +               ret = dm_gpio_set_value(&perst, 0);
>> +               if (ret)
>> +                       return log_msg_ret("clr", ret);
>> +
>> +               /*
>> +                * PCIe section 6.6.1:
>> +                * > ... software must wait a minimum of 100 ms before sending a
>> +                * > Configuration Request to the device immediately below that
>> +                * > Port.
>> +                */
>> +               mdelay(100);
>> +       }
>> +
>> +       return 0;
>> +}
>> +
>>  U_BOOT_DRIVER(pci_bridge_drv) = {
>>         .name           = "pci_bridge_drv",
>>         .id             = UCLASS_PCI,
>>         .of_match       = pci_bridge_ids,
>> +#if CONFIG_IS_ENABLED(PCI_PWRCTRL_SLOT)
>> +       .probe          = pci_bridge_probe,
>> +#endif
>>         .ops            = &pci_bridge_ops,
>>  };
>>
>> --
>> 2.35.1.1320.gc452695387.dirty
>>
>> base-commit: 38ace442b630c5ddf049af83e8db229c012ed355
>> branch: pci_pwrseq