public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jason Rush <jarush@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] SoCFPGA PL330 DMA driver and ECC scrubbing
Date: Fri, 29 Jun 2018 09:31:50 -0500	[thread overview]
Message-ID: <73d4ce24-2b78-d27c-1dbf-ebef00e9689b@gmail.com> (raw)

Dinh,

A while ago, you posted the following patchset for SoCFPGA to add the PL330
DMA driver, and updated the SoCFPGA SDRAM init to write zeros to SDRAM to
initialize the ECC bits if ECC was enabled:

https://lists.denx.de/pipermail/u-boot/2016-October/269643.html

I know it's been a long time, so I'll summarize some of the conversation...

At the time, you had a problem with the patchset causing the SPL to fail to
find the MMC.  You had tracked it down to an issue with the following commit
"a78cd8613204 ARM: Rework and correct barrier definitions".  You and Marek
discussed it a bit, but I don't think there was a real conclusion.  You
submitted a second version of the patchset asking for advice on debugging
the issue:

https://lists.denx.de/pipermail/u-boot/2016-December/275822.html

No real conversation came from the second patchset, and that was the end of
the patch.

I was hoping we could revisit adding your patchset again. I am working on a
custom SoCFPGA board with a Cyclone V and ECC SDRAM. I rebased your patchset
against v2018.05 and it is working on my custom board (although I don't have
an MMC). I also tested it on a SoCKit booting from an MMC (I forced it to
scrub the SDRAM on the SoCKit, because it doesn't have ECC RAM), and the
SoCKit finds the MMC and boots.

I don't have any suggestions on why it is working now on my board and not
back when you first submitted the patchset.  Maybe something else was fixed
in the MMC? I was hoping you and Marek could test this patch again on some
different SoCFPGA boards to see if you get the same results.

Regards,
Jason

             reply	other threads:[~2018-06-29 14:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 14:31 Jason Rush [this message]
2018-06-29 14:34 ` [U-Boot] SoCFPGA PL330 DMA driver and ECC scrubbing Marek Vasut
2018-06-29 14:44   ` Jason Rush
2018-06-29 14:52     ` Marek Vasut
2018-06-29 15:06       ` Jason Rush
2018-06-29 15:17         ` Marek Vasut
2018-07-03 13:58           ` Jason Rush
2018-07-03 14:08             ` Marek Vasut
2018-07-03 23:45               ` Jason Rush
2018-07-04  7:23                 ` Marek Vasut
2018-07-05 23:11                   ` Jason Rush
2018-07-05 23:10                     ` Marek Vasut
2018-07-05 23:28                       ` Jason Rush
2018-07-06 22:56                       ` Jason Rush
2018-07-09  8:08                         ` Marek Vasut
2018-07-10 12:10                           ` Jason Rush
2018-07-10 16:11                             ` Marek Vasut
2018-07-11  3:11                               ` Jason Rush
2018-07-11  8:55                                 ` Marek Vasut
2018-07-11 13:49                                   ` Jason Rush
2018-07-11 13:48                                     ` Marek Vasut
2018-07-11 13:56                                       ` Jason Rush
2018-07-11 14:05                                         ` Marek Vasut
2018-07-11 17:30                                         ` Trent Piepho
2018-07-11 18:54                                           ` Marek Vasut
2018-07-13 12:50                                             ` Jason Rush
2018-07-13 14:54                                               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d4ce24-2b78-d27c-1dbf-ebef00e9689b@gmail.com \
    --to=jarush@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox