public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Mavrodiev <stefan.mavrodiev@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/2] Enable test case with A20-OLinuXino-Lime2
Date: Thu, 8 Feb 2018 08:24:37 +0200	[thread overview]
Message-ID: <7481f265-428c-d569-ef9a-d743d6358595@gmail.com> (raw)
In-Reply-To: <20180207171913.uob6sosp6psqbloc@flea>

On 02/07/2018 07:19 PM, Maxime Ripard wrote:
> On Wed, Feb 07, 2018 at 12:55:54PM +0530, Jagan Teki wrote:
>>>>>>> +&spi0 {
>>>>>>> +       pinctrl-names = "default";
>>>>>>> +       pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>;
>>>>>>> +       status = "okay";
>>>>>>> +
>>>>>>> +       flash: w25q128 at 0 {
>>>>>> Was it sync from Linux?
>>>>> No, this isn't in the linux dts.
>>>> But we have to, please send it to Linux first.
>>> We've already commented this issue. In the v2 [1], I've explained that this
>>> won't go mainline, since it's optional feature. Rather it will be managed
>>> with overlays.
>> Thought this was already in ML, and ready to merge. So this never go
>> to Linux tree since it's optional? then add u-boot.dtsi for this
>> atleast since we always sync dts from Linux.
> This is an optional feature on that board. We should be making it as
> easy as possible to enable it, but a defconfig is a *default*
> configuration, and if the board doesn't have it by default, it
> shouldn't be enabled in the defconfig.
>
> Maxime
>
Sorry, but I'm really confused. In the first patch Jagan said to make 
separate patch
"just to test" the driver. Then I've made patch "just to test", and it's 
turn out it wasn't not OK,
because it should be compatible with linux, u-boot and etc. What's the 
point since it's just for testing...?

Sorry again, but can someone explain to me, that to do?
I'm not trying to pick on you guys. Just want to do the right thing.

Best regards,
Stefan Mavrodiev

  reply	other threads:[~2018-02-08  6:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 13:14 [U-Boot] [PATCH v4 1/2] arm: sunxi: Allwinner A10 SPI driver Stefan Mavrodiev
2018-02-06 13:14 ` [U-Boot] [PATCH v4 2/2] Enable test case with A20-OLinuXino-Lime2 Stefan Mavrodiev
2018-02-06 16:48   ` Jagan Teki
2018-02-07  6:30     ` Stefan Mavrodiev
2018-02-07  6:39       ` Jagan Teki
2018-02-07  7:05         ` Stefan Mavrodiev
2018-02-07  7:25           ` Jagan Teki
2018-02-07  9:24             ` Stefan Mavrodiev
2018-02-07  9:47               ` Jagan Teki
2018-02-07 17:19             ` Maxime Ripard
2018-02-08  6:24               ` Stefan Mavrodiev [this message]
2018-02-08  7:03                 ` Jagan Teki
2018-02-08  8:16                   ` Stefan Mavrodiev
2018-02-08  9:08                   ` Maxime Ripard
2018-02-08  9:06                 ` Maxime Ripard
2018-02-15 11:36 ` [U-Boot] [PATCH v4 1/2] arm: sunxi: Allwinner A10 SPI driver Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7481f265-428c-d569-ef9a-d743d6358595@gmail.com \
    --to=stefan.mavrodiev@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox