public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eugen.Hristev at microchip.com <Eugen.Hristev@microchip.com>
To: u-boot@lists.denx.de
Subject: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi
Date: Thu, 7 May 2020 10:19:14 +0000	[thread overview]
Message-ID: <7aa43973-c718-08e0-238b-0697eea8392c@microchip.com> (raw)
In-Reply-To: <MWHPR0801MB3819D4F74166F26568FC68A0ACA50@MWHPR0801MB3819.namprd08.prod.outlook.com>

On 07.05.2020 12:21, Tiaki Rice wrote:

> Hello Eugen,
> 
> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction.
> 
> What I did:
> - Made the changes on master and locally commited them
> - Created a patch using  'git format-patch' and modified the patch file email body.
> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and Cc'd you
> 
> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas?
> 

Hi Tiaki,

 From my perspective you did everything very well. The patch looks sent 
fine. I would only have one question, did you check your patch with the 
built-in perl script that automatically checks your patch for formatting ?
./scripts/checkpatch.pl --strict <your patch file>

About patchwork, I think it may be an issue with patchwork.

Eugen


> 
> Thanks in advance,
> 
> Tiaki Rice
> 
> -----Original Message-----
> From: Eugen.Hristev at microchip.com <Eugen.Hristev@microchip.com>
> Sent: Thursday, 7 May 2020 7:12 PM
> To: tiakirice at hotmail.com; u-boot at lists.denx.de
> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi
> 
> On 07.05.2020 07:43, Tiaki Rice wrote:
>> This patch adds support for uart4 to the processor level device tree include file.
>>
>>
>> Signed-off-by: Tiaki Rice <tiakirice@hotmail.com>
>> Cc: Eugen Hristev <Eugen.Hristev@microchip.com>
>> ---
> 
> Hi,
> 
> Thanks for contributing !
> 
> I have an issue with this patch missing from patchwork.
> Anyone has any idea why that happened ?
> 
> Eugen
> 
>>    arch/arm/dts/sama5d2.dtsi | 8 ++++++++
>>    1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
>> index 5adc47b906..6fb2cb25f9 100644
>> --- a/arch/arm/dts/sama5d2.dtsi
>> +++ b/arch/arm/dts/sama5d2.dtsi
>> @@ -746,6 +746,14 @@
>>    status = "disabled";
>>    };
>>
>> +uart4: serial at fc00c000 {
>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>;
>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled"; };
>> +
>>    i2c1: i2c at fc028000 {
>>    compatible = "atmel,sama5d2-i2c";
>>    reg = <0xfc028000 0x100>;
>> --
>> 2.22.0.windows.1
>>
> 

  parent reply	other threads:[~2020-05-07 10:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07  4:43 [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi Tiaki Rice
2020-05-07  9:11 ` Eugen.Hristev at microchip.com
     [not found]   ` <MWHPR0801MB3819D4F74166F26568FC68A0ACA50@MWHPR0801MB3819.namprd08.prod.outlook.com>
2020-05-07 10:19     ` Eugen.Hristev at microchip.com [this message]
2020-05-07 11:32       ` Tiaki Rice
2020-05-07 11:54         ` Eugen.Hristev at microchip.com
2020-05-07 14:23           ` Tiaki Rice
2020-05-07 14:34             ` Eugen.Hristev at microchip.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7aa43973-c718-08e0-238b-0697eea8392c@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox