U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Xavier Drudis Ferran <xdrudis@tinet.cat>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
	Lukasz Majewski <lukma@denx.de>,
	Sean Anderson <seanga2@gmail.com>
Subject: Re: [SPAM] Re: [PATCH] cmd: usb: Prevent reset in usb tree/info command
Date: Tue, 20 Jun 2023 11:13:41 +0200	[thread overview]
Message-ID: <7eaf7fcf-9869-dd87-e60b-f0e4fc536220@denx.de> (raw)
In-Reply-To: <ZJFPMxrtUXR9wydy@xdrudis.tinet.cat>

On 6/20/23 09:03, Xavier Drudis Ferran wrote:
> El Tue, Jun 20, 2023 at 02:50:48AM +0200, Marek Vasut deia:
>> On 6/13/23 08:52, Xavier Drudis Ferran wrote:
>>>
>>> U-Boot TPL 2023.07-rc2-00144-g497967f1ee (Jun 12 2023 - 11:15:47)
>>
>> Next is already at rc4 , what's this rc2 ?
> 
> It's a test I did last week (June 12th). What do you think has changed
> in next between rc2 and rc4 so that this shouldn't happen now ?

The beginning of the email states:

"
Ok. New test.

This uses yesterday morning's   next   branch.
commit 5b589e139620214f
"

So, that is not the case ?

Also, commit 497967f1ee does not exist in upstream U-Boot, was this some 
patched U-Boot tree ?

> My last patch (sent yesterday) was tested with the next branch as of
> yesterday morning. But you can test it yourself with any version you like.
> Do I have to send the logs of each test I do to the list every time ?

Ideally the claims you make about what you tested and logs from the test 
should match, that would be a good starting point.

> I thought Simon Glass reply last week to the mail you quoted already
> showed agreement that the issue exists, and the adding of the
> UCLASS_BOOTDEV device is per design, so cmd/usb.c needs fixing to deal
> with this change.

I am not disputing that. What bothers me is the still missing consistent 
test case, esp. if this is a fix which should be added this late in release.

  reply	other threads:[~2023-06-20  9:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 15:20 [PATCH] cmd: usb: Prevent reset in usb tree/info command Xavier Drudis Ferran
2023-06-07 22:05 ` Marek Vasut
2023-06-08  7:39   ` Xavier Drudis Ferran
2023-06-09  1:20     ` Marek Vasut
     [not found]       ` <ZILsTOaXliizQjiH@xdrudis.tinet.cat>
2023-06-09 18:52         ` [SPAM] " Xavier Drudis Ferran
2023-06-11 12:29           ` Marek Vasut
2023-06-12 21:17             ` Simon Glass
2023-06-13  6:42               ` Xavier Drudis Ferran
2023-06-13  6:52             ` Xavier Drudis Ferran
2023-06-13 14:58               ` Simon Glass
2023-06-13 16:04                 ` Xavier Drudis Ferran
2023-06-13 20:12                   ` Simon Glass
2023-06-14  8:40                     ` Xavier Drudis Ferran
2023-06-20 10:03                       ` Simon Glass
2023-06-20 11:20                         ` Xavier Drudis Ferran
2023-06-20 14:36                           ` Simon Glass
2023-06-20  0:50               ` Marek Vasut
2023-06-20  7:03                 ` Xavier Drudis Ferran
2023-06-20  9:13                   ` Marek Vasut [this message]
     [not found] <ZJAqKxrO7qa8r6Kq@xdrudis.tinet.cat>
2023-06-19 21:49 ` Marek Vasut
2023-06-20  9:17   ` Xavier Drudis Ferran
2023-06-20  9:49     ` Marek Vasut
2023-06-20 10:43       ` [SPAM] " Xavier Drudis Ferran
2023-06-20 23:08         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eaf7fcf-9869-dd87-e60b-f0e4fc536220@denx.de \
    --to=marex@denx.de \
    --cc=lukma@denx.de \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=xdrudis@tinet.cat \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox