From: Xavier Drudis Ferran <xdrudis@tinet.cat>
To: Simon Glass <sjg@chromium.org>
Cc: Xavier Drudis Ferran <xdrudis@tinet.cat>,
Marek Vasut <marex@denx.de>,
u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>
Subject: Re: [SPAM] Re: [PATCH] cmd: usb: Prevent reset in usb tree/info command
Date: Tue, 13 Jun 2023 18:04:02 +0200 [thread overview]
Message-ID: <ZIiTcg8tPrAxM0vX@xdrudis.tinet.cat> (raw)
In-Reply-To: <CAPnjgZ0p1ZhrrO8G21c0ZPBezaaqEiYmXPO_kycmo00kji1qJw@mail.gmail.com>
El Tue, Jun 13, 2023 at 03:58:22PM +0100, Simon Glass deia:
>
> Yes that's right. So 'usb info' should ignore UCLASS_BOOTDEV devices.
That's a possibility, yes. It should work until someone adds another
device there for some other purpose.
> That is better than checking for the NULL pointer.
>
Why? What's wrong about checking for null ?
Or maybe checking for both not null and not UCLASS_BOOTDEV ?
Not that I care too much, just to understand your reasoning.
Or can we check for recursible devices somehow ?
Maybe flag them or something ?
Why is better to state all devices are recursible except some UCLASSes
(meaning they can have stuff that needs listed in usb info - or
likewise usb tree -) instead of stating that some closed set are
recursible ?
next prev parent reply other threads:[~2023-06-13 16:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 15:20 [PATCH] cmd: usb: Prevent reset in usb tree/info command Xavier Drudis Ferran
2023-06-07 22:05 ` Marek Vasut
2023-06-08 7:39 ` Xavier Drudis Ferran
2023-06-09 1:20 ` Marek Vasut
[not found] ` <ZILsTOaXliizQjiH@xdrudis.tinet.cat>
2023-06-09 18:52 ` [SPAM] " Xavier Drudis Ferran
2023-06-11 12:29 ` Marek Vasut
2023-06-12 21:17 ` Simon Glass
2023-06-13 6:42 ` Xavier Drudis Ferran
2023-06-13 6:52 ` Xavier Drudis Ferran
2023-06-13 14:58 ` Simon Glass
2023-06-13 16:04 ` Xavier Drudis Ferran [this message]
2023-06-13 20:12 ` Simon Glass
2023-06-14 8:40 ` Xavier Drudis Ferran
2023-06-20 10:03 ` Simon Glass
2023-06-20 11:20 ` Xavier Drudis Ferran
2023-06-20 14:36 ` Simon Glass
2023-06-20 0:50 ` Marek Vasut
2023-06-20 7:03 ` Xavier Drudis Ferran
2023-06-20 9:13 ` Marek Vasut
[not found] <ZJAqKxrO7qa8r6Kq@xdrudis.tinet.cat>
2023-06-19 21:49 ` Marek Vasut
2023-06-20 9:17 ` Xavier Drudis Ferran
2023-06-20 9:49 ` Marek Vasut
2023-06-20 10:43 ` [SPAM] " Xavier Drudis Ferran
2023-06-20 23:08 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIiTcg8tPrAxM0vX@xdrudis.tinet.cat \
--to=xdrudis@tinet.cat \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox