public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Uri Mashiach <uri.mashiach@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] arm: am57xx: cl-som-am57x: fix XHCI registers base address
Date: Sun, 12 Feb 2017 10:55:27 +0200	[thread overview]
Message-ID: <80f3027a-c19a-3c23-e300-d72590fecbdf@compulab.co.il> (raw)
In-Reply-To: <20170209202952.GI26129@bill-the-cat>

Hi Tom,

On 02/09/2017 10:29 PM, Tom Rini wrote:
> On Thu, Feb 09, 2017 at 09:00:26AM +0200, Uri Mashiach wrote:
>
>> The following XHCI registers base address are set to OMAP5 values:
>> OMAP_XHCI_BASE, OMAP_OCP1_SCP_BASE, OMAP_OTG_WRAPPER_BASE
>>
>> Captured crash for "usb start" command:
>> ----------------------------------cut----------------------------------
>> => usb start
>> starting USB...
>> USB0:   data abort
>> pc : [<fff63d22>]          lr : [<fff63b63>]
>> reloc pc : [<8081cd22>]    lr : [<8081cb63>]
>> sp : fdf42d08  ip : fff9e040     fp : fdf42d50
>> r10: fff8a998  r9 : fdf42ef0     r8 : 00000000
>> r7 : fdf42d28  r6 : fdf42d2c     r5 : fffa5c00  r4 : 00000000
>> r3 : 4a020000  r2 : 00000000     r1 : fdf42e78  r0 : fffa5c00
>> Flags: nzCv  IRQs off  FIQs off  Mode SVC_32
>> Resetting CPU ...
>>
>> resetting ...
>> ----------------------------------cut----------------------------------
>>
>> Fix by adding the CL-SOM-AM57x target to the XHCI registers base address
>> ifdef'ery.
>> A better fix should be based on a SOC family defines (currently
>> missing).
>
> Can you please go add the Kconfig symbols that would be the better
> solution please?  Thanks!
>
The SOC family symbol CONFIG_AM57XX was removed by the commit 3891a54: 
"ARM: DRA7x/AM57xx: Get rid of CONFIG_AM57XX".
Maybe the symbol should be reintroduced just for the XHCI registers 
section?

-- 
Thanks,
Uri

  reply	other threads:[~2017-02-12  8:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09  7:00 [U-Boot] [PATCH 1/6] arm: am57xx: cl-som-am57x: fix XHCI registers base address Uri Mashiach
2017-02-09 20:29 ` Tom Rini
2017-02-12  8:55   ` Uri Mashiach [this message]
2017-02-12 15:47     ` Tom Rini
2017-02-13 11:46       ` Lokesh Vutla
2017-02-13 12:12         ` Uri Mashiach
2017-02-13 12:33           ` Lokesh Vutla
2017-02-14  9:08             ` Uri Mashiach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80f3027a-c19a-3c23-e300-d72590fecbdf@compulab.co.il \
    --to=uri.mashiach@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox