From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 4/6] efi_loader: Remove unused headers from efi_load_initrd.c
Date: Mon, 28 Dec 2020 16:06:25 +0100 [thread overview]
Message-ID: <83a9bb58-2950-228c-e28e-b9cba134ecdc@gmx.de> (raw)
In-Reply-To: <20201228122440.316403-5-ilias.apalodimas@linaro.org>
On 12/28/20 1:24 PM, Ilias Apalodimas wrote:
> dm.h and env.h serve no purpose here. Remove them
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> lib/efi_loader/efi_load_initrd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/efi_loader/efi_load_initrd.c b/lib/efi_loader/efi_load_initrd.c
> index 984fea1bd679..e0b4a82ce037 100644
> --- a/lib/efi_loader/efi_load_initrd.c
> +++ b/lib/efi_loader/efi_load_initrd.c
> @@ -4,10 +4,8 @@
> */
>
> #include <common.h>
> -#include <env.h>
> #include <malloc.h>
> #include <mapmem.h>
> -#include <dm.h>
> #include <fs.h>
> #include <efi_loader.h>
> #include <efi_variable.h>
It would be nice to bring the headers into alphabetic order.
I suggest to apply this change before any other changes to efi_load_initrd.c
Best regards
Heinrich
>
next prev parent reply other threads:[~2020-12-28 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 12:24 [PATCH 0/6] Change logic of EFI LoadFile2 protocol for initrd loading Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 1/6] efi_loader: remove unconditional initialization of file2 protocol for initrd Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 2/6] efi_loader: Introduce helper functions for EFI Ilias Apalodimas
2020-12-28 14:49 ` Heinrich Schuchardt
2020-12-28 22:06 ` Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 3/6] efi_loader: Replace config option with EFI variable for initrd loading Ilias Apalodimas
2020-12-28 13:10 ` Ilias Apalodimas
2020-12-28 14:55 ` Heinrich Schuchardt
2020-12-28 22:03 ` Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 4/6] efi_loader: Remove unused headers from efi_load_initrd.c Ilias Apalodimas
2020-12-28 15:06 ` Heinrich Schuchardt [this message]
2020-12-28 15:08 ` [PATCH] " Heinrich Schuchardt
2020-12-28 12:24 ` [PATCH 5/6] efi_selftest: Modify self-tests for initrd loading Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 6/6] efi_loader: bootmgr: use get_var from efi_helper file Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a9bb58-2950-228c-e28e-b9cba134ecdc@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox