From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH 3/6] efi_loader: Replace config option with EFI variable for initrd loading
Date: Tue, 29 Dec 2020 00:03:57 +0200 [thread overview]
Message-ID: <X+pWTQ0lJEiFbv4n@enceladus> (raw)
In-Reply-To: <2d1353b0-da10-d112-63ac-89418eae1bbe@gmx.de>
Hi Heinrich,
On Mon, Dec 28, 2020 at 03:55:49PM +0100, Heinrich Schuchardt wrote:
[...]
> > ret = try_load_entry(bootorder[i], handle, load_options);
> > - if (ret == EFI_SUCCESS)
> > + if (ret == EFI_SUCCESS) {
> > + if (IS_ENABLED(CONFIG_EFI_LOAD_FILE2_INITRD))
> > + ret = efi_initrd_register();
>
> I think this is not enough.
>
> * We should uninstall the protocol once 'bootefi bootmgr' returns
> to U-Boot.
> * The EFI_LOAD_FILE2_PROTOCOL should be installed on the handle of
> the loaded image for this purpose.
>
Yep you are right. I completely missed that case, I'll fix it on v2
Regards
/Ilias
next prev parent reply other threads:[~2020-12-28 22:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 12:24 [PATCH 0/6] Change logic of EFI LoadFile2 protocol for initrd loading Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 1/6] efi_loader: remove unconditional initialization of file2 protocol for initrd Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 2/6] efi_loader: Introduce helper functions for EFI Ilias Apalodimas
2020-12-28 14:49 ` Heinrich Schuchardt
2020-12-28 22:06 ` Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 3/6] efi_loader: Replace config option with EFI variable for initrd loading Ilias Apalodimas
2020-12-28 13:10 ` Ilias Apalodimas
2020-12-28 14:55 ` Heinrich Schuchardt
2020-12-28 22:03 ` Ilias Apalodimas [this message]
2020-12-28 12:24 ` [PATCH 4/6] efi_loader: Remove unused headers from efi_load_initrd.c Ilias Apalodimas
2020-12-28 15:06 ` Heinrich Schuchardt
2020-12-28 15:08 ` [PATCH] " Heinrich Schuchardt
2020-12-28 12:24 ` [PATCH 5/6] efi_selftest: Modify self-tests for initrd loading Ilias Apalodimas
2020-12-28 12:24 ` [PATCH 6/6] efi_loader: bootmgr: use get_var from efi_helper file Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+pWTQ0lJEiFbv4n@enceladus \
--to=ilias.apalodimas@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox