From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test: hexdump: fix misplaced return
Date: Sun, 9 Dec 2018 21:53:23 +0100 [thread overview]
Message-ID: <86de44cf-49de-60cc-383e-83deebf6e1f3@gmail.com> (raw)
In-Reply-To: <CAPnjgZ1OgYkaX=JvKo+gnZ8_SaX00Ki=B2zEEhORHBTJF+DS9A@mail.gmail.com>
Am 05.12.2018 um 13:55 schrieb Simon Glass:
> On Tue, 4 Dec 2018 at 13:30, Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
>>
>> One of the hexdump tests in test/lib/hexdump.c returns right at the
>> start of the function without testing anything.
>>
>> Fix this by moving the 'return 0;' statement to the end of the function.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>> ---
>>
>> test/lib/hexdump.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> That's one way to make a test pass.
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Is there a plan to make all tests under test/ run with 'make check'?
Seems like this one is not included there?
Simon
next prev parent reply other threads:[~2018-12-09 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 20:30 [U-Boot] [PATCH] test: hexdump: fix misplaced return Simon Goldschmidt
2018-12-05 12:55 ` Simon Glass
2018-12-09 20:53 ` Simon Goldschmidt [this message]
2018-12-11 1:07 ` Simon Glass
2018-12-13 0:47 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86de44cf-49de-60cc-383e-83deebf6e1f3@gmail.com \
--to=simon.k.r.goldschmidt@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox