U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, u-boot@lists.denx.de
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Lukasz Majewski <lukma@denx.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Nishanth Menon <nm@ti.com>, Zixun LI <admin@hifiphile.com>
Subject: Re: [PATCH 3/6] usb: gadget: Track driver data as part of struct usb_gadget
Date: Thu, 29 Aug 2024 09:42:13 +0200	[thread overview]
Message-ID: <8734mnsrl6.fsf@baylibre.com> (raw)
In-Reply-To: <20240826143851.8020-3-marek.vasut+renesas@mailbox.org>

Hi Marek,

Thank you for the patch.

On lun., août 26, 2024 at 16:38, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> Move driver data directly into struct usb_gadget {} in preparation for
> conversion of struct device to struct udevice * in struct usb_gadget.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Zixun LI <admin@hifiphile.com>
> ---
>  include/linux/usb/gadget.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index d62fba0ca02..a2b8520bc99 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -544,17 +544,18 @@ struct usb_gadget {
>  	unsigned			a_alt_hnp_support:1;
>  	const char			*name;
>  	struct device			dev;
> +	void				*driver_data;
>  	unsigned			quirk_ep_out_aligned_size:1;
>  };
>  
>  static inline void set_gadget_data(struct usb_gadget *gadget, void *data)
>  {
> -	gadget->dev.driver_data = data;
> +	gadget->driver_data = data;
>  }
>  
>  static inline void *get_gadget_data(struct usb_gadget *gadget)
>  {
> -	return gadget->dev.driver_data;
> +	return gadget->driver_data;
>  }
>  
>  static inline struct usb_gadget *dev_to_usb_gadget(struct device *dev)
> -- 
> 2.45.2

  reply	other threads:[~2024-08-29  7:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 14:38 [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release Marek Vasut
2024-08-26 14:38 ` [PATCH 2/6] usb: gadget: Drop usb_udc_release() Marek Vasut
2024-08-29  7:41   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 3/6] usb: gadget: Track driver data as part of struct usb_gadget Marek Vasut
2024-08-29  7:42   ` Mattijs Korpershoek [this message]
2024-08-26 14:38 ` [PATCH 4/6] usb: gadget: Drop dev_to_usb_gadget() Marek Vasut
2024-08-29  7:43   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 5/6] usb: gadget: dwc2: Drop get/set_udc_gadget_private_data() Marek Vasut
2024-08-29  7:44   ` Mattijs Korpershoek
2024-08-26 14:38 ` [PATCH 6/6] usb: gadget: Pass struct udevice to usb_add_gadget_udc() Marek Vasut
2024-08-29  8:44   ` Mattijs Korpershoek
2024-08-30 22:44   ` Linus Walleij
2024-08-26 15:47 ` [PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release Miquel Raynal
2024-08-29  7:08 ` Mattijs Korpershoek
2024-09-10  8:27 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734mnsrl6.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=admin@hifiphile.com \
    --cc=linus.walleij@linaro.org \
    --cc=lukma@denx.de \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=neil.armstrong@linaro.org \
    --cc=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox