Re: [PATCH 5/6] usb: gadget: dwc2: Drop get/set_udc_gadget_private_data()

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

Hi Marek,

Thank you for the patch.

On lun., août 26, 2024 at 16:38, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> Neither get_udc_gadget_private_data() nor set_udc_gadget_private_data()
> is ever called anywhere, remove both.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Zixun LI <admin@hifiphile.com>
> ---
>  drivers/usb/gadget/dwc2_udc_otg.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/usb/gadget/dwc2_udc_otg.c b/drivers/usb/gadget/dwc2_udc_otg.c
> index 7e9dd6f4268..fbd6c9600fc 100644
> --- a/drivers/usb/gadget/dwc2_udc_otg.c
> +++ b/drivers/usb/gadget/dwc2_udc_otg.c
> @@ -121,19 +121,6 @@ static void nuke(struct dwc2_ep *ep, int status);
>  static int dwc2_udc_set_halt(struct usb_ep *_ep, int value);
>  static void dwc2_udc_set_nak(struct dwc2_ep *ep);
>  
> -void set_udc_gadget_private_data(void *p)
> -{
> -	debug_cond(DEBUG_SETUP != 0,
> -		   "%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> -		   the_controller, p);
> -	the_controller->gadget.dev.device_data = p;
> -}
> -
> -void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> -{
> -	return gadget->dev.device_data;
> -}
> -
>  static struct usb_ep_ops dwc2_ep_ops = {
>  	.enable = dwc2_ep_enable,
>  	.disable = dwc2_ep_disable,
> -- 
> 2.45.2