U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Lukasz Majewski <lukma@denx.de>
Cc: Tom Rini <trini@konsulko.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Ashok Reddy Soma <ashok.reddy.soma@amd.com>,
	u-boot@lists.denx.de,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Subject: Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver
Date: Tue, 04 Jun 2024 08:38:57 +0200	[thread overview]
Message-ID: <8734pt2ovy.fsf@baylibre.com> (raw)
In-Reply-To: <20240604054425.105902-1-heinrich.schuchardt@canonical.com>

Hi Heinrich,

Thank you for the patch.

On mar., juin 04, 2024 at 07:44, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:

> Building the SPI flash DFU driver fails if SPI flash support is missing.
>
>     drivers/dfu/dfu_sf.c:123:29: error:
>     ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
>
> Add the missing dependency.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  drivers/dfu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 0360d9da142..971204758aa 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -68,6 +68,7 @@ config DFU_RAM
>  
>  config DFU_SF
>  	bool "SPI flash back end for DFU"
> +	depends on SPI_FLASH || DM_SPI_FLASH
>  	help
>  	  This option enables using DFU to read and write to SPI flash based
>  	  storage.
> -- 
> 2.43.0

  reply	other threads:[~2024-06-04  6:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  5:44 [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver Heinrich Schuchardt
2024-06-04  6:38 ` Mattijs Korpershoek [this message]
2024-06-06  7:12 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734pt2ovy.fsf@baylibre.com \
    --to=mkorpershoek@baylibre.com \
    --cc=ashok.reddy.soma@amd.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=jh80.chung@samsung.com \
    --cc=lukma@denx.de \
    --cc=patrick.delaunay@foss.st.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox